[INFO] cloning repository https://github.com/Vigintillionn/vigscript [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Vigintillionn/vigscript" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVigintillionn%2Fvigscript", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVigintillionn%2Fvigscript'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 92a93bf5bf31a04cf64a6c6fe5db294f6e452290 [INFO] checking Vigintillionn/vigscript/92a93bf5bf31a04cf64a6c6fe5db294f6e452290 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVigintillionn%2Fvigscript" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Vigintillionn/vigscript on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Vigintillionn/vigscript [INFO] finished tweaking git repo https://github.com/Vigintillionn/vigscript [INFO] tweaked toml for git repo https://github.com/Vigintillionn/vigscript written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Vigintillionn/vigscript already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b83c47156519b70f5e22b6953daec1c13437652a41f7de0f853bc24fe38f22ee [INFO] running `Command { std: "docker" "start" "-a" "b83c47156519b70f5e22b6953daec1c13437652a41f7de0f853bc24fe38f22ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b83c47156519b70f5e22b6953daec1c13437652a41f7de0f853bc24fe38f22ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b83c47156519b70f5e22b6953daec1c13437652a41f7de0f853bc24fe38f22ee", kill_on_drop: false }` [INFO] [stdout] b83c47156519b70f5e22b6953daec1c13437652a41f7de0f853bc24fe38f22ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dbbc7888b0fb969261ec09610638d549c0032bd922c6d17137a0c18ec908c38a [INFO] running `Command { std: "docker" "start" "-a" "dbbc7888b0fb969261ec09610638d549c0032bd922c6d17137a0c18ec908c38a", kill_on_drop: false }` [INFO] [stderr] Checking vigscript v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/runtime/environment.rs:167:69 [INFO] [stdout] | [INFO] [stdout] 167 | ...elf, object: Option>, val: Option, property: Box, computed: bool) -> values::RuntimeValue { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `computed` [INFO] [stdout] --> src/runtime/environment.rs:167:117 [INFO] [stdout] | [INFO] [stdout] 167 | ...lue>, property: Box, computed: bool) -> values::RuntimeValue { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_computed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/runtime/interpreter.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | _ => panic!("Not implemented {:?}", node) [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/runtime/interpreter.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 18 | Stmt::Expr(node) => evaluate_expr(node, env), [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] 19 | Stmt::VarDecl { mutable, name, value } => evaluate_var_decl(mutable, name, value, env), [INFO] [stdout] | -------------------------------------- matches some of the same values [INFO] [stdout] 20 | Stmt::FuncDecl { params, name, body } => evaluate_func_decl(params, name, body, env), [INFO] [stdout] | ------------------------------------- matches some of the same values [INFO] [stdout] 21 | Stmt::Return { value: _ } => panic!("You can only return from inside a function."), [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 24 | _ => panic!("Not implemented {:?}", node) [INFO] [stdout] | ^ ...and 2 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Property` is never constructed [INFO] [stdout] --> src/frontend/ast.rs:49:3 [INFO] [stdout] | [INFO] [stdout] 30 | pub enum Expr { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 49 | Property(Property), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser.rs:242:27 [INFO] [stdout] | [INFO] [stdout] 240 | let value = self.parse_expr(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | self.consume_expected(TokenType::Semi, "Expected a ';'"); [INFO] [stdout] 242 | Stmt::Return { value: Some(value) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser.rs:349:17 [INFO] [stdout] | [INFO] [stdout] 344 | let iterable = self.parse_expr(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let body = self.parse_block(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | iterable: Box::new(iterable), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/environment.rs:180:11 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn lookup_object_member(&mut self, object: Option>, val: Option, property: Box, computed: bool) -> va... [INFO] [stdout] | ------------------------- ------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | match *object.clone().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/evaluate/expressions.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn evaluate_binary_expr(left: Expr, op: String, right: Expr, env: &mut Environment) -> RuntimeValue { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let lhs = evaluate_expr(left, env); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let rhs = evaluate_expr(right, env); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/evaluate/expressions.rs:109:77 [INFO] [stdout] | [INFO] [stdout] 109 | let runtime_args: Vec = args.iter().map(|arg| evaluate_expr(arg.clone(), env)).collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vigscript` (bin "vigscript" test) due to 6 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `val` [INFO] [stdout] --> src/runtime/environment.rs:167:69 [INFO] [stdout] | [INFO] [stdout] 167 | ...elf, object: Option>, val: Option, property: Box, computed: bool) -> values::RuntimeValue { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_val` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `computed` [INFO] [stdout] --> src/runtime/environment.rs:167:117 [INFO] [stdout] | [INFO] [stdout] 167 | ...lue>, property: Box, computed: bool) -> values::RuntimeValue { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_computed` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/runtime/interpreter.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | _ => panic!("Not implemented {:?}", node) [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/runtime/interpreter.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 18 | Stmt::Expr(node) => evaluate_expr(node, env), [INFO] [stdout] | ---------------- matches some of the same values [INFO] [stdout] 19 | Stmt::VarDecl { mutable, name, value } => evaluate_var_decl(mutable, name, value, env), [INFO] [stdout] | -------------------------------------- matches some of the same values [INFO] [stdout] 20 | Stmt::FuncDecl { params, name, body } => evaluate_func_decl(params, name, body, env), [INFO] [stdout] | ------------------------------------- matches some of the same values [INFO] [stdout] 21 | Stmt::Return { value: _ } => panic!("You can only return from inside a function."), [INFO] [stdout] | ------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 24 | _ => panic!("Not implemented {:?}", node) [INFO] [stdout] | ^ ...and 2 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Property` is never constructed [INFO] [stdout] --> src/frontend/ast.rs:49:3 [INFO] [stdout] | [INFO] [stdout] 30 | pub enum Expr { [INFO] [stdout] | ---- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 49 | Property(Property), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Expr` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser.rs:242:27 [INFO] [stdout] | [INFO] [stdout] 240 | let value = self.parse_expr(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | self.consume_expected(TokenType::Semi, "Expected a ';'"); [INFO] [stdout] 242 | Stmt::Return { value: Some(value) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frontend/parser.rs:349:17 [INFO] [stdout] | [INFO] [stdout] 344 | let iterable = self.parse_expr(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | let body = self.parse_block(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 349 | iterable: Box::new(iterable), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/environment.rs:180:11 [INFO] [stdout] | [INFO] [stdout] 167 | pub fn lookup_object_member(&mut self, object: Option>, val: Option, property: Box, computed: bool) -> va... [INFO] [stdout] | ------------------------- ------------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | match *object.clone().unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/evaluate/expressions.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn evaluate_binary_expr(left: Expr, op: String, right: Expr, env: &mut Environment) -> RuntimeValue { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | let lhs = evaluate_expr(left, env); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let rhs = evaluate_expr(right, env); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | match (lhs, rhs) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/evaluate/expressions.rs:109:77 [INFO] [stdout] | [INFO] [stdout] 109 | let runtime_args: Vec = args.iter().map(|arg| evaluate_expr(arg.clone(), env)).collect(); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vigscript` (bin "vigscript") due to 6 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "dbbc7888b0fb969261ec09610638d549c0032bd922c6d17137a0c18ec908c38a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbbc7888b0fb969261ec09610638d549c0032bd922c6d17137a0c18ec908c38a", kill_on_drop: false }` [INFO] [stdout] dbbc7888b0fb969261ec09610638d549c0032bd922c6d17137a0c18ec908c38a