[INFO] updating cached repository https://github.com/VengeQ/rust_recipes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7269a26fd10615c4f83224b63b2fe8935b4b6f2d [INFO] checking VengeQ/rust_recipes/7269a26fd10615c4f83224b63b2fe8935b4b6f2d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVengeQ%2Frust_recipes" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/VengeQ/rust_recipes on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/VengeQ/rust_recipes [INFO] finished tweaking git repo https://github.com/VengeQ/rust_recipes [INFO] tweaked toml for git repo https://github.com/VengeQ/rust_recipes written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/VengeQ/rust_recipes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 501a77a69b98db7f2ecd29a342ab05394e83b2dcf31d984f96469fc67852eb42 [INFO] running `Command { std: "docker" "start" "-a" "501a77a69b98db7f2ecd29a342ab05394e83b2dcf31d984f96469fc67852eb42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "501a77a69b98db7f2ecd29a342ab05394e83b2dcf31d984f96469fc67852eb42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "501a77a69b98db7f2ecd29a342ab05394e83b2dcf31d984f96469fc67852eb42", kill_on_drop: false }` [INFO] [stdout] 501a77a69b98db7f2ecd29a342ab05394e83b2dcf31d984f96469fc67852eb42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c609cd17c5203f5d9b7977cf47133c226a495a6ad376127b46dc45897d72d2de [INFO] running `Command { std: "docker" "start" "-a" "c609cd17c5203f5d9b7977cf47133c226a495a6ad376127b46dc45897d72d2de", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking rust-pilib v0.1.0 (/opt/rustwide/workdir/rust-pilib) [INFO] [stderr] Checking rust_example v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::time::Duration` [INFO] [stdout] --> src/conc.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::time::Duration; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::Thread` [INFO] [stdout] --> src/conc.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::thread::Thread; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::thread::Thread` [INFO] [stdout] --> src/conc.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::thread::Thread; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a_number` [INFO] [stdout] --> src/conc.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | fn shared_data_thread(a_number: i32, a_vec: Vec) -> thread::JoinHandle> { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_a_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `a_number` [INFO] [stdout] --> src/conc.rs:12:23 [INFO] [stdout] | [INFO] [stdout] 12 | fn shared_data_thread(a_number: i32, a_vec: Vec) -> thread::JoinHandle> { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_a_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/conc.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | for x in 0..10 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `simple_threads_example` is never used [INFO] [stdout] --> src/conc.rs:6:4 [INFO] [stdout] | [INFO] [stdout] 6 | fn simple_threads_example() -> thread::JoinHandle<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shared_data_thread` is never used [INFO] [stdout] --> src/conc.rs:12:4 [INFO] [stdout] | [INFO] [stdout] 12 | fn shared_data_thread(a_number: i32, a_vec: Vec) -> thread::JoinHandle> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `parallel_map` is never used [INFO] [stdout] --> src/conc.rs:21:4 [INFO] [stdout] | [INFO] [stdout] 21 | fn parallel_map(data: Vec>, f: fn(i32) -> i32) -> Vec>> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `shared_date` is never used [INFO] [stdout] --> src/conc.rs:29:4 [INFO] [stdout] | [INFO] [stdout] 29 | fn shared_date(data: Arc>) -> thread::JoinHandle<()> { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `x` [INFO] [stdout] --> src/conc.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | for x in 0..10 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/conc.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | for i in 1..5 { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | sender.send(Person { name: "Vasya".to_owned(), age: random::() % 40 + 10 }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = sender.send(Person { name: "Vasya".to_owned(), age: random::() % 40 + 10 }); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conc.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 29 | fn shared_date(data: Arc>) -> thread::JoinHandle<()> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 31 | | for x in 0..10 { [INFO] [stdout] 32 | | let d = data.lock().unwrap(); [INFO] [stdout] 33 | | //d.push(std::char::from_digit(x, 10).unwrap_or_else(|| '0')); [INFO] [stdout] 34 | | println!("{:?}", d); [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conc.rs:62:32 [INFO] [stdout] | [INFO] [stdout] 62 | .flat_map(|thread| thread.join().unwrap()) [INFO] [stdout] | ------ ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | sender.send(Person { name: "Vasya".to_owned(), age: random::() % 40 + 10 }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 18 | let _ = sender.send(Person { name: "Vasya".to_owned(), age: random::() % 40 + 10 }); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/conc.rs:30:19 [INFO] [stdout] | [INFO] [stdout] 29 | fn shared_date(data: Arc>) -> thread::JoinHandle<()> { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 31 | | for x in 0..10 { [INFO] [stdout] 32 | | let d = data.lock().unwrap(); [INFO] [stdout] 33 | | //d.push(std::char::from_digit(x, 10).unwrap_or_else(|| '0')); [INFO] [stdout] 34 | | println!("{:?}", d); [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_example` (bin "rust_example" test) due to 3 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rust_example` (bin "rust_example") due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c609cd17c5203f5d9b7977cf47133c226a495a6ad376127b46dc45897d72d2de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c609cd17c5203f5d9b7977cf47133c226a495a6ad376127b46dc45897d72d2de", kill_on_drop: false }` [INFO] [stdout] c609cd17c5203f5d9b7977cf47133c226a495a6ad376127b46dc45897d72d2de