[INFO] cloning repository https://github.com/VaranTavers/advent_of_code_2023 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VaranTavers/advent_of_code_2023" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVaranTavers%2Fadvent_of_code_2023", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVaranTavers%2Fadvent_of_code_2023'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 72cad117cfa1d12b464d8bd8c8889427fc530ed0 [INFO] checking VaranTavers/advent_of_code_2023/72cad117cfa1d12b464d8bd8c8889427fc530ed0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVaranTavers%2Fadvent_of_code_2023" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/VaranTavers/advent_of_code_2023 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/VaranTavers/advent_of_code_2023 [INFO] finished tweaking git repo https://github.com/VaranTavers/advent_of_code_2023 [INFO] tweaked toml for git repo https://github.com/VaranTavers/advent_of_code_2023 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/VaranTavers/advent_of_code_2023 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ab38e7e67068d5cb5630e6df09edc4bf7665e477ccadc27d4dda2f7c307d04d [INFO] running `Command { std: "docker" "start" "-a" "0ab38e7e67068d5cb5630e6df09edc4bf7665e477ccadc27d4dda2f7c307d04d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ab38e7e67068d5cb5630e6df09edc4bf7665e477ccadc27d4dda2f7c307d04d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ab38e7e67068d5cb5630e6df09edc4bf7665e477ccadc27d4dda2f7c307d04d", kill_on_drop: false }` [INFO] [stdout] 0ab38e7e67068d5cb5630e6df09edc4bf7665e477ccadc27d4dda2f7c307d04d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f92adb560728ad4bef9e319d1b8a244123c531c97de8ef002ff5b5ef31a16be9 [INFO] running `Command { std: "docker" "start" "-a" "f92adb560728ad4bef9e319d1b8a244123c531c97de8ef002ff5b5ef31a16be9", kill_on_drop: false }` [INFO] [stderr] Checking advent_of_code_2023 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/days/day23.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{HashSet, VecDeque}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HashSet` [INFO] [stdout] --> src/days/day23.rs:2:19 [INFO] [stdout] | [INFO] [stdout] 2 | collections::{HashSet, VecDeque}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/days/day24.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 129 | todo!(); [INFO] [stdout] | ------- any code following this expression is unreachable [INFO] [stdout] 130 | [INFO] [stdout] 131 | Ok(0) [INFO] [stdout] | ^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable expression [INFO] [stdout] --> src/days/day24.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 129 | todo!(); [INFO] [stdout] | ------- any code following this expression is unreachable [INFO] [stdout] 130 | [INFO] [stdout] 131 | Ok(0) [INFO] [stdout] | ^^^^^ unreachable expression [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/days/day10.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | for (j, c) in cols.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bounds` [INFO] [stdout] --> src/days/day18.rs:276:10 [INFO] [stdout] | [INFO] [stdout] 276 | let (bounds, start) = map_bounds_from_lines(&lines); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_bounds` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/days/day10.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | for (j, c) in cols.iter().enumerate() { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `game_num` [INFO] [stdout] --> src/days/day2.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | let game_num = game_split[1].parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_game_num` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lines` [INFO] [stdout] --> src/days/day24.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let lines = reader [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_lines` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/days/day25.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | let mut j = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day25.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | let mut components = nodes.iter().map(|_| false).collect::>(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day25.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | let mut j = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `bounds` [INFO] [stdout] --> src/days/day18.rs:276:10 [INFO] [stdout] | [INFO] [stdout] 276 | let (bounds, start) = map_bounds_from_lines(&lines); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_bounds` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `game_num` [INFO] [stdout] --> src/days/day2.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | let game_num = game_split[1].parse::().unwrap(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_game_num` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gcd` is never used [INFO] [stdout] --> src/days/day11.rs:149:4 [INFO] [stdout] | [INFO] [stdout] 149 | fn gcd(a: usize, b: usize) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MIN_Z` is never used [INFO] [stdout] --> src/days/day24.rs:56:7 [INFO] [stdout] | [INFO] [stdout] 56 | const MIN_Z: f64 = 100.0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAX_Z` is never used [INFO] [stdout] --> src/days/day24.rs:59:7 [INFO] [stdout] | [INFO] [stdout] 59 | const MAX_Z: f64 = 100.0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start` and `velocity` are never read [INFO] [stdout] --> src/days/day24.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct Line3D { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 96 | pub start: (f64, f64, f64), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 97 | pub velocity: (f64, f64, f64), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Line3D` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution_2` is never used [INFO] [stdout] --> src/days/day24.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn solution_2(reader: BufReader) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `connections_between_components` is never used [INFO] [stdout] --> src/days/day25.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn connections_between_components(map: &Vec>, components: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `conns_between_comps_n` is never used [INFO] [stdout] --> src/days/day25.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn conns_between_comps_n(map: &Vec>, components: &Vec, n: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `neighbors_with_component` is never used [INFO] [stdout] --> src/days/day25.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn neighbors_with_component( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `neighbors_with_component_n` is never used [INFO] [stdout] --> src/days/day25.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn neighbors_with_component_n( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `backtrack` is never used [INFO] [stdout] --> src/days/day25.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn backtrack( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sort_rules` is never used [INFO] [stdout] --> src/days/day5.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Mapper { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn sort_rules(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `parse_maps` and `find_all` are never used [INFO] [stdout] --> src/utils/charmap.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl CharMap { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn parse_maps(reader: BufReader) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn find_all(&self, needle: char) -> Vec<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day1.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn solution(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(reader [INFO] [stdout] | ________^ [INFO] [stdout] 71 | | .lines() [INFO] [stdout] 72 | | .map(|x| get_number_from_line(&x.unwrap())) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_J` should have a snake case name [INFO] [stdout] --> src/days/day18.rs:118:4 [INFO] [stdout] | [INFO] [stdout] 118 | fn is_J(map: &Vec>>, row: usize, col: usize) -> bool { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `is_j` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_L` should have a snake case name [INFO] [stdout] --> src/days/day18.rs:126:4 [INFO] [stdout] | [INFO] [stdout] 126 | fn is_L(map: &Vec>>, row: usize, col: usize) -> bool { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `is_l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day19.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 67 | let if_true = Rule::parse_into_either(query_and_true.1); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let if_false = Rule::parse_into_either(parts.1); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | Either::Left(Box::new(Rule { [INFO] [stdout] | ______________________^ [INFO] [stdout] 71 | | property: query_parts.0.chars().nth(0).unwrap(), [INFO] [stdout] 72 | | num: query_parts.1.parse::().unwrap(), [INFO] [stdout] 73 | | rule, [INFO] [stdout] 74 | | if_true, [INFO] [stdout] 75 | | if_false, [INFO] [stdout] 76 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day19.rs:314:10 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn solution_2(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let mut lines = reader.lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | let rules = lines_to_workflows(&mut lines); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | &Either::Left(Box::new(rules.get("in").unwrap().clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day2.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn solution_1(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(reader.lines().filter_map(|x| validate_1(&x.unwrap())).sum()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day2.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn solution_2(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(reader.lines().filter_map(|x| validate_2(&x.unwrap())).sum()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day3.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | .filter_map(|x| x.map(|y| y.chars().collect::>()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day3.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | .filter_map(|x| x.map(|y| y.chars().collect::>()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code_2023` (bin "advent_of_code_2023" test) due to 8 previous errors; 23 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `lines` [INFO] [stdout] --> src/days/day24.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | let lines = reader [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_lines` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/days/day25.rs:144:13 [INFO] [stdout] | [INFO] [stdout] 144 | let mut j = 0; [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day25.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | let mut components = nodes.iter().map(|_| false).collect::>(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/days/day25.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | let mut j = 0; [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `gcd` is never used [INFO] [stdout] --> src/days/day11.rs:149:4 [INFO] [stdout] | [INFO] [stdout] 149 | fn gcd(a: usize, b: usize) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MIN_Z` is never used [INFO] [stdout] --> src/days/day24.rs:56:7 [INFO] [stdout] | [INFO] [stdout] 56 | const MIN_Z: f64 = 100.0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MAX_Z` is never used [INFO] [stdout] --> src/days/day24.rs:59:7 [INFO] [stdout] | [INFO] [stdout] 59 | const MAX_Z: f64 = 100.0; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `start` and `velocity` are never read [INFO] [stdout] --> src/days/day24.rs:96:9 [INFO] [stdout] | [INFO] [stdout] 95 | pub struct Line3D { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 96 | pub start: (f64, f64, f64), [INFO] [stdout] | ^^^^^ [INFO] [stdout] 97 | pub velocity: (f64, f64, f64), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Line3D` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `solution_2` is never used [INFO] [stdout] --> src/days/day24.rs:123:8 [INFO] [stdout] | [INFO] [stdout] 123 | pub fn solution_2(reader: BufReader) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `connections_between_components` is never used [INFO] [stdout] --> src/days/day25.rs:7:8 [INFO] [stdout] | [INFO] [stdout] 7 | pub fn connections_between_components(map: &Vec>, components: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `conns_between_comps_n` is never used [INFO] [stdout] --> src/days/day25.rs:17:8 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn conns_between_comps_n(map: &Vec>, components: &Vec, n: usize) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `neighbors_with_component` is never used [INFO] [stdout] --> src/days/day25.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn neighbors_with_component( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `neighbors_with_component_n` is never used [INFO] [stdout] --> src/days/day25.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn neighbors_with_component_n( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `backtrack` is never used [INFO] [stdout] --> src/days/day25.rs:55:8 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn backtrack( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `sort_rules` is never used [INFO] [stdout] --> src/days/day5.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Mapper { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn sort_rules(&mut self) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `parse_maps` and `find_all` are never used [INFO] [stdout] --> src/utils/charmap.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 12 | impl CharMap { [INFO] [stdout] | ------------ associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn parse_maps(reader: BufReader) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 79 | pub fn find_all(&self, needle: char) -> Vec<(usize, usize)> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day1.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn solution(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Ok(reader [INFO] [stdout] | ________^ [INFO] [stdout] 71 | | .lines() [INFO] [stdout] 72 | | .map(|x| get_number_from_line(&x.unwrap())) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_J` should have a snake case name [INFO] [stdout] --> src/days/day18.rs:118:4 [INFO] [stdout] | [INFO] [stdout] 118 | fn is_J(map: &Vec>>, row: usize, col: usize) -> bool { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `is_j` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_L` should have a snake case name [INFO] [stdout] --> src/days/day18.rs:126:4 [INFO] [stdout] | [INFO] [stdout] 126 | fn is_L(map: &Vec>>, row: usize, col: usize) -> bool { [INFO] [stdout] | ^^^^ help: convert the identifier to snake case: `is_l` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day19.rs:70:22 [INFO] [stdout] | [INFO] [stdout] 67 | let if_true = Rule::parse_into_either(query_and_true.1); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let if_false = Rule::parse_into_either(parts.1); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | [INFO] [stdout] 70 | Either::Left(Box::new(Rule { [INFO] [stdout] | ______________________^ [INFO] [stdout] 71 | | property: query_parts.0.chars().nth(0).unwrap(), [INFO] [stdout] 72 | | num: query_parts.1.parse::().unwrap(), [INFO] [stdout] 73 | | rule, [INFO] [stdout] 74 | | if_true, [INFO] [stdout] 75 | | if_false, [INFO] [stdout] 76 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day19.rs:314:10 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn solution_2(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let mut lines = reader.lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | let rules = lines_to_workflows(&mut lines); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 314 | &Either::Left(Box::new(rules.get("in").unwrap().clone())), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day2.rs:36:8 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn solution_1(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Ok(reader.lines().filter_map(|x| validate_1(&x.unwrap())).sum()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day2.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn solution_2(reader: BufReader) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok(reader.lines().filter_map(|x| validate_2(&x.unwrap())).sum()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day3.rs:97:25 [INFO] [stdout] | [INFO] [stdout] 97 | .filter_map(|x| x.map(|y| y.chars().collect::>()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/days/day3.rs:126:25 [INFO] [stdout] | [INFO] [stdout] 126 | .filter_map(|x| x.map(|y| y.chars().collect::>()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 23 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `advent_of_code_2023` (bin "advent_of_code_2023") due to 8 previous errors; 23 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f92adb560728ad4bef9e319d1b8a244123c531c97de8ef002ff5b5ef31a16be9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f92adb560728ad4bef9e319d1b8a244123c531c97de8ef002ff5b5ef31a16be9", kill_on_drop: false }` [INFO] [stdout] f92adb560728ad4bef9e319d1b8a244123c531c97de8ef002ff5b5ef31a16be9