[INFO] cloning repository https://github.com/Vaiem/FerstServer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Vaiem/FerstServer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVaiem%2FFerstServer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVaiem%2FFerstServer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5b391c9ea7c32b54658a895731adccd22ae2b7e3 [INFO] checking Vaiem/FerstServer/5b391c9ea7c32b54658a895731adccd22ae2b7e3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVaiem%2FFerstServer" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Vaiem/FerstServer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Vaiem/FerstServer [INFO] finished tweaking git repo https://github.com/Vaiem/FerstServer [INFO] tweaked toml for git repo https://github.com/Vaiem/FerstServer written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Vaiem/FerstServer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] adc2182e555f0f7dab35d12ce776c7a0670456315719cb0b29d5fbabb6f479ff [INFO] running `Command { std: "docker" "start" "-a" "adc2182e555f0f7dab35d12ce776c7a0670456315719cb0b29d5fbabb6f479ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "adc2182e555f0f7dab35d12ce776c7a0670456315719cb0b29d5fbabb6f479ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "adc2182e555f0f7dab35d12ce776c7a0670456315719cb0b29d5fbabb6f479ff", kill_on_drop: false }` [INFO] [stdout] adc2182e555f0f7dab35d12ce776c7a0670456315719cb0b29d5fbabb6f479ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 768b2c3a0692a1ca60d41d3b34d459bb9e5c1232e4dc24fb533f62eb038d6911 [INFO] running `Command { std: "docker" "start" "-a" "768b2c3a0692a1ca60d41d3b34d459bb9e5c1232e4dc24fb533f62eb038d6911", kill_on_drop: false }` [INFO] [stderr] Checking FerstServer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: crate `FerstServer` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `ferst_server` [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `ServerThread` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod ServerThread [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `server_thread` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module `ServerThread` should have a snake case name [INFO] [stdout] --> src/lib.rs:1:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod ServerThread [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `server_thread` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:27:42 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = mpsc::channel::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | let Reseiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | ThreadPool{ workers, sender: Some(sender) } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:27:42 [INFO] [stdout] | [INFO] [stdout] 17 | let (sender, receiver) = mpsc::channel::(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | [INFO] [stdout] 19 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | let Reseiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | ThreadPool{ workers, sender: Some(sender) } [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Reseiver` should have a snake case name [INFO] [stdout] --> src/lib.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | let Reseiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `reseiver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Reseiver` should have a snake case name [INFO] [stdout] --> src/lib.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | let Reseiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `reseiver` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 64 | fn new( Id : usize, receiver : Arc>>) -> Worker{ [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let newThread = thread::spawn(move || loop { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | thread : Some(newThread), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:84:26 [INFO] [stdout] | [INFO] [stdout] 64 | fn new( Id : usize, receiver : Arc>>) -> Worker{ [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | [INFO] [stdout] 66 | let newThread = thread::spawn(move || loop { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | thread : Some(newThread), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Id` should have a snake case name [INFO] [stdout] --> src/lib.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | fn new( Id : usize, receiver : Arc>>) -> Worker{ [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Id` should have a snake case name [INFO] [stdout] --> src/lib.rs:64:17 [INFO] [stdout] | [INFO] [stdout] 64 | fn new( Id : usize, receiver : Arc>>) -> Worker{ [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newThread` should have a snake case name [INFO] [stdout] --> src/lib.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | let newThread = thread::spawn(move || loop { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `new_thread` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `newThread` should have a snake case name [INFO] [stdout] --> src/lib.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | let newThread = thread::spawn(move || loop { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `new_thread` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `FerstServer` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `FerstServer` (lib) due to 3 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "768b2c3a0692a1ca60d41d3b34d459bb9e5c1232e4dc24fb533f62eb038d6911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "768b2c3a0692a1ca60d41d3b34d459bb9e5c1232e4dc24fb533f62eb038d6911", kill_on_drop: false }` [INFO] [stdout] 768b2c3a0692a1ca60d41d3b34d459bb9e5c1232e4dc24fb533f62eb038d6911