[INFO] cloning repository https://github.com/Ukendio/zinc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ukendio/zinc" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUkendio%2Fzinc", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUkendio%2Fzinc'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 13a40c5334d2a61eba376c229c99308978222e17 [INFO] checking Ukendio/zinc/13a40c5334d2a61eba376c229c99308978222e17 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUkendio%2Fzinc" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Ukendio/zinc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Ukendio/zinc [INFO] finished tweaking git repo https://github.com/Ukendio/zinc [INFO] tweaked toml for git repo https://github.com/Ukendio/zinc written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Ukendio/zinc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3bf9c714e586885fcd4f4b11268c876b3de094ef17072d370a1e6db981820a5b [INFO] running `Command { std: "docker" "start" "-a" "3bf9c714e586885fcd4f4b11268c876b3de094ef17072d370a1e6db981820a5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3bf9c714e586885fcd4f4b11268c876b3de094ef17072d370a1e6db981820a5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bf9c714e586885fcd4f4b11268c876b3de094ef17072d370a1e6db981820a5b", kill_on_drop: false }` [INFO] [stdout] 3bf9c714e586885fcd4f4b11268c876b3de094ef17072d370a1e6db981820a5b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d1f05042ccab35fe429549b3f3c282c315864ba7b11a69d45d60c7ef8b04c8c [INFO] running `Command { std: "docker" "start" "-a" "0d1f05042ccab35fe429549b3f3c282c315864ba7b11a69d45d60c7ef8b04c8c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking zinc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/editor.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | let mut offset = &mut self.offset; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `len` [INFO] [stdout] --> src/editor.rs:270:7 [INFO] [stdout] | [INFO] [stdout] 270 | let len = status.len() + line_indicator.len(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_len` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/document.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | for value in contents.lines() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `next_row` [INFO] [stdout] --> src/document.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 82 | let next_row = self.rows.remove(at.y + 1); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_next_row` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STATUS_BG_COLOR` is never used [INFO] [stdout] --> src/editor.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const STATUS_BG_COLOR: color::Rgb = color::Rgb(239, 239, 239); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/editor.rs:333:12 [INFO] [stdout] | [INFO] [stdout] 333 | panic!(e); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 333 | panic!("{}", e); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 333 | std::panic::panic_any(e); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | size: Size { [INFO] [stdout] 22 | | width: size.0, [INFO] [stdout] 23 | | height: size.1.saturating_sub(2), [INFO] [stdout] 24 | | }, [INFO] [stdout] 25 | | _stdout: stdout().into_raw_mode()?, [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/editor.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | let mut offset = &mut self.offset; [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `len` [INFO] [stdout] --> src/editor.rs:270:7 [INFO] [stdout] | [INFO] [stdout] 270 | let len = status.len() + line_indicator.len(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_len` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/document.rs:18:7 [INFO] [stdout] | [INFO] [stdout] 18 | for value in contents.lines() { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zinc` (bin "zinc" test) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `next_row` [INFO] [stdout] --> src/document.rs:82:8 [INFO] [stdout] | [INFO] [stdout] 82 | let next_row = self.rows.remove(at.y + 1); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_next_row` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STATUS_BG_COLOR` is never used [INFO] [stdout] --> src/editor.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | const STATUS_BG_COLOR: color::Rgb = color::Rgb(239, 239, 239); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/editor.rs:333:12 [INFO] [stdout] | [INFO] [stdout] 333 | panic!(e); [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 333 | panic!("{}", e); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 333 | std::panic::panic_any(e); [INFO] [stdout] | ~~~~~~~~~~~~~~~~~~~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:20:12 [INFO] [stdout] | [INFO] [stdout] 20 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 21 | | size: Size { [INFO] [stdout] 22 | | width: size.0, [INFO] [stdout] 23 | | height: size.1.saturating_sub(2), [INFO] [stdout] 24 | | }, [INFO] [stdout] 25 | | _stdout: stdout().into_raw_mode()?, [INFO] [stdout] 26 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `zinc` (bin "zinc") due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0d1f05042ccab35fe429549b3f3c282c315864ba7b11a69d45d60c7ef8b04c8c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d1f05042ccab35fe429549b3f3c282c315864ba7b11a69d45d60c7ef8b04c8c", kill_on_drop: false }` [INFO] [stdout] 0d1f05042ccab35fe429549b3f3c282c315864ba7b11a69d45d60c7ef8b04c8c