[INFO] cloning repository https://github.com/USJ-Te/exa_local [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/USJ-Te/exa_local" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUSJ-Te%2Fexa_local", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUSJ-Te%2Fexa_local'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 22a9643aa7db1f320ef9d1edf8bd80a6f18ff6fc [INFO] checking USJ-Te/exa_local/22a9643aa7db1f320ef9d1edf8bd80a6f18ff6fc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUSJ-Te%2Fexa_local" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/USJ-Te/exa_local on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/USJ-Te/exa_local [INFO] finished tweaking git repo https://github.com/USJ-Te/exa_local [INFO] tweaked toml for git repo https://github.com/USJ-Te/exa_local written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/USJ-Te/exa_local already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de3c5eaebaed47ed1f148869f5fa2137f11fe7ee1209fa1fdb1a3f7ac0468094 [INFO] running `Command { std: "docker" "start" "-a" "de3c5eaebaed47ed1f148869f5fa2137f11fe7ee1209fa1fdb1a3f7ac0468094", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de3c5eaebaed47ed1f148869f5fa2137f11fe7ee1209fa1fdb1a3f7ac0468094", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de3c5eaebaed47ed1f148869f5fa2137f11fe7ee1209fa1fdb1a3f7ac0468094", kill_on_drop: false }` [INFO] [stdout] de3c5eaebaed47ed1f148869f5fa2137f11fe7ee1209fa1fdb1a3f7ac0468094 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34670791e474d6204b9cc52fe7f83509e6c1e143b18bfc744cc6f6b1bd1fd480 [INFO] running `Command { std: "docker" "start" "-a" "34670791e474d6204b9cc52fe7f83509e6c1e143b18bfc744cc6f6b1bd1fd480", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking tinyvec v1.2.0 [INFO] [stderr] Checking unicode-bidi v0.3.5 [INFO] [stderr] Compiling pad v0.1.6 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking term_grid v0.1.7 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking natord v1.0.9 [INFO] [stderr] Checking locale v0.2.2 [INFO] [stderr] Checking terminal_size v0.1.16 [INFO] [stderr] Checking users v0.11.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling jobserver v0.1.22 [INFO] [stderr] Checking datetime v0.5.2 [INFO] [stderr] Checking unicode-normalization v0.1.17 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Checking zoneinfo_compiled v0.5.1 [INFO] [stderr] Compiling exa v0.10.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling libz-sys v1.1.2 [INFO] [stderr] Compiling libgit2-sys v0.12.21+1.1.0 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.1 [INFO] [stderr] Checking git2 v0.13.20 [INFO] [stdout] warning: unused imports: `DisplayWidth`, `TextCellContents`, and `TextCell` [INFO] [stdout] --> src/output/mod.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | pub use self::cell::{TextCell, TextCellContents, DisplayWidth}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | #![warn(unused)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_imports)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::ui_styles::Size as SizeColours` [INFO] [stdout] --> src/theme/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use self::ui_styles::Size as SizeColours; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: rule #3 of macro `test` is never used [INFO] [stdout] --> src/options/view.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | ($name:ident: $type:ident <- $inputs:expr; $stricts:expr => like $pat:pat) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | #![warn(unused)] [INFO] [stdout] | ^^^^^^ [INFO] [stdout] = note: `#[warn(unused_macro_rules)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `DisplayWidth`, `TextCellContents`, and `TextCell` [INFO] [stdout] --> src/output/mod.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | pub use self::cell::{TextCell, TextCellContents, DisplayWidth}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self::ui_styles::Size as SizeColours` [INFO] [stdout] --> src/theme/mod.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use self::ui_styles::Size as SizeColours; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: rule #3 of macro `test` is never used [INFO] [stdout] --> src/theme/mod.rs:380:9 [INFO] [stdout] | [INFO] [stdout] 380 | ($name:ident: ls $ls:expr, exa $exa:expr => colours $expected:ident -> $process_expected:expr, exts $mappings:expr) => { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `symlink_attributes` is never used [INFO] [stdout] --> src/fs/feature/xattr.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait FileAttributes { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] 14 | fn attributes(&self) -> io::Result>; [INFO] [stdout] 15 | fn symlink_attributes(&self) -> io::Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/file.rs:252:15 [INFO] [stdout] | [INFO] [stdout] 245 | Err(e) => return FileTarget::Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | match std::fs::metadata(&absolute_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/feature/xattr.rs:61:51 [INFO] [stdout] | [INFO] [stdout] 61 | let c_path = match path.to_str().and_then(|s| CString::new(s).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/grid_details.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | ... .map(|file| self.file_style.for_file(file, self.theme).paint().promote()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/tree.rs:187:14 [INFO] [stdout] | [INFO] [stdout] 183 | let t = self.inner.next()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Some((params, t)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exa` (bin "exa") due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `symlink_attributes` is never used [INFO] [stdout] --> src/fs/feature/xattr.rs:15:8 [INFO] [stdout] | [INFO] [stdout] 13 | pub trait FileAttributes { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] 14 | fn attributes(&self) -> io::Result>; [INFO] [stdout] 15 | fn symlink_attributes(&self) -> io::Result>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` implied by `#[warn(unused)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MockVars` is never constructed [INFO] [stdout] --> src/options/theme.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 100 | struct MockVars { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/file.rs:252:15 [INFO] [stdout] | [INFO] [stdout] 245 | Err(e) => return FileTarget::Err(e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | match std::fs::metadata(&absolute_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fs/feature/xattr.rs:61:51 [INFO] [stdout] | [INFO] [stdout] 61 | let c_path = match path.to_str().and_then(|s| CString::new(s).ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/options/theme.rs:109:44 [INFO] [stdout] | [INFO] [stdout] 109 | Some(OsString::from(self.ls.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/options/theme.rs:112:45 [INFO] [stdout] | [INFO] [stdout] 112 | Some(OsString::from(self.exa.clone())) [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/grid_details.rs:157:42 [INFO] [stdout] | [INFO] [stdout] 157 | ... .map(|file| self.file_style.for_file(file, self.theme).paint().promote()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/tree.rs:187:14 [INFO] [stdout] | [INFO] [stdout] 183 | let t = self.inner.next()?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | Some((params, t)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `exa` (bin "exa" test) due to 5 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "34670791e474d6204b9cc52fe7f83509e6c1e143b18bfc744cc6f6b1bd1fd480", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34670791e474d6204b9cc52fe7f83509e6c1e143b18bfc744cc6f6b1bd1fd480", kill_on_drop: false }` [INFO] [stdout] 34670791e474d6204b9cc52fe7f83509e6c1e143b18bfc744cc6f6b1bd1fd480