[INFO] cloning repository https://github.com/Twister915/mctokio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Twister915/mctokio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTwister915%2Fmctokio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTwister915%2Fmctokio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b915bc1c54599d35f188bb301d2b725abc6a7289 [INFO] checking Twister915/mctokio/b915bc1c54599d35f188bb301d2b725abc6a7289 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTwister915%2Fmctokio" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Twister915/mctokio on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-6-tc2/source/.cargo/config [INFO] started tweaking git repo https://github.com/Twister915/mctokio [INFO] finished tweaking git repo https://github.com/Twister915/mctokio [INFO] tweaked toml for git repo https://github.com/Twister915/mctokio written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Twister915/mctokio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] baacbca93217c26eda7be42a61f18e85378d989f5e7d4d3e44d0dca6a3a445d0 [INFO] running `Command { std: "docker" "start" "-a" "baacbca93217c26eda7be42a61f18e85378d989f5e7d4d3e44d0dca6a3a445d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "baacbca93217c26eda7be42a61f18e85378d989f5e7d4d3e44d0dca6a3a445d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "baacbca93217c26eda7be42a61f18e85378d989f5e7d4d3e44d0dca6a3a445d0", kill_on_drop: false }` [INFO] [stdout] baacbca93217c26eda7be42a61f18e85378d989f5e7d4d3e44d0dca6a3a445d0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 268bc43ad6f474a241a1cc7248adf5dcf8cb9c1700ef7943367303a280de1add [INFO] running `Command { std: "docker" "start" "-a" "268bc43ad6f474a241a1cc7248adf5dcf8cb9c1700ef7943367303a280de1add", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.80 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.52 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling getrandom v0.1.15 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling cc v1.0.65 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling miniz_oxide v0.4.3 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling anyhow v1.0.34 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking net2 v0.2.36 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Compiling libz-sys v1.1.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking flate2 v1.0.19 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking cipher v0.2.5 [INFO] [stderr] Checking aes-soft v0.6.4 [INFO] [stderr] Checking aes v0.6.0 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Checking tokio v0.2.23 [INFO] [stderr] Checking mcproto-rs v0.2.0 (https://github.com/Twister915/mcproto-rs?branch=master#2bc1e9b2) [INFO] [stderr] Checking mctokio v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/writer.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | &VarInt(data_len as i32).mc_serialize(&mut data_len_serializer)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 139 | let _ = &VarInt(data_len as i32).mc_serialize(&mut data_len_serializer)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_connection(conn: TcpStream, read_direction: PacketDirection) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let (reader, writer) = conn.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let reader = io::BufReader::with_capacity(BUF_CAP, reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | reader: TcpReadBridge::initial(read_direction, reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_connection(conn: TcpStream, read_direction: PacketDirection) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let (reader, writer) = conn.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let reader = io::BufReader::with_capacity(BUF_CAP, reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | writer: TcpWriteBridge::initial(read_direction.opposite(), writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:51:10 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn into_inner(self) -> (io::BufReader, OwnedWriteHalf) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (self.reader.into_inner(), self.writer.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:51:36 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn into_inner(self) -> (io::BufReader, OwnedWriteHalf) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (self.reader.into_inner(), self.writer.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/net.rs:79:42 [INFO] [stdout] | [INFO] [stdout] 79 | self.reader.enable_encryption(key.clone(), iv.clone())?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/net.rs:79:54 [INFO] [stdout] | [INFO] [stdout] 79 | self.reader.enable_encryption(key.clone(), iv.clone())?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> src/writer.rs:139:17 [INFO] [stdout] | [INFO] [stdout] 139 | &VarInt(data_len as i32).mc_serialize(&mut data_len_serializer)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 139 | let _ = &VarInt(data_len as i32).mc_serialize(&mut data_len_serializer)?; [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_connection(conn: TcpStream, read_direction: PacketDirection) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let (reader, writer) = conn.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let reader = io::BufReader::with_capacity(BUF_CAP, reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | reader: TcpReadBridge::initial(read_direction, reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_connection(conn: TcpStream, read_direction: PacketDirection) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let (reader, writer) = conn.into_split(); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let reader = io::BufReader::with_capacity(BUF_CAP, reader); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | writer: TcpWriteBridge::initial(read_direction.opposite(), writer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:51:10 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn into_inner(self) -> (io::BufReader, OwnedWriteHalf) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (self.reader.into_inner(), self.writer.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/net.rs:51:36 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn into_inner(self) -> (io::BufReader, OwnedWriteHalf) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (self.reader.into_inner(), self.writer.into_inner()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/net.rs:79:42 [INFO] [stdout] | [INFO] [stdout] 79 | self.reader.enable_encryption(key.clone(), iv.clone())?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/net.rs:79:54 [INFO] [stdout] | [INFO] [stdout] 79 | self.reader.enable_encryption(key.clone(), iv.clone())?; [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mctokio` (lib test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mctokio` (lib) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "268bc43ad6f474a241a1cc7248adf5dcf8cb9c1700ef7943367303a280de1add", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "268bc43ad6f474a241a1cc7248adf5dcf8cb9c1700ef7943367303a280de1add", kill_on_drop: false }` [INFO] [stdout] 268bc43ad6f474a241a1cc7248adf5dcf8cb9c1700ef7943367303a280de1add