[INFO] cloning repository https://github.com/TsaoLun/ml-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TsaoLun/ml-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTsaoLun%2Fml-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTsaoLun%2Fml-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c2bb407ab86489144631d3c3f325f74a5dadde15 [INFO] checking TsaoLun/ml-rs/c2bb407ab86489144631d3c3f325f74a5dadde15 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTsaoLun%2Fml-rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TsaoLun/ml-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TsaoLun/ml-rs [INFO] finished tweaking git repo https://github.com/TsaoLun/ml-rs [INFO] tweaked toml for git repo https://github.com/TsaoLun/ml-rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TsaoLun/ml-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a90fb80ca8b63e2bf4118a5216074b1325dcaf3abe640eea625ab00587e6433a [INFO] running `Command { std: "docker" "start" "-a" "a90fb80ca8b63e2bf4118a5216074b1325dcaf3abe640eea625ab00587e6433a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a90fb80ca8b63e2bf4118a5216074b1325dcaf3abe640eea625ab00587e6433a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a90fb80ca8b63e2bf4118a5216074b1325dcaf3abe640eea625ab00587e6433a", kill_on_drop: false }` [INFO] [stdout] a90fb80ca8b63e2bf4118a5216074b1325dcaf3abe640eea625ab00587e6433a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4ce0defe1f986d4b69fc3d07339f18addf5f145d162045eb24fa2b986dafaaa9 [INFO] running `Command { std: "docker" "start" "-a" "4ce0defe1f986d4b69fc3d07339f18addf5f145d162045eb24fa2b986dafaaa9", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking mnist v0.5.0 [INFO] [stderr] Checking matrixmultiply v0.3.2 [INFO] [stderr] Checking num-complex v0.4.3 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Checking ml-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::learn_data::LearnData` [INFO] [stdout] --> src/ch3_nlp.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::learn_data::LearnData; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | image_parts: image_parts.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | image_parts: image_parts.unwrap(), [INFO] [stdout] 34 | expected_class: Array1::from_shape_vec(OUTPUT_SIZE, expected_class.into()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:43:30 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | image_parts: image_parts.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | image_parts: image_parts.unwrap(), [INFO] [stdout] 44 | expected_class: Array1::from_shape_vec(OUTPUT_SIZE, expected_class.into()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch3_nlp.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 160 | fn predict(mut network: HashMap<&str, Array>, x: Array2) -> Array { [INFO] [stdout] | --------------------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (W1, W2, W3) = ( [INFO] [stdout] | -- -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let (b1, b2, b3) = ( [INFO] [stdout] | -- -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let a1 = x.dot(&W1.unwrap().into_dimensionality::().unwrap()) + b1.unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let z1 = sigmod(a1).into_dimensionality::().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let a2 = z1.dot(&W2.unwrap().into_dimensionality::().unwrap()) + b2.unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let z2 = sigmod(a2).into_dimensionality::().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let a3 = z2.dot(&W3.unwrap().into_dimensionality::().unwrap()) + b3.unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | / softmax(a3) [INFO] [stdout] 177 | | .map(|e| e.round() as u8) [INFO] [stdout] 178 | | .into_dimensionality::() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ml-rs` (bin "ml-rs") due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `acc` [INFO] [stdout] --> src/ch3_nlp.rs:186:13 [INFO] [stdout] | [INFO] [stdout] 186 | let mut acc = 0; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_acc` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/ch3_nlp.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | let p = predict(network.clone(), test[i].image_parts.map(|e| *e as f64)); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/ch3_nlp.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | let mut acc = 0; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | image_parts: image_parts.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:34:33 [INFO] [stdout] | [INFO] [stdout] 32 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | image_parts: image_parts.unwrap(), [INFO] [stdout] 34 | expected_class: Array1::from_shape_vec(OUTPUT_SIZE, expected_class.into()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:43:30 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | image_parts: image_parts.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/learn_data.rs:44:33 [INFO] [stdout] | [INFO] [stdout] 42 | .map(|(image_parts, expected_class)| Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | image_parts: image_parts.unwrap(), [INFO] [stdout] 44 | expected_class: Array1::from_shape_vec(OUTPUT_SIZE, expected_class.into()).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ch3_nlp.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 160 | fn predict(mut network: HashMap<&str, Array>, x: Array2) -> Array { [INFO] [stdout] | --------------------------------------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let (W1, W2, W3) = ( [INFO] [stdout] | -- -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let (b1, b2, b3) = ( [INFO] [stdout] | -- -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | let a1 = x.dot(&W1.unwrap().into_dimensionality::().unwrap()) + b1.unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 172 | let z1 = sigmod(a1).into_dimensionality::().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | let a2 = z1.dot(&W2.unwrap().into_dimensionality::().unwrap()) + b2.unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | let z2 = sigmod(a2).into_dimensionality::().unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | let a3 = z2.dot(&W3.unwrap().into_dimensionality::().unwrap()) + b3.unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | / softmax(a3) [INFO] [stdout] 177 | | .map(|e| e.round() as u8) [INFO] [stdout] 178 | | .into_dimensionality::() [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ml-rs` (bin "ml-rs" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4ce0defe1f986d4b69fc3d07339f18addf5f145d162045eb24fa2b986dafaaa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4ce0defe1f986d4b69fc3d07339f18addf5f145d162045eb24fa2b986dafaaa9", kill_on_drop: false }` [INFO] [stdout] 4ce0defe1f986d4b69fc3d07339f18addf5f145d162045eb24fa2b986dafaaa9