[INFO] cloning repository https://github.com/TroyNeubauer/asmall-sink [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TroyNeubauer/asmall-sink" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTroyNeubauer%2Fasmall-sink", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTroyNeubauer%2Fasmall-sink'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0caba6b8d9eac7dbbda8356877f6562d85c45ea2 [INFO] checking TroyNeubauer/asmall-sink/0caba6b8d9eac7dbbda8356877f6562d85c45ea2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTroyNeubauer%2Fasmall-sink" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TroyNeubauer/asmall-sink on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TroyNeubauer/asmall-sink [INFO] finished tweaking git repo https://github.com/TroyNeubauer/asmall-sink [INFO] tweaked toml for git repo https://github.com/TroyNeubauer/asmall-sink written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TroyNeubauer/asmall-sink already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f5e49cd6db816061947788932cf1e3e0611597227d90d1576acd3966446e670 [INFO] running `Command { std: "docker" "start" "-a" "1f5e49cd6db816061947788932cf1e3e0611597227d90d1576acd3966446e670", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f5e49cd6db816061947788932cf1e3e0611597227d90d1576acd3966446e670", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f5e49cd6db816061947788932cf1e3e0611597227d90d1576acd3966446e670", kill_on_drop: false }` [INFO] [stdout] 1f5e49cd6db816061947788932cf1e3e0611597227d90d1576acd3966446e670 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a32966d46798959f52da7806d2e70159a7d6a54961b2c96b7c5d3b52244e4681 [INFO] running `Command { std: "docker" "start" "-a" "a32966d46798959f52da7806d2e70159a7d6a54961b2c96b7c5d3b52244e4681", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking noop-waker v0.1.0 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Checking crossbeam-channel v0.5.11 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking asmall_sink v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `request` is never read [INFO] [stdout] --> src/runtime.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct TaskState { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | pub request: RawGrpcRequest, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 29 | FlyTo(LLA), [INFO] [stdout] | ----- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `GrpcRequest` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 29 | FlyTo(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | Waypoint(Vec), [INFO] [stdout] | -------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `GrpcRequest` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 30 | Waypoint(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:19 [INFO] [stdout] | [INFO] [stdout] 94 | terrain_request_rx: ReceiverSync, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | terrain_response_tx: SenderSync, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 97 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 98 | | let mut rng = rand::thread_rng(); [INFO] [stdout] 99 | | loop { [INFO] [stdout] 100 | | //thread::sleep(Duration::from_millis(5)); [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] 120 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(global: Arc, seq: usize) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | inner: Arc::new(RefCell::new(AsyncValidatorApiInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 38 | | terrain_result: None, [INFO] [stdout] 39 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(terrain_request_tx: SenderSync) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | tasks: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `request` is never read [INFO] [stdout] --> src/runtime.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct TaskState { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | pub request: RawGrpcRequest, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:29:11 [INFO] [stdout] | [INFO] [stdout] 29 | FlyTo(LLA), [INFO] [stdout] | ----- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `GrpcRequest` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 29 | FlyTo(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | Waypoint(Vec), [INFO] [stdout] | -------- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `GrpcRequest` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 30 | Waypoint(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:97:19 [INFO] [stdout] | [INFO] [stdout] 94 | terrain_request_rx: ReceiverSync, [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | terrain_response_tx: SenderSync, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | ) -> thread::JoinHandle<()> { [INFO] [stdout] 97 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 98 | | let mut rng = rand::thread_rng(); [INFO] [stdout] 99 | | loop { [INFO] [stdout] 100 | | //thread::sleep(Duration::from_millis(5)); [INFO] [stdout] ... | [INFO] [stdout] 119 | | } [INFO] [stdout] 120 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(global: Arc, seq: usize) -> Self { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self { [INFO] [stdout] 37 | inner: Arc::new(RefCell::new(AsyncValidatorApiInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 38 | | terrain_result: None, [INFO] [stdout] 39 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(terrain_request_tx: SenderSync) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | tasks: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:60:31 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(terrain_request_tx: SenderSync) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | config: Box::leak(Box::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:60:31 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(terrain_request_tx: SenderSync) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | config: Box::leak(Box::default()), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(terrain_request_tx: SenderSync) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | global_api_state: Arc::new(GlobalApiState { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 63 | | config, [INFO] [stdout] 64 | | terrain_request_tx, [INFO] [stdout] 65 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/validator.rs:62:31 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(terrain_request_tx: SenderSync) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | global_api_state: Arc::new(GlobalApiState { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 63 | | config, [INFO] [stdout] 64 | | terrain_request_tx, [INFO] [stdout] 65 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `asmall_sink` (bin "asmall_sink") due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `asmall_sink` (bin "asmall_sink" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a32966d46798959f52da7806d2e70159a7d6a54961b2c96b7c5d3b52244e4681", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a32966d46798959f52da7806d2e70159a7d6a54961b2c96b7c5d3b52244e4681", kill_on_drop: false }` [INFO] [stdout] a32966d46798959f52da7806d2e70159a7d6a54961b2c96b7c5d3b52244e4681