[INFO] cloning repository https://github.com/Trojan295/termassist [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Trojan295/termassist" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTrojan295%2Ftermassist", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTrojan295%2Ftermassist'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bbf66a736137bbf6c8baa9c143968b0bd4e714f2 [INFO] checking Trojan295/termassist/bbf66a736137bbf6c8baa9c143968b0bd4e714f2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTrojan295%2Ftermassist" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Trojan295/termassist on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Trojan295/termassist [INFO] finished tweaking git repo https://github.com/Trojan295/termassist [INFO] tweaked toml for git repo https://github.com/Trojan295/termassist written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Trojan295/termassist already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e60eba9f61847292ce26e69b99de1475f9927e3400beb8566b4397645134daf1 [INFO] running `Command { std: "docker" "start" "-a" "e60eba9f61847292ce26e69b99de1475f9927e3400beb8566b4397645134daf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e60eba9f61847292ce26e69b99de1475f9927e3400beb8566b4397645134daf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e60eba9f61847292ce26e69b99de1475f9927e3400beb8566b4397645134daf1", kill_on_drop: false }` [INFO] [stdout] e60eba9f61847292ce26e69b99de1475f9927e3400beb8566b4397645134daf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0705ba24cbcbef67198687d98f67592c38fa6d3a308169ebe8633c72694f8ee1 [INFO] running `Command { std: "docker" "start" "-a" "0705ba24cbcbef67198687d98f67592c38fa6d3a308169ebe8633c72694f8ee1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling bitflags v1.2.0 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking unicode-segmentation v1.3.0 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking termion v1.5.3 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking tui v0.6.2 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking termassist v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | let plugins: Vec> = [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | let plugins: Vec> = [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/main.rs:15:26 [INFO] [stdout] | [INFO] [stdout] 15 | let plugins: Vec> = [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 15 | let plugins: Vec> = [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `input_handle` and `tick_handle` are never read [INFO] [stdout] --> src/ui/mod.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Events { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 13 | rx: mpsc::Receiver>, [INFO] [stdout] 14 | input_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 15 | tick_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 56 | fn register_cli<'a, 'b>(&self, app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | app.subcommand( [INFO] [stdout] 58 | / SubCommand::with_name(PLUGIN_NAME).subcommand( [INFO] [stdout] 59 | | SubCommand::with_name("add") [INFO] [stdout] 60 | | .arg(Arg::with_name("date").required(true)) [INFO] [stdout] 61 | | .arg(Arg::with_name("message").required(true)), [INFO] [stdout] 62 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/plugins/remind.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | self.add(¬e); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 105 | let _ = self.add(¬e); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 123 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let mut buf_reader = BufReader::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | YamlLoader::load_from_str(&contents).map_err(|e| e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 144 | let mut file = File::create(&self.filename).map_err(|e| e.to_string())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | file.write_all(out_str.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 163 | let mut notes = self.open_file().map(|docs| self.read_notes(docs))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | notes.push(note.to_yaml()); [INFO] [stdout] 165 | self.save_file(&self.write_notes(notes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/todo.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 106 | fn register_cli<'a, 'b>(&self, app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | app.subcommand( [INFO] [stdout] 108 | / SubCommand::with_name(PLUGIN_NAME) [INFO] [stdout] 109 | | .subcommand( [INFO] [stdout] 110 | | SubCommand::with_name("add") [INFO] [stdout] 111 | | .arg(Arg::with_name("message").required(true).multiple(true)), [INFO] [stdout] 112 | | ) [INFO] [stdout] 113 | | .subcommand(SubCommand::with_name("done")), [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `termassist` (bin "termassist") due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `input_handle` and `tick_handle` are never read [INFO] [stdout] --> src/ui/mod.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 12 | pub struct Events { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 13 | rx: mpsc::Receiver>, [INFO] [stdout] 14 | input_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 15 | tick_handle: thread::JoinHandle<()>, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 56 | fn register_cli<'a, 'b>(&self, app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | app.subcommand( [INFO] [stdout] 58 | / SubCommand::with_name(PLUGIN_NAME).subcommand( [INFO] [stdout] 59 | | SubCommand::with_name("add") [INFO] [stdout] 60 | | .arg(Arg::with_name("date").required(true)) [INFO] [stdout] 61 | | .arg(Arg::with_name("message").required(true)), [INFO] [stdout] 62 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/plugins/remind.rs:105:17 [INFO] [stdout] | [INFO] [stdout] 105 | self.add(¬e); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 105 | let _ = self.add(¬e); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:136:9 [INFO] [stdout] | [INFO] [stdout] 123 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | let mut buf_reader = BufReader::new(file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | YamlLoader::load_from_str(&contents).map_err(|e| e.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 144 | let mut file = File::create(&self.filename).map_err(|e| e.to_string())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 145 | file.write_all(out_str.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/remind.rs:165:25 [INFO] [stdout] | [INFO] [stdout] 163 | let mut notes = self.open_file().map(|docs| self.read_notes(docs))?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | notes.push(note.to_yaml()); [INFO] [stdout] 165 | self.save_file(&self.write_notes(notes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/plugins/todo.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 106 | fn register_cli<'a, 'b>(&self, app: App<'a, 'b>) -> App<'a, 'b> { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | app.subcommand( [INFO] [stdout] 108 | / SubCommand::with_name(PLUGIN_NAME) [INFO] [stdout] 109 | | .subcommand( [INFO] [stdout] 110 | | SubCommand::with_name("add") [INFO] [stdout] 111 | | .arg(Arg::with_name("message").required(true).multiple(true)), [INFO] [stdout] 112 | | ) [INFO] [stdout] 113 | | .subcommand(SubCommand::with_name("done")), [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `termassist` (bin "termassist" test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0705ba24cbcbef67198687d98f67592c38fa6d3a308169ebe8633c72694f8ee1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0705ba24cbcbef67198687d98f67592c38fa6d3a308169ebe8633c72694f8ee1", kill_on_drop: false }` [INFO] [stdout] 0705ba24cbcbef67198687d98f67592c38fa6d3a308169ebe8633c72694f8ee1