[INFO] cloning repository https://github.com/TotalDarkness-NRF/LearningRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TotalDarkness-NRF/LearningRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTotalDarkness-NRF%2FLearningRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTotalDarkness-NRF%2FLearningRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9acefab9d84e3108341bfd4a3fad25bc15209c69 [INFO] checking TotalDarkness-NRF/LearningRust/9acefab9d84e3108341bfd4a3fad25bc15209c69 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTotalDarkness-NRF%2FLearningRust" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TotalDarkness-NRF/LearningRust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TotalDarkness-NRF/LearningRust [INFO] finished tweaking git repo https://github.com/TotalDarkness-NRF/LearningRust [INFO] tweaked toml for git repo https://github.com/TotalDarkness-NRF/LearningRust written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TotalDarkness-NRF/LearningRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7999df5450fe8bee303fb15a586e824cb6868f03f7180008f705f487a00a305c [INFO] running `Command { std: "docker" "start" "-a" "7999df5450fe8bee303fb15a586e824cb6868f03f7180008f705f487a00a305c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7999df5450fe8bee303fb15a586e824cb6868f03f7180008f705f487a00a305c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7999df5450fe8bee303fb15a586e824cb6868f03f7180008f705f487a00a305c", kill_on_drop: false }` [INFO] [stdout] 7999df5450fe8bee303fb15a586e824cb6868f03f7180008f705f487a00a305c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f1924264b566a358c8356026932f96aeec6f17e14e2cb7ea2e4ab67263ad2e2 [INFO] running `Command { std: "docker" "start" "-a" "0f1924264b566a358c8356026932f96aeec6f17e14e2cb7ea2e4ab67263ad2e2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling crunchy v0.1.6 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking basics v0.1.0 (/opt/rustwide/workdir/basics) [INFO] [stderr] Checking bigint v4.4.3 [INFO] [stderr] Checking mathPrograms v0.1.0 (/opt/rustwide/workdir/mathPrograms) [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking terminalGame v0.1.0 (/opt/rustwide/workdir/terminalGame) [INFO] [stdout] warning: unused variable: `terminal` [INFO] [stdout] --> terminalGame/src/enemy.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | fn moves(&mut self, terminal: &mut Terminal, direction: Direction) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_terminal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> terminalGame/src/enemy.rs:13:50 [INFO] [stdout] | [INFO] [stdout] 13 | fn moves(&mut self, terminal: &mut Terminal, direction: Direction) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `terminal` [INFO] [stdout] --> terminalGame/src/enemy.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | fn update(&mut self, terminal: &mut Terminal) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_terminal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> terminalGame/src/enemy.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | fn attack(&mut self, direction: Direction) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `getPosition` is never used [INFO] [stdout] --> terminalGame/src/character.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Character { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 9 | fn getPosition(&self) -> &Position; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `health` is never read [INFO] [stdout] --> terminalGame/src/enemy.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Enemy { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 6 | health: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Alien`, `Elf`, `Human`, and `Machine` are never constructed [INFO] [stdout] --> terminalGame/src/enemy.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | enum EnemyType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 53 | Alien, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 54 | Elf, [INFO] [stdout] | ^^^ [INFO] [stdout] 55 | Human, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 56 | Machine, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> terminalGame/src/game.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 16 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | player: Player::create(Position::newOrigin(), Box::new(color::LightRed)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> terminalGame/src/game.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 16 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | terminal: Terminal::getRaw(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `terminalGame` (bin "terminalGame" test) due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `terminal` [INFO] [stdout] --> terminalGame/src/enemy.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | fn moves(&mut self, terminal: &mut Terminal, direction: Direction) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_terminal` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> terminalGame/src/enemy.rs:13:50 [INFO] [stdout] | [INFO] [stdout] 13 | fn moves(&mut self, terminal: &mut Terminal, direction: Direction) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `terminal` [INFO] [stdout] --> terminalGame/src/enemy.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | fn update(&mut self, terminal: &mut Terminal) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_terminal` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `direction` [INFO] [stdout] --> terminalGame/src/enemy.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 37 | fn attack(&mut self, direction: Direction) { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_direction` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `getPosition` is never used [INFO] [stdout] --> terminalGame/src/character.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub trait Character { [INFO] [stdout] | --------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 9 | fn getPosition(&self) -> &Position; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `health` is never read [INFO] [stdout] --> terminalGame/src/enemy.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Enemy { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 6 | health: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Alien`, `Elf`, `Human`, and `Machine` are never constructed [INFO] [stdout] --> terminalGame/src/enemy.rs:53:5 [INFO] [stdout] | [INFO] [stdout] 52 | enum EnemyType { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 53 | Alien, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 54 | Elf, [INFO] [stdout] | ^^^ [INFO] [stdout] 55 | Human, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 56 | Machine, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> terminalGame/src/game.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 16 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | player: Player::create(Position::newOrigin(), Box::new(color::LightRed)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> terminalGame/src/game.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 16 | let (tx, rx) = channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | terminal: Terminal::getRaw(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `terminalGame` (bin "terminalGame") due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f1924264b566a358c8356026932f96aeec6f17e14e2cb7ea2e4ab67263ad2e2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f1924264b566a358c8356026932f96aeec6f17e14e2cb7ea2e4ab67263ad2e2", kill_on_drop: false }` [INFO] [stdout] 0f1924264b566a358c8356026932f96aeec6f17e14e2cb7ea2e4ab67263ad2e2