[INFO] cloning repository https://github.com/Tom-Le/hello-tcp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Tom-Le/hello-tcp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTom-Le%2Fhello-tcp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTom-Le%2Fhello-tcp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 45532fc7e76fcdb50cebc03e17174401d11edff0 [INFO] checking Tom-Le/hello-tcp/45532fc7e76fcdb50cebc03e17174401d11edff0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTom-Le%2Fhello-tcp" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Tom-Le/hello-tcp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/Tom-Le/hello-tcp [INFO] finished tweaking git repo https://github.com/Tom-Le/hello-tcp [INFO] tweaked toml for git repo https://github.com/Tom-Le/hello-tcp written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Tom-Le/hello-tcp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a94d6c51a8d6a8507faabe76f0fafbbf64dcfb323948d09bfe9e19fc71e22183 [INFO] running `Command { std: "docker" "start" "-a" "a94d6c51a8d6a8507faabe76f0fafbbf64dcfb323948d09bfe9e19fc71e22183", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a94d6c51a8d6a8507faabe76f0fafbbf64dcfb323948d09bfe9e19fc71e22183", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a94d6c51a8d6a8507faabe76f0fafbbf64dcfb323948d09bfe9e19fc71e22183", kill_on_drop: false }` [INFO] [stdout] a94d6c51a8d6a8507faabe76f0fafbbf64dcfb323948d09bfe9e19fc71e22183 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1a5d6cfaa63dacae69eec89f3f7389fc96befd0a968bef9b4c32bc41e6aa555a [INFO] running `Command { std: "docker" "start" "-a" "1a5d6cfaa63dacae69eec89f3f7389fc96befd0a968bef9b4c32bc41e6aa555a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking hello-tcp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(id: usize, receiver: Arc>>) -> io::Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let builder = thread::Builder::new(); [INFO] [stdout] 20 | Ok(Worker { [INFO] [stdout] | ________^ [INFO] [stdout] 21 | | id, [INFO] [stdout] 22 | | handle: Some(builder.spawn(move || loop { [INFO] [stdout] 23 | | let message = receiver.lock().expect("mutex poisoned").recv(); [INFO] [stdout] ... | [INFO] [stdout] 34 | | })?), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 55 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(ThreadPool { [INFO] [stdout] | ________^ [INFO] [stdout] 62 | | sender: Some(sender), [INFO] [stdout] 63 | | workers, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 18 | fn new(id: usize, receiver: Arc>>) -> io::Result { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let builder = thread::Builder::new(); [INFO] [stdout] 20 | Ok(Worker { [INFO] [stdout] | ________^ [INFO] [stdout] 21 | | id, [INFO] [stdout] 22 | | handle: Some(builder.spawn(move || loop { [INFO] [stdout] 23 | | let message = receiver.lock().expect("mutex poisoned").recv(); [INFO] [stdout] ... | [INFO] [stdout] 34 | | })?), [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/threading.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 55 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | Ok(ThreadPool { [INFO] [stdout] | ________^ [INFO] [stdout] 62 | | sender: Some(sender), [INFO] [stdout] 63 | | workers, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hello-tcp` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `hello-tcp` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "1a5d6cfaa63dacae69eec89f3f7389fc96befd0a968bef9b4c32bc41e6aa555a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a5d6cfaa63dacae69eec89f3f7389fc96befd0a968bef9b4c32bc41e6aa555a", kill_on_drop: false }` [INFO] [stdout] 1a5d6cfaa63dacae69eec89f3f7389fc96befd0a968bef9b4c32bc41e6aa555a