[INFO] cloning repository https://github.com/TinBryn/lox.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TinBryn/lox.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTinBryn%2Flox.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTinBryn%2Flox.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] abae7bbf3e26369e7d62f055caac04af672d8e85 [INFO] checking TinBryn/lox.rs/abae7bbf3e26369e7d62f055caac04af672d8e85 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTinBryn%2Flox.rs" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TinBryn/lox.rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TinBryn/lox.rs [INFO] finished tweaking git repo https://github.com/TinBryn/lox.rs [INFO] tweaked toml for git repo https://github.com/TinBryn/lox.rs written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TinBryn/lox.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a425b5ddc970e69776e253a3e05e3c6fc2fa4ea3f5a39a337c21c1139fcf6771 [INFO] running `Command { std: "docker" "start" "-a" "a425b5ddc970e69776e253a3e05e3c6fc2fa4ea3f5a39a337c21c1139fcf6771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a425b5ddc970e69776e253a3e05e3c6fc2fa4ea3f5a39a337c21c1139fcf6771", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a425b5ddc970e69776e253a3e05e3c6fc2fa4ea3f5a39a337c21c1139fcf6771", kill_on_drop: false }` [INFO] [stdout] a425b5ddc970e69776e253a3e05e3c6fc2fa4ea3f5a39a337c21c1139fcf6771 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 192f1aaca72c8cb8b7ab9dd178bd27d03e116ac5df423012c7619773269665de [INFO] running `Command { std: "docker" "start" "-a" "192f1aaca72c8cb8b7ab9dd178bd27d03e116ac5df423012c7619773269665de", kill_on_drop: false }` [INFO] [stderr] Checking lox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `row` and `col` are never read [INFO] [stdout] --> src/token.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | pub struct TokenMeta { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 144 | pub row: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] 145 | pub col: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenMeta` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `meta` is never read [INFO] [stdout] --> src/token.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 149 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 150 | pub kind: TokenKind, [INFO] [stdout] 151 | pub meta: TokenMeta, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/old_parser.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 176 | let expr = self.unary(peek)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Ok(Expr::from_unary(op, expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn from_binary(left: Self, operator: BinOp, right: Self) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Expr::Binary(Box::new(Binary { [INFO] [stdout] | ______________________^ [INFO] [stdout] 106 | | left, [INFO] [stdout] 107 | | operator, [INFO] [stdout] 108 | | right, [INFO] [stdout] 109 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn from_grouping(expression: Self) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Self::Grouping(Box::new(Grouping { expression })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn from_unary(operator: UnOp, expression: Self) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self::Unary(Box::new(Unary { [INFO] [stdout] | _____________________^ [INFO] [stdout] 116 | | operator, [INFO] [stdout] 117 | | expression, [INFO] [stdout] 118 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `row` and `col` are never read [INFO] [stdout] --> src/token.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 143 | pub struct TokenMeta { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 144 | pub row: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] 145 | pub col: usize, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TokenMeta` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `meta` is never read [INFO] [stdout] --> src/token.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 149 | pub struct Token { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 150 | pub kind: TokenKind, [INFO] [stdout] 151 | pub meta: TokenMeta, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Token` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/old_parser.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 176 | let expr = self.unary(peek)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Ok(Expr::from_unary(op, expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax.rs:105:22 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn from_binary(left: Self, operator: BinOp, right: Self) -> Self { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | Expr::Binary(Box::new(Binary { [INFO] [stdout] | ______________________^ [INFO] [stdout] 106 | | left, [INFO] [stdout] 107 | | operator, [INFO] [stdout] 108 | | right, [INFO] [stdout] 109 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn from_grouping(expression: Self) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | Self::Grouping(Box::new(Grouping { expression })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax.rs:115:21 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn from_unary(operator: UnOp, expression: Self) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | Self::Unary(Box::new(Unary { [INFO] [stdout] | _____________________^ [INFO] [stdout] 116 | | operator, [INFO] [stdout] 117 | | expression, [INFO] [stdout] 118 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `lox` (bin "lox") due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `lox` (bin "lox" test) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "192f1aaca72c8cb8b7ab9dd178bd27d03e116ac5df423012c7619773269665de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "192f1aaca72c8cb8b7ab9dd178bd27d03e116ac5df423012c7619773269665de", kill_on_drop: false }` [INFO] [stdout] 192f1aaca72c8cb8b7ab9dd178bd27d03e116ac5df423012c7619773269665de