[INFO] cloning repository https://github.com/TimLuq/run-suid [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TimLuq/run-suid" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTimLuq%2Frun-suid", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTimLuq%2Frun-suid'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 170b1e0b0800284694aea81fa1b0f9a4d94a42ab [INFO] checking TimLuq/run-suid/170b1e0b0800284694aea81fa1b0f9a4d94a42ab against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTimLuq%2Frun-suid" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TimLuq/run-suid on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TimLuq/run-suid [INFO] finished tweaking git repo https://github.com/TimLuq/run-suid [INFO] tweaked toml for git repo https://github.com/TimLuq/run-suid written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TimLuq/run-suid already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.labels [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ea9cd5b6a61f76ae09cde3713361efcb32bce839d5d6ca5217c70b98139aa330 [INFO] running `Command { std: "docker" "start" "-a" "ea9cd5b6a61f76ae09cde3713361efcb32bce839d5d6ca5217c70b98139aa330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ea9cd5b6a61f76ae09cde3713361efcb32bce839d5d6ca5217c70b98139aa330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ea9cd5b6a61f76ae09cde3713361efcb32bce839d5d6ca5217c70b98139aa330", kill_on_drop: false }` [INFO] [stdout] ea9cd5b6a61f76ae09cde3713361efcb32bce839d5d6ca5217c70b98139aa330 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cfb8a064d2be3ca880befa060b1ca5c35205f96d0be2e6120942290aa79899f4 [INFO] running `Command { std: "docker" "start" "-a" "cfb8a064d2be3ca880befa060b1ca5c35205f96d0be2e6120942290aa79899f4", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: package.labels [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking run-suid v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/nix.rs:146:46 [INFO] [stdout] | [INFO] [stdout] 146 | let v = unsafe { std::ptr::read_volatile(&VERBOSE) }; [INFO] [stdout] | ^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 146 | let v = unsafe { std::ptr::read_volatile(addr_of!(VERBOSE)) }; [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/nix.rs:164:39 [INFO] [stdout] | [INFO] [stdout] 164 | unsafe { std::ptr::write_volatile(&mut VERBOSE, v) }; [INFO] [stdout] | ^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 164 | unsafe { std::ptr::write_volatile(addr_of_mut!(VERBOSE), v) }; [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/nix.rs:146:46 [INFO] [stdout] | [INFO] [stdout] 146 | let v = unsafe { std::ptr::read_volatile(&VERBOSE) }; [INFO] [stdout] | ^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this shared reference has lifetime `'static`, but if the static ever gets mutated, or a mutable reference is created, then any further use of this shared reference is Undefined Behavior [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] help: use `addr_of!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 146 | let v = unsafe { std::ptr::read_volatile(addr_of!(VERBOSE)) }; [INFO] [stdout] | ~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a mutable reference to mutable static is discouraged [INFO] [stdout] --> src/nix.rs:164:39 [INFO] [stdout] | [INFO] [stdout] 164 | unsafe { std::ptr::write_volatile(&mut VERBOSE, v) }; [INFO] [stdout] | ^^^^^^^^^^^^ mutable reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see issue #114447 [INFO] [stdout] = note: this will be a hard error in the 2024 edition [INFO] [stdout] = note: this mutable reference has lifetime `'static`, but if the static gets accessed (read or written) by any other means, or any other reference is created, then any further use of this mutable reference is Undefined Behavior [INFO] [stdout] help: use `addr_of_mut!` instead to create a raw pointer [INFO] [stdout] | [INFO] [stdout] 164 | unsafe { std::ptr::write_volatile(addr_of_mut!(VERBOSE), v) }; [INFO] [stdout] | ~~~~~~~~~~~~~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `getuid` is never used [INFO] [stdout] --> src/env.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) trait EnvTrait { [INFO] [stdout] | -------- associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 11 | unsafe fn getuid() -> u32; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nix.rs:211:19 [INFO] [stdout] | [INFO] [stdout] 162 | fn wait_for(mut child: Command, opts: super::Opts) -> ExitCode { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let mut child = match child.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Ok(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | eprintln!("Unable to execute command: {}", e); [INFO] [stdout] 188 | let mut exit = EXIT.lock(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | match child.wait() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run-suid` (bin "run-suid" test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: associated function `getuid` is never used [INFO] [stdout] --> src/env.rs:11:15 [INFO] [stdout] | [INFO] [stdout] 7 | pub(crate) trait EnvTrait { [INFO] [stdout] | -------- associated function in this trait [INFO] [stdout] ... [INFO] [stdout] 11 | unsafe fn getuid() -> u32; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nix.rs:211:19 [INFO] [stdout] | [INFO] [stdout] 162 | fn wait_for(mut child: Command, opts: super::Opts) -> ExitCode { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | let mut child = match child.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Ok(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | eprintln!("Unable to execute command: {}", e); [INFO] [stdout] 188 | let mut exit = EXIT.lock(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | match child.wait() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `run-suid` (bin "run-suid") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "cfb8a064d2be3ca880befa060b1ca5c35205f96d0be2e6120942290aa79899f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cfb8a064d2be3ca880befa060b1ca5c35205f96d0be2e6120942290aa79899f4", kill_on_drop: false }` [INFO] [stdout] cfb8a064d2be3ca880befa060b1ca5c35205f96d0be2e6120942290aa79899f4