[INFO] cloning repository https://github.com/TimB44/machine-maker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TimB44/machine-maker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTimB44%2Fmachine-maker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTimB44%2Fmachine-maker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4ff3176930bb787e08becbb670f9fbccdc8d4e07 [INFO] checking TimB44/machine-maker/4ff3176930bb787e08becbb670f9fbccdc8d4e07 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTimB44%2Fmachine-maker" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TimB44/machine-maker on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TimB44/machine-maker [INFO] finished tweaking git repo https://github.com/TimB44/machine-maker [INFO] tweaked toml for git repo https://github.com/TimB44/machine-maker written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TimB44/machine-maker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7faff1cbe240d7551d2b9f0fe8fa5436459b8f01e246886f94b5be6530f5372c [INFO] running `Command { std: "docker" "start" "-a" "7faff1cbe240d7551d2b9f0fe8fa5436459b8f01e246886f94b5be6530f5372c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7faff1cbe240d7551d2b9f0fe8fa5436459b8f01e246886f94b5be6530f5372c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7faff1cbe240d7551d2b9f0fe8fa5436459b8f01e246886f94b5be6530f5372c", kill_on_drop: false }` [INFO] [stdout] 7faff1cbe240d7551d2b9f0fe8fa5436459b8f01e246886f94b5be6530f5372c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c311be6a868d982d2c5e023a56e222b996169df93cc42fa327d912b269705c11 [INFO] running `Command { std: "docker" "start" "-a" "c311be6a868d982d2c5e023a56e222b996169df93cc42fa327d912b269705c11", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Checking engine-room v0.1.0 (/opt/rustwide/workdir/engine-room) [INFO] [stdout] warning: function `add_tape_mov` is never used [INFO] [stdout] --> engine-room/src/machine_utils.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) fn add_tape_mov( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/dfa.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 16 | accept_states: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Dfa { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | transition_table, [INFO] [stdout] 33 | | accept_states, [INFO] [stdout] 34 | | max_state, [INFO] [stdout] 35 | | max_char, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/nfa.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 16 | transition_table: Vec>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | accept_states: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Nfa { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | transition_table, [INFO] [stdout] 35 | | accept_states, [INFO] [stdout] 36 | | max_state, [INFO] [stdout] 37 | | max_char, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/nfa_e.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 22 | transition_table: Vec>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | accept_states: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let nfa = Self::convert_to_nfa( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(EpsilonNfa { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | nfa, [INFO] [stdout] 50 | | transition_table, [INFO] [stdout] 51 | | accept_states, [INFO] [stdout] 52 | | epslion_closure_paths, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/nfa_e.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 128 | let mut nfa_transition_table = [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let nfa_accept_states = epsilon_closure_paths [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Nfa::build(nfa_transition_table, nfa_accept_states, max_state, max_char) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine-room` (lib) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `add_tape_mov` is never used [INFO] [stdout] --> engine-room/src/machine_utils.rs:17:15 [INFO] [stdout] | [INFO] [stdout] 17 | pub(crate) fn add_tape_mov( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/dfa.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 16 | accept_states: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Dfa { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | transition_table, [INFO] [stdout] 33 | | accept_states, [INFO] [stdout] 34 | | max_state, [INFO] [stdout] 35 | | max_char, [INFO] [stdout] 36 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/nfa.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 16 | transition_table: Vec>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | accept_states: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | Ok(Nfa { [INFO] [stdout] | ____________^ [INFO] [stdout] 34 | | transition_table, [INFO] [stdout] 35 | | accept_states, [INFO] [stdout] 36 | | max_state, [INFO] [stdout] 37 | | max_char, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/nfa_e.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 22 | transition_table: Vec>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | accept_states: HashSet, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 41 | let nfa = Self::convert_to_nfa( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(EpsilonNfa { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | nfa, [INFO] [stdout] 50 | | transition_table, [INFO] [stdout] 51 | | accept_states, [INFO] [stdout] 52 | | epslion_closure_paths, [INFO] [stdout] 53 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> engine-room/src/nfa_e.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 128 | let mut nfa_transition_table = [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | let nfa_accept_states = epsilon_closure_paths [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | Nfa::build(nfa_transition_table, nfa_accept_states, max_state, max_char) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `engine-room` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c311be6a868d982d2c5e023a56e222b996169df93cc42fa327d912b269705c11", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c311be6a868d982d2c5e023a56e222b996169df93cc42fa327d912b269705c11", kill_on_drop: false }` [INFO] [stdout] c311be6a868d982d2c5e023a56e222b996169df93cc42fa327d912b269705c11