[INFO] cloning repository https://github.com/Thordreck/chust8 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Thordreck/chust8" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThordreck%2Fchust8", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThordreck%2Fchust8'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2bf50627b9e8366ef7c82329c4fa6960e904dd70 [INFO] checking Thordreck/chust8/2bf50627b9e8366ef7c82329c4fa6960e904dd70 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThordreck%2Fchust8" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Thordreck/chust8 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Thordreck/chust8 [INFO] finished tweaking git repo https://github.com/Thordreck/chust8 [INFO] tweaked toml for git repo https://github.com/Thordreck/chust8 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Thordreck/chust8 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef423e7192deb8635c74f23736f4f24021b5e20fa7d3fcd6d05326039bd238e8 [INFO] running `Command { std: "docker" "start" "-a" "ef423e7192deb8635c74f23736f4f24021b5e20fa7d3fcd6d05326039bd238e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef423e7192deb8635c74f23736f4f24021b5e20fa7d3fcd6d05326039bd238e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef423e7192deb8635c74f23736f4f24021b5e20fa7d3fcd6d05326039bd238e8", kill_on_drop: false }` [INFO] [stdout] ef423e7192deb8635c74f23736f4f24021b5e20fa7d3fcd6d05326039bd238e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bfe5a4367c62650143ec5eb8d1bcba1098097a43724c968df97f8736db7e4600 [INFO] running `Command { std: "docker" "start" "-a" "bfe5a4367c62650143ec5eb8d1bcba1098097a43724c968df97f8736db7e4600", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling proc-macro2 v1.0.14 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.23 [INFO] [stderr] Compiling sdl2 v0.34.0 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Checking strum v0.18.0 [INFO] [stderr] Checking arrayvec v0.5.1 [INFO] [stderr] Compiling sdl2-sys v0.34.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Checking chust8 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `KeyboardState` [INFO] [stdout] --> src/input.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::keyboard::{ Scancode, KeyboardState }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels::Color` [INFO] [stdout] --> src/display.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use sdl2::pixels::Color; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WindowContext` [INFO] [stdout] --> src/display.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | use sdl2::video::{ Window, WindowContext }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TextureCreator` [INFO] [stdout] --> src/display.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use sdl2::render::{ TextureCreator, Canvas }; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PixelGrid` [INFO] [stdout] --> src/display.rs:16:25 [INFO] [stdout] | [INFO] [stdout] 16 | use grid::{ GridEditor, PixelGrid }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `KeyboardState` [INFO] [stdout] --> src/input.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use sdl2::keyboard::{ Scancode, KeyboardState }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `sdl2::pixels::Color` [INFO] [stdout] --> src/display.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use sdl2::pixels::Color; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `WindowContext` [INFO] [stdout] --> src/display.rs:4:28 [INFO] [stdout] | [INFO] [stdout] 4 | use sdl2::video::{ Window, WindowContext }; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TextureCreator` [INFO] [stdout] --> src/display.rs:5:21 [INFO] [stdout] | [INFO] [stdout] 5 | use sdl2::render::{ TextureCreator, Canvas }; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PixelGrid` [INFO] [stdout] --> src/display.rs:16:25 [INFO] [stdout] | [INFO] [stdout] 16 | use grid::{ GridEditor, PixelGrid }; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/interpreter.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut interpreter = Interpreter [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/interpreter.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let opcode = OpCode::new(msb, lsb)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/interpreter.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Interpreter [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pc : ProgramCounter, [INFO] [stdout] | ^^ [INFO] [stdout] 22 | context : Sdl, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 23 | display : Display, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 24 | keypad : Keypad, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 25 | speakers : Speakers, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 26 | i_register : IRegister, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 27 | data_registers : AllDataRegisters, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 28 | stack : Stack, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 29 | cpu_limiter : RateLimiter, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 30 | timer_limiter : RateLimiter, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 31 | delay_timer : Timer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 32 | sound_timer : Timer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cpu_step`, `tick_timers`, and `extract_opcode_bytes` are never used [INFO] [stdout] --> src/interpreter.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 94 | impl Interpreter [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | fn cpu_step(&mut self) -> Result<(), String> [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 115 | fn tick_timers(&mut self) -> Result<(), String> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | fn extract_opcode_bytes(&mut self) -> Result<(u8, u8), String> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/timer.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct GeneralTimer [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | status : TimerStatus, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture_creator` is never read [INFO] [stdout] --> src/display/tileset.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Tileset [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 24 | { [INFO] [stdout] 25 | texture_creator : TextureCreator, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 79 | let audio_subsystem = context.audio()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let device = audio_subsystem.open_playback(None, &desired_spec, get_callback)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok( Speakers { device } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 25 | let events = context.event_pump()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok( Keypad { events, keymap } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn from_window(window: Window) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | { [INFO] [stdout] 36 | let canvas = match window.into_canvas().present_vsync().build() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | { [INFO] [stdout] 38 | Ok(canvas) => canvas, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let tileset = Tileset::new(&canvas)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(Display { canvas, grid_editor, tileset, }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 90 | let video_subsystem = context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | [INFO] [stdout] 92 | match video_subsystem.window(DISPLAY_TITLE, DISPLAY_WIDTH, DISPLAY_HEIGHT) [INFO] [stdout] | _______________^ [INFO] [stdout] 93 | | .position_centered().build() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/tileset.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 36 | let texture_creator = canvas.texture_creator(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Tileset { texture_creator, texture, on_tile, off_tile }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chust8` (lib) due to 6 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `mutex` [INFO] [stdout] --> src/audio.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | let mutex = test_lock()?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_mutex` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mutex` [INFO] [stdout] --> src/input.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | let mutex = test_lock()?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_mutex` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/interpreter.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut interpreter = Interpreter [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opcode` [INFO] [stdout] --> src/interpreter.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | let opcode = OpCode::new(msb, lsb)?; [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_opcode` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mutex` [INFO] [stdout] --> src/interpreter.rs:146:13 [INFO] [stdout] | [INFO] [stdout] 146 | let mutex = test_lock()?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_mutex` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mutex` [INFO] [stdout] --> src/interpreter.rs:160:13 [INFO] [stdout] | [INFO] [stdout] 160 | let mutex = test_lock()?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_mutex` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `lock` [INFO] [stdout] --> src/display/tileset.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | let lock = test_lock()?; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_lock` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mutex` [INFO] [stdout] --> src/display.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 129 | let mutex = test_lock()?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_mutex` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `display` [INFO] [stdout] --> src/display.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let display = Display::from_window(window)?; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_display` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `mutex` [INFO] [stdout] --> src/display.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | let mutex = test_lock()?; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_mutex` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/display.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let mut grid = display.mut_editor().mut_grid(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/interpreter.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Interpreter [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pc : ProgramCounter, [INFO] [stdout] | ^^ [INFO] [stdout] 22 | context : Sdl, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 23 | display : Display, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 24 | keypad : Keypad, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 25 | speakers : Speakers, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 26 | i_register : IRegister, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 27 | data_registers : AllDataRegisters, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 28 | stack : Stack, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 29 | cpu_limiter : RateLimiter, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 30 | timer_limiter : RateLimiter, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 31 | delay_timer : Timer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 32 | sound_timer : Timer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `cpu_step`, `tick_timers`, and `extract_opcode_bytes` are never used [INFO] [stdout] --> src/interpreter.rs:101:8 [INFO] [stdout] | [INFO] [stdout] 94 | impl Interpreter [INFO] [stdout] | ---------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | fn cpu_step(&mut self) -> Result<(), String> [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 115 | fn tick_timers(&mut self) -> Result<(), String> [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 123 | fn extract_opcode_bytes(&mut self) -> Result<(u8, u8), String> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `status` is never read [INFO] [stdout] --> src/timer.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct GeneralTimer [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | status : TimerStatus, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `texture_creator` is never read [INFO] [stdout] --> src/display/tileset.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct Tileset [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 24 | { [INFO] [stdout] 25 | texture_creator : TextureCreator, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/audio.rs:95:13 [INFO] [stdout] | [INFO] [stdout] 79 | let audio_subsystem = context.audio()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let device = audio_subsystem.open_playback(None, &desired_spec, get_callback)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok( Speakers { device } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 25 | let events = context.event_pump()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok( Keypad { events, keymap } ) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 34 | pub fn from_window(window: Window) -> Result [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | { [INFO] [stdout] 36 | let canvas = match window.into_canvas().present_vsync().build() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | { [INFO] [stdout] 38 | Ok(canvas) => canvas, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let tileset = Tileset::new(&canvas)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | Ok(Display { canvas, grid_editor, tileset, }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 90 | let video_subsystem = context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | [INFO] [stdout] 92 | match video_subsystem.window(DISPLAY_TITLE, DISPLAY_WIDTH, DISPLAY_HEIGHT) [INFO] [stdout] | _______________^ [INFO] [stdout] 93 | | .position_centered().build() [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/display/tileset.rs:42:12 [INFO] [stdout] | [INFO] [stdout] 36 | let texture_creator = canvas.texture_creator(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Tileset { texture_creator, texture, on_tile, off_tile }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chust8` (lib test) due to 6 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bfe5a4367c62650143ec5eb8d1bcba1098097a43724c968df97f8736db7e4600", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bfe5a4367c62650143ec5eb8d1bcba1098097a43724c968df97f8736db7e4600", kill_on_drop: false }` [INFO] [stdout] bfe5a4367c62650143ec5eb8d1bcba1098097a43724c968df97f8736db7e4600