[INFO] cloning repository https://github.com/ThomWright/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ThomWright/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThomWright%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThomWright%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4f81473ffde0a0824b77e9ceec5f439b898d4972 [INFO] checking ThomWright/kvs/4f81473ffde0a0824b77e9ceec5f439b898d4972 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThomWright%2Fkvs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ThomWright/kvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ThomWright/kvs [INFO] finished tweaking git repo https://github.com/ThomWright/kvs [INFO] tweaked toml for git repo https://github.com/ThomWright/kvs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ThomWright/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bab901db4970c991510f2351f921aff6d81e55f8cfb3702881d9e63f873b41ff [INFO] running `Command { std: "docker" "start" "-a" "bab901db4970c991510f2351f921aff6d81e55f8cfb3702881d9e63f873b41ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bab901db4970c991510f2351f921aff6d81e55f8cfb3702881d9e63f873b41ff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bab901db4970c991510f2351f921aff6d81e55f8cfb3702881d9e63f873b41ff", kill_on_drop: false }` [INFO] [stdout] bab901db4970c991510f2351f921aff6d81e55f8cfb3702881d9e63f873b41ff [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0c077f140dc3f1913ac6e0bf792807bfab83136a1de3f40ced7f371705f147bb [INFO] running `Command { std: "docker" "start" "-a" "0c077f140dc3f1913ac6e0bf792807bfab83136a1de3f40ced7f371705f147bb", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling syn v0.15.42 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling getrandom v0.1.9 [INFO] [stderr] Compiling cc v1.0.40 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v0.6.13 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Compiling slog v2.5.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling bincode v1.2.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking lock_api v0.3.1 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking crossbeam-channel v0.3.9 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking ucd-util v0.1.5 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking regex-syntax v0.6.10 [INFO] [stderr] Checking utf8-ranges v1.0.3 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Compiling escargot v0.4.0 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking aho-corasick v0.7.4 [INFO] [stderr] Checking crossbeam-channel v0.4.0 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking float-cmp v0.4.0 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking normalize-line-endings v0.2.2 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking rand_os v0.2.2 [INFO] [stderr] Checking rand_xoshiro v0.3.1 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking panic-control v0.1.4 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Checking chrono v0.4.9 [INFO] [stderr] Checking backtrace v0.3.34 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking slog-term v2.4.1 [INFO] [stderr] Checking criterion-plot v0.4.0 [INFO] [stderr] Checking tempfile v3.0.8 [INFO] [stderr] Checking regex v1.2.0 [INFO] [stderr] Checking predicates v1.0.1 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.97 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking serde_bytes v0.11.2 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking sled v0.29.2 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.2 [INFO] [stderr] Checking criterion v0.3.0 [INFO] [stderr] Checking assert_cmd v0.11.1 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let db = Db::open(sled_dir)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | Ok(SledKvsEngine { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | db: Arc::new(Mutex::new(db)), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 40 | let store = self.db.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | match store.get(key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 57 | let store = self.db.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | match store.remove(key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/file.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 56 | let writer = BufWriter::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(KvsWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | id: file_id, [INFO] [stdout] 65 | | offset: 0, [INFO] [stdout] 66 | | writer, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/store.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let store = InternalKvStore::open(path)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Ok(KvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | store: Arc::new(Mutex::new(store)), [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/store.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 90 | fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut readers = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let writer = KvsWriter::new(&kvs_dir, write_file_id)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok(InternalKvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | path: kvs_dir, [INFO] [stdout] 120 | | writer, [INFO] [stdout] 121 | | readers, [INFO] [stdout] ... | [INFO] [stdout] 124 | | uncompacted, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn connect(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(KvsClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | connection: TcpStream::connect(addr)?, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn get(self, key: String) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | match responses.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:43:15 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn set(self, key: String, value: String) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | match responses.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn remove(self, key: String) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | match responses.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/data.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/data.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 35 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/data.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, failure::Fail)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/server.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(log: Logger, engine: E, pool: P) -> Result> { [INFO] [stdout] | ----------- --------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(KvsServer { log, engine, pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/server.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 43 | Ok(stream) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let eng = self.engine.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let log = self.log.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.pool.spawn(move || { [INFO] [stdout] 47 | KvsServer::::handle_req(&stream, &eng).unwrap_or_else(|_e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/shared_queue.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 23 | let (s, r) = unbounded::(); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let pool = Arc::new(PoolData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(SharedQueueThreadPool { data: pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | let db = Db::open(sled_dir)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | [INFO] [stdout] 32 | Ok(SledKvsEngine { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | db: Arc::new(Mutex::new(db)), [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 40 | let store = self.db.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | [INFO] [stdout] 42 | match store.get(key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/sled.rs:59:15 [INFO] [stdout] | [INFO] [stdout] 57 | let store = self.db.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | [INFO] [stdout] 59 | match store.remove(key)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/file.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 56 | let writer = BufWriter::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(KvsWriter { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | id: file_id, [INFO] [stdout] 65 | | offset: 0, [INFO] [stdout] 66 | | writer, [INFO] [stdout] 67 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/store.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | let store = InternalKvStore::open(path)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | Ok(KvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | store: Arc::new(Mutex::new(store)), [INFO] [stdout] 59 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/engines/kvs/store.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 90 | fn open(path: impl Into) -> Result { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | let mut readers = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let writer = KvsWriter::new(&kvs_dir, write_file_id)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Ok(InternalKvStore { [INFO] [stdout] | ____________^ [INFO] [stdout] 119 | | path: kvs_dir, [INFO] [stdout] 120 | | writer, [INFO] [stdout] 121 | | readers, [INFO] [stdout] ... | [INFO] [stdout] 124 | | uncompacted, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn connect(addr: A) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Ok(KvsClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | connection: TcpStream::connect(addr)?, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:25:15 [INFO] [stdout] | [INFO] [stdout] 20 | pub fn get(self, key: String) -> Result> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | match responses.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:43:15 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn set(self, key: String, value: String) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | match responses.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/client.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn remove(self, key: String) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | match responses.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/data.rs:7:35 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/data.rs:35:35 [INFO] [stdout] | [INFO] [stdout] 35 | #[derive(Debug, Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/data.rs:42:41 [INFO] [stdout] | [INFO] [stdout] 42 | #[derive(Debug, Clone, Copy, Serialize, Deserialize, failure::Fail)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/server.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(log: Logger, engine: E, pool: P) -> Result> { [INFO] [stdout] | ----------- --------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(KvsServer { log, engine, pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/network/server.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 43 | Ok(stream) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let eng = self.engine.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let log = self.log.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | self.pool.spawn(move || { [INFO] [stdout] 47 | KvsServer::::handle_req(&stream, &eng).unwrap_or_else(|_e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/shared_queue.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 23 | let (s, r) = unbounded::(); [INFO] [stdout] | - - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | [INFO] [stdout] 25 | let pool = Arc::new(PoolData { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | Ok(SharedQueueThreadPool { data: pool }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib test) due to 17 previous errors [INFO] running `Command { std: "docker" "inspect" "0c077f140dc3f1913ac6e0bf792807bfab83136a1de3f40ced7f371705f147bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c077f140dc3f1913ac6e0bf792807bfab83136a1de3f40ced7f371705f147bb", kill_on_drop: false }` [INFO] [stdout] 0c077f140dc3f1913ac6e0bf792807bfab83136a1de3f40ced7f371705f147bb