[INFO] cloning repository https://github.com/Thodin/custom-errors [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Thodin/custom-errors" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThodin%2Fcustom-errors", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThodin%2Fcustom-errors'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f6ff7c6548c896cfc9d26240b6be70fcf0e97e61 [INFO] checking Thodin/custom-errors/f6ff7c6548c896cfc9d26240b6be70fcf0e97e61 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThodin%2Fcustom-errors" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Thodin/custom-errors on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Thodin/custom-errors [INFO] finished tweaking git repo https://github.com/Thodin/custom-errors [INFO] tweaked toml for git repo https://github.com/Thodin/custom-errors written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Thodin/custom-errors already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7583a359ba5b4565647fa3d13e49b541dba8cdce4e3885c67354bbd5553543b0 [INFO] running `Command { std: "docker" "start" "-a" "7583a359ba5b4565647fa3d13e49b541dba8cdce4e3885c67354bbd5553543b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7583a359ba5b4565647fa3d13e49b541dba8cdce4e3885c67354bbd5553543b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7583a359ba5b4565647fa3d13e49b541dba8cdce4e3885c67354bbd5553543b0", kill_on_drop: false }` [INFO] [stdout] 7583a359ba5b4565647fa3d13e49b541dba8cdce4e3885c67354bbd5553543b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ace13b7027850a6ead8cec426e2f535db8ae858d0a76a82cf92f833d8ff4fb7b [INFO] running `Command { std: "docker" "start" "-a" "ace13b7027850a6ead8cec426e2f535db8ae858d0a76a82cf92f833d8ff4fb7b", kill_on_drop: false }` [INFO] [stderr] Checking custom-errors v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `header` and `data` are never read [INFO] [stdout] --> src/csvreader.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct CsvData { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 12 | pub header: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | pub data: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CsvData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `line_num` and `num_entries` are never read [INFO] [stdout] --> src/csvreader.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct CsvLineLen { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 18 | pub line_num: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | pub num_entries: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CsvLineLen` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | CouldNotOpenFile(io::Error), [INFO] [stdout] | ---------------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 25 | CouldNotOpenFile(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 26 | CouldNotParseLine(Box), [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | CouldNotParseLine(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 28 | CouldNotParseValue(String), [INFO] [stdout] | ------------------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | CouldNotParseValue(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | LineTooShort(CsvLineLen), [INFO] [stdout] | ------------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 29 | LineTooShort(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | LineTooLong(CsvLineLen), [INFO] [stdout] | ----------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 30 | LineTooLong(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csvreader.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 94 | let file = OpenOptions::new().read(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let lines: Vec<_> = BufReader::new(file).lines().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | // ERROR 3: line could not be parsed. [INFO] [stdout] 97 | / lines [INFO] [stdout] 98 | | .into_iter() [INFO] [stdout] 99 | | .map(|line| line.map_err(|e| CsvError::CouldNotParseLine(Box::new(e)))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csvreader.rs:99:66 [INFO] [stdout] | [INFO] [stdout] 99 | .map(|line| line.map_err(|e| CsvError::CouldNotParseLine(Box::new(e)))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `header` and `data` are never read [INFO] [stdout] --> src/csvreader.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct CsvData { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 12 | pub header: Vec, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | pub data: Vec>, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CsvData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `line_num` and `num_entries` are never read [INFO] [stdout] --> src/csvreader.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub struct CsvLineLen { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 18 | pub line_num: usize, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 19 | pub num_entries: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `CsvLineLen` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:25:22 [INFO] [stdout] | [INFO] [stdout] 25 | CouldNotOpenFile(io::Error), [INFO] [stdout] | ---------------- ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 25 | CouldNotOpenFile(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:26:23 [INFO] [stdout] | [INFO] [stdout] 26 | CouldNotParseLine(Box), [INFO] [stdout] | ----------------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 26 | CouldNotParseLine(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:28:24 [INFO] [stdout] | [INFO] [stdout] 28 | CouldNotParseValue(String), [INFO] [stdout] | ------------------ ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 28 | CouldNotParseValue(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:29:18 [INFO] [stdout] | [INFO] [stdout] 29 | LineTooShort(CsvLineLen), [INFO] [stdout] | ------------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 29 | LineTooShort(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/csvreader.rs:30:17 [INFO] [stdout] | [INFO] [stdout] 30 | LineTooLong(CsvLineLen), [INFO] [stdout] | ----------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `CsvError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 30 | LineTooLong(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csvreader.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 94 | let file = OpenOptions::new().read(true).open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let lines: Vec<_> = BufReader::new(file).lines().collect(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | // ERROR 3: line could not be parsed. [INFO] [stdout] 97 | / lines [INFO] [stdout] 98 | | .into_iter() [INFO] [stdout] 99 | | .map(|line| line.map_err(|e| CsvError::CouldNotParseLine(Box::new(e)))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/csvreader.rs:99:66 [INFO] [stdout] | [INFO] [stdout] 99 | .map(|line| line.map_err(|e| CsvError::CouldNotParseLine(Box::new(e)))) [INFO] [stdout] | - ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `custom-errors` (bin "custom-errors") due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `custom-errors` (bin "custom-errors" test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ace13b7027850a6ead8cec426e2f535db8ae858d0a76a82cf92f833d8ff4fb7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ace13b7027850a6ead8cec426e2f535db8ae858d0a76a82cf92f833d8ff4fb7b", kill_on_drop: false }` [INFO] [stdout] ace13b7027850a6ead8cec426e2f535db8ae858d0a76a82cf92f833d8ff4fb7b