[INFO] cloning repository https://github.com/ThermalSpan/annotate [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ThermalSpan/annotate" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThermalSpan%2Fannotate", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThermalSpan%2Fannotate'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9b230e4a06d1e8d60fa83f0fc7b8faac58868962 [INFO] checking ThermalSpan/annotate/9b230e4a06d1e8d60fa83f0fc7b8faac58868962 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThermalSpan%2Fannotate" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ThermalSpan/annotate on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ThermalSpan/annotate [INFO] finished tweaking git repo https://github.com/ThermalSpan/annotate [INFO] tweaked toml for git repo https://github.com/ThermalSpan/annotate written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ThermalSpan/annotate already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `clap` dependency) [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21cc41ebc886899a2f43f062fe9522dfe433990e9c0c69f30ac83462abe5e7bb [INFO] running `Command { std: "docker" "start" "-a" "21cc41ebc886899a2f43f062fe9522dfe433990e9c0c69f30ac83462abe5e7bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21cc41ebc886899a2f43f062fe9522dfe433990e9c0c69f30ac83462abe5e7bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21cc41ebc886899a2f43f062fe9522dfe433990e9c0c69f30ac83462abe5e7bb", kill_on_drop: false }` [INFO] [stdout] 21cc41ebc886899a2f43f062fe9522dfe433990e9c0c69f30ac83462abe5e7bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8fd457c1a37dfe2eab167c2c3a367f1075350403c5744c2d16c81c1f63d643b9 [INFO] running `Command { std: "docker" "start" "-a" "8fd457c1a37dfe2eab167c2c3a367f1075350403c5744c2d16c81c1f63d643b9", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `clap` dependency) [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.34 [INFO] [stderr] Compiling cc v1.0.3 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.5 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking strsim v0.6.0 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking regex-syntax v0.4.1 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking ansi_term v0.10.2 [INFO] [stderr] Checking thread_local v0.3.5 [INFO] [stderr] Checking utf8-ranges v1.0.0 [INFO] [stderr] Checking memchr v2.0.1 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking aho-corasick v0.6.4 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking regex v0.2.3 [INFO] [stderr] Checking backtrace v0.3.4 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking annotate v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / error_chain! { [INFO] [stdout] 119 | | errors { [INFO] [stdout] 120 | | UnableToAddOrigExtension { [INFO] [stdout] 121 | | description("We were unable to add the .orig extension the ouput path") [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] 129 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / error_chain! { [INFO] [stdout] 119 | | errors { [INFO] [stdout] 120 | | UnableToAddOrigExtension { [INFO] [stdout] 121 | | description("We were unable to add the .orig extension the ouput path") [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] 129 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/main.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / error_chain! { [INFO] [stdout] 119 | | errors { [INFO] [stdout] 120 | | UnableToAddOrigExtension { [INFO] [stdout] 121 | | description("We were unable to add the .orig extension the ouput path") [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] 129 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::cause`: replaced by Error::source, which can support downcasting [INFO] [stdout] --> src/main.rs:118:1 [INFO] [stdout] | [INFO] [stdout] 118 | / error_chain! { [INFO] [stdout] 119 | | errors { [INFO] [stdout] 120 | | UnableToAddOrigExtension { [INFO] [stdout] 121 | | description("We were unable to add the .orig extension the ouput path") [INFO] [stdout] ... | [INFO] [stdout] 128 | | } [INFO] [stdout] 129 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_error_chain_processed` which comes from the expansion of the macro `error_chain` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | let mut reader = BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut reader = BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | let mut output_file = File::create(&input_file).chain_err(|| { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | let mut orig_file = File::open(&orig_path).chain_err(|| { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let mut reader = BufReader::new(orig_file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut line = line_maybe.chain_err(|| { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args_and_usage.rs:121:26 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|r| r.unwrap().path()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `annotate` (bin "annotate" test) due to 2 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | let mut reader = BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | let mut reader = BufReader::new(file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | let mut output_file = File::create(&input_file).chain_err(|| { [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 83 | let mut orig_file = File::open(&orig_path).chain_err(|| { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 87 | let mut reader = BufReader::new(orig_file); [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let mut line = line_maybe.chain_err(|| { [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args_and_usage.rs:121:26 [INFO] [stdout] | [INFO] [stdout] 121 | .map(|r| r.unwrap().path()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `annotate` (bin "annotate") due to 2 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8fd457c1a37dfe2eab167c2c3a367f1075350403c5744c2d16c81c1f63d643b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8fd457c1a37dfe2eab167c2c3a367f1075350403c5744c2d16c81c1f63d643b9", kill_on_drop: false }` [INFO] [stdout] 8fd457c1a37dfe2eab167c2c3a367f1075350403c5744c2d16c81c1f63d643b9