[INFO] cloning repository https://github.com/TheSirC/vitte-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TheSirC/vitte-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheSirC%2Fvitte-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheSirC%2Fvitte-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ed0cb4b64b250ab79b0cd544bfbcbfe4b401d11f [INFO] checking TheSirC/vitte-rs/ed0cb4b64b250ab79b0cd544bfbcbfe4b401d11f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheSirC%2Fvitte-rs" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TheSirC/vitte-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TheSirC/vitte-rs [INFO] finished tweaking git repo https://github.com/TheSirC/vitte-rs [INFO] tweaked toml for git repo https://github.com/TheSirC/vitte-rs written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TheSirC/vitte-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 216ab4480884126d53fc1d76332a4ff165dc20559d7a43cae624aeb5101bfb39 [INFO] running `Command { std: "docker" "start" "-a" "216ab4480884126d53fc1d76332a4ff165dc20559d7a43cae624aeb5101bfb39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "216ab4480884126d53fc1d76332a4ff165dc20559d7a43cae624aeb5101bfb39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "216ab4480884126d53fc1d76332a4ff165dc20559d7a43cae624aeb5101bfb39", kill_on_drop: false }` [INFO] [stdout] 216ab4480884126d53fc1d76332a4ff165dc20559d7a43cae624aeb5101bfb39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 45b9b111e3a485ec979bb3bcf6b94f88c3fd34fa508872bfa3b6f3808d87f0fb [INFO] running `Command { std: "docker" "start" "-a" "45b9b111e3a485ec979bb3bcf6b94f88c3fd34fa508872bfa3b6f3808d87f0fb", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking oorandom v11.1.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking criterion-plot v0.4.1 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking rand v0.7.1 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking plotters v0.2.12 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking bstr v0.2.12 [INFO] [stderr] Checking serde_json v1.0.51 [INFO] [stderr] Checking csv v1.1.3 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Checking tinytemplate v1.0.3 [INFO] [stderr] Checking criterion v0.3.1 [INFO] [stderr] Checking vitte_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | fn sample<'s>(self, n: usize, N: usize, alpha: usize) [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | fn method_d(n: usize, N: usize, alpha: usize) -> Vec; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:12:43 [INFO] [stdout] | [INFO] [stdout] 12 | fn method_a(rng: ThreadRng, n: usize, N: usize, output: Vec) -> Vec; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampler.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 20 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Box::new(self.filter(move |_| { [INFO] [stdout] | __________________^ [INFO] [stdout] 29 | | if let Some(decision) = filtered.pop() { [INFO] [stdout] 30 | | decision [INFO] [stdout] 31 | | } else { [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | N: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | fn method_d(mut n: usize, mut N: usize, alpha: usize) -> Vec { [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `U` should have a snake case name [INFO] [stdout] --> src/sampler.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | let mut U: f64 = rng.gen(); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/sampler.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | let mut X: f64 = rng.sample(beta); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/sampler.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | let X = N as f64 * rng.sample(beta); // N is there to stretch the Beta distribution from [0, 1] to [0, N] [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Vp` should have a snake case name [INFO] [stdout] --> src/sampler.rs:86:25 [INFO] [stdout] | [INFO] [stdout] 86 | let Vp = y1 * (-X / N as f64 + 1.0) * (1.0 / (1.0 - X.trunc() / (qu1 as f64))); [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `vp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | mut N: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `S` should have a snake case name [INFO] [stdout] --> src/sampler.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | let mut S = 0; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `S` should have a snake case name [INFO] [stdout] --> src/sampler.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | let S: usize = ((N as f64).round() * rng.gen::() as f64).trunc() as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vitte_rs` (lib test) due to 2 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:9:35 [INFO] [stdout] | [INFO] [stdout] 9 | fn sample<'s>(self, n: usize, N: usize, alpha: usize) [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 11 | fn method_d(n: usize, N: usize, alpha: usize) -> Vec; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:12:43 [INFO] [stdout] | [INFO] [stdout] 12 | fn method_a(rng: ThreadRng, n: usize, N: usize, output: Vec) -> Vec; [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sampler.rs:28:18 [INFO] [stdout] | [INFO] [stdout] 20 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Box::new(self.filter(move |_| { [INFO] [stdout] | __________________^ [INFO] [stdout] 29 | | if let Some(decision) = filtered.pop() { [INFO] [stdout] 30 | | decision [INFO] [stdout] 31 | | } else { [INFO] [stdout] 32 | | false [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | N: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | fn method_d(mut n: usize, mut N: usize, alpha: usize) -> Vec { [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `U` should have a snake case name [INFO] [stdout] --> src/sampler.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | let mut U: f64 = rng.gen(); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `u` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/sampler.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | let mut X: f64 = rng.sample(beta); [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/sampler.rs:75:29 [INFO] [stdout] | [INFO] [stdout] 75 | let X = N as f64 * rng.sample(beta); // N is there to stretch the Beta distribution from [0, 1] to [0, N] [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `Vp` should have a snake case name [INFO] [stdout] --> src/sampler.rs:86:25 [INFO] [stdout] | [INFO] [stdout] 86 | let Vp = y1 * (-X / N as f64 + 1.0) * (1.0 / (1.0 - X.trunc() / (qu1 as f64))); [INFO] [stdout] | ^^ help: convert the identifier to snake case (notice the capitalization): `vp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `N` should have a snake case name [INFO] [stdout] --> src/sampler.rs:138:13 [INFO] [stdout] | [INFO] [stdout] 138 | mut N: usize, [INFO] [stdout] | ^ help: convert the identifier to snake case: `n` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `S` should have a snake case name [INFO] [stdout] --> src/sampler.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 143 | let mut S = 0; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `S` should have a snake case name [INFO] [stdout] --> src/sampler.rs:157:13 [INFO] [stdout] | [INFO] [stdout] 157 | let S: usize = ((N as f64).round() * rng.gen::() as f64).trunc() as usize; [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vitte_rs` (lib) due to 2 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "45b9b111e3a485ec979bb3bcf6b94f88c3fd34fa508872bfa3b6f3808d87f0fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "45b9b111e3a485ec979bb3bcf6b94f88c3fd34fa508872bfa3b6f3808d87f0fb", kill_on_drop: false }` [INFO] [stdout] 45b9b111e3a485ec979bb3bcf6b94f88c3fd34fa508872bfa3b6f3808d87f0fb