[INFO] cloning repository https://github.com/TheDevCactus/launchpad-controller [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TheDevCactus/launchpad-controller" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheDevCactus%2Flaunchpad-controller", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheDevCactus%2Flaunchpad-controller'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 84f18a4cc697b3a5de406945d85a14820c915e6d [INFO] checking TheDevCactus/launchpad-controller/84f18a4cc697b3a5de406945d85a14820c915e6d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheDevCactus%2Flaunchpad-controller" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TheDevCactus/launchpad-controller on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TheDevCactus/launchpad-controller [INFO] finished tweaking git repo https://github.com/TheDevCactus/launchpad-controller [INFO] tweaked toml for git repo https://github.com/TheDevCactus/launchpad-controller written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TheDevCactus/launchpad-controller already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d287f214676e0e60ee15dd8de5a893e9d71216ac07835494c0a7b4f4cdd62a48 [INFO] running `Command { std: "docker" "start" "-a" "d287f214676e0e60ee15dd8de5a893e9d71216ac07835494c0a7b4f4cdd62a48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d287f214676e0e60ee15dd8de5a893e9d71216ac07835494c0a7b4f4cdd62a48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d287f214676e0e60ee15dd8de5a893e9d71216ac07835494c0a7b4f4cdd62a48", kill_on_drop: false }` [INFO] [stdout] d287f214676e0e60ee15dd8de5a893e9d71216ac07835494c0a7b4f4cdd62a48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7daea6ca2302325e9cf430825c0563005f7253ea673e811095f7b4dc39b32e9a [INFO] running `Command { std: "docker" "start" "-a" "7daea6ca2302325e9cf430825c0563005f7253ea673e811095f7b4dc39b32e9a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking alsa v0.7.0 [INFO] [stderr] Checking regex-automata v0.3.3 [INFO] [stderr] Checking midir v0.9.1 [INFO] [stderr] Checking regex v1.9.1 [INFO] [stderr] Checking midi-game v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `CONTROL_LED_ON` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | CONTROL_LED_ON(u8, Color), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ControlLedOn` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CONTROL_LED_OFF` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | CONTROL_LED_OFF(u8), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ControlLedOff` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LED_ON` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | LED_ON(u8, Color), [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `LedOn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LED_OFF` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | LED_OFF(u8), [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `LedOff` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CONTROL_LED_ON` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | CONTROL_LED_ON(u8, Color), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ControlLedOn` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `CONTROL_LED_OFF` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | CONTROL_LED_OFF(u8), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `ControlLedOff` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LED_ON` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 60 | LED_ON(u8, Color), [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `LedOn` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `LED_OFF` should have an upper camel case name [INFO] [stdout] --> src/midi.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | LED_OFF(u8), [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `LedOff` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `in_connection` is never read [INFO] [stdout] --> src/midi.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct Midi { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 102 | in_connection: MidiInputConnection<()>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `msg` is never read [INFO] [stdout] --> src/services/log.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Log { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 3 | pub msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Log` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STOPPED_STATUS` is never used [INFO] [stdout] --> src/services/track.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const STOPPED_STATUS: &str = "Stopped"; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `pause` is never used [INFO] [stdout] --> src/services/track.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn pause() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `play` is never used [INFO] [stdout] --> src/services/track.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn play() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 114 | let midi_in = MidiInput::new(client_name); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let midi_out = MidiOutput::new(client_name); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let midi_in = midi_in.unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let midi_out = midi_out.unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let channel = mpsc::channel(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let input_connection_result = midi_in.connect( [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let input_connection = input_connection_result.unwrap(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | [INFO] [stdout] 176 | let output_connection_result = midi_out.connect(output_port, output_port_name); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let output_connection = output_connection_result.unwrap(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | Ok(Midi { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | in_connection: input_connection, [INFO] [stdout] 184 | | out_connection: output_connection, [INFO] [stdout] 185 | | incoming: channel.1, [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `midi-game` (bin "midi-game") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `in_connection` is never read [INFO] [stdout] --> src/midi.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 101 | pub struct Midi { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 102 | in_connection: MidiInputConnection<()>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `msg` is never read [INFO] [stdout] --> src/services/log.rs:3:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Log { [INFO] [stdout] | --- field in this struct [INFO] [stdout] 3 | pub msg: String, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Log` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `STOPPED_STATUS` is never used [INFO] [stdout] --> src/services/track.rs:10:7 [INFO] [stdout] | [INFO] [stdout] 10 | const STOPPED_STATUS: &str = "Stopped"; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `pause` is never used [INFO] [stdout] --> src/services/track.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn pause() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `play` is never used [INFO] [stdout] --> src/services/track.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn play() { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/midi.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 114 | let midi_in = MidiInput::new(client_name); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let midi_out = MidiOutput::new(client_name); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let midi_in = midi_in.unwrap(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | let midi_out = midi_out.unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let channel = mpsc::channel(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let input_connection_result = midi_in.connect( [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | let input_connection = input_connection_result.unwrap(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 175 | [INFO] [stdout] 176 | let output_connection_result = midi_out.connect(output_port, output_port_name); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 180 | let output_connection = output_connection_result.unwrap(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | [INFO] [stdout] 182 | Ok(Midi { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | in_connection: input_connection, [INFO] [stdout] 184 | | out_connection: output_connection, [INFO] [stdout] 185 | | incoming: channel.1, [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `midi-game` (bin "midi-game" test) due to 2 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7daea6ca2302325e9cf430825c0563005f7253ea673e811095f7b4dc39b32e9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7daea6ca2302325e9cf430825c0563005f7253ea673e811095f7b4dc39b32e9a", kill_on_drop: false }` [INFO] [stdout] 7daea6ca2302325e9cf430825c0563005f7253ea673e811095f7b4dc39b32e9a