[INFO] cloning repository https://github.com/TheBlek/tcpimpl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TheBlek/tcpimpl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheBlek%2Ftcpimpl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheBlek%2Ftcpimpl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 90e5f5e426ba33738c6b1b69a53c12c667b53f01 [INFO] checking TheBlek/tcpimpl/90e5f5e426ba33738c6b1b69a53c12c667b53f01 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheBlek%2Ftcpimpl" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TheBlek/tcpimpl on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TheBlek/tcpimpl [INFO] finished tweaking git repo https://github.com/TheBlek/tcpimpl [INFO] tweaked toml for git repo https://github.com/TheBlek/tcpimpl written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TheBlek/tcpimpl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7aed7ce39d82f2006a139a13c6b655cd3725073c7fa0323efb47354df2262cf1 [INFO] running `Command { std: "docker" "start" "-a" "7aed7ce39d82f2006a139a13c6b655cd3725073c7fa0323efb47354df2262cf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7aed7ce39d82f2006a139a13c6b655cd3725073c7fa0323efb47354df2262cf1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7aed7ce39d82f2006a139a13c6b655cd3725073c7fa0323efb47354df2262cf1", kill_on_drop: false }` [INFO] [stdout] 7aed7ce39d82f2006a139a13c6b655cd3725073c7fa0323efb47354df2262cf1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e8dfcd80bb155932306a0d8b5f5eab1da7fb723e9f97fd3e01e508be69f6cd2c [INFO] running `Command { std: "docker" "start" "-a" "e8dfcd80bb155932306a0d8b5f5eab1da7fb723e9f97fd3e01e508be69f6cd2c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking ioctl-sys v0.6.0 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Checking etherparse v0.13.0 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Checking tun v0.5.5 [INFO] [stderr] Checking tcpimpl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `retransmission` [INFO] [stdout] --> src/tcp/state.rs:227:46 [INFO] [stdout] | [INFO] [stdout] 227 | UnsyncTcpState::SynSent(isn, id, retransmission) => match ( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_retransmission` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `accept` is never used [INFO] [stdout] --> src/tcp/mod.rs:613:12 [INFO] [stdout] | [INFO] [stdout] 486 | impl ConnectionManager { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 613 | pub fn accept>( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Syn`, `Ack`, and `Fin` are never constructed [INFO] [stdout] --> src/tcp/packet.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub enum PacketResponse { [INFO] [stdout] | -------------- variants in this enum [INFO] [stdout] 31 | Reset(u32), [INFO] [stdout] 32 | Syn(u32), [INFO] [stdout] | ^^^ [INFO] [stdout] 33 | SynAck(u32, u32), [INFO] [stdout] 34 | Ack(u32, u32), [INFO] [stdout] | ^^^ [INFO] [stdout] 35 | Fin(u32, u32), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `urgent_pointer` and `isn` are never read [INFO] [stdout] --> src/tcp/state.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct SendConnectionState { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub urgent_pointer: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 14 | pub isn: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SendConnectionState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `isn` is never read [INFO] [stdout] --> src/tcp/state.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct ReceiveConnectionState { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub isn: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReceiveConnectionState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `TimeWait` is never constructed [INFO] [stdout] --> src/tcp/state.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub enum SyncTcpState { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 129 | TimeWait, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SynSent` is never constructed [INFO] [stdout] --> src/tcp/state.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 152 | pub(super) enum UnsyncTcpState { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 155 | SynSent(u32, ConnectionId, Retransmission), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp/mod.rs:600:12 [INFO] [stdout] | [INFO] [stdout] 487 | pub fn new(addr: impl tun::IntoAddress, netmask: &str) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let device = tun::create(&config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | device.set_nonblock()?; [INFO] [stdout] 500 | let inner = Arc::new(Mutex::new(InnerConnectionManager { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | let manager_ptr = Arc::clone(&inner); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 600 | Ok(ConnectionManager { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp/mod.rs:607:12 [INFO] [stdout] | [INFO] [stdout] 605 | addr: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | ) -> std::result::Result>::Error> { [INFO] [stdout] 607 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 608 | | manager: self.clone(), [INFO] [stdout] 609 | | address: addr.try_into()?, [INFO] [stdout] 610 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `retransmission` [INFO] [stdout] --> src/tcp/state.rs:227:46 [INFO] [stdout] | [INFO] [stdout] 227 | UnsyncTcpState::SynSent(isn, id, retransmission) => match ( [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_retransmission` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcpimpl` (bin "tcpimpl") due to 3 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `accept` is never used [INFO] [stdout] --> src/tcp/mod.rs:613:12 [INFO] [stdout] | [INFO] [stdout] 486 | impl ConnectionManager { [INFO] [stdout] | ---------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 613 | pub fn accept>( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Syn`, `Ack`, and `Fin` are never constructed [INFO] [stdout] --> src/tcp/packet.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 30 | pub enum PacketResponse { [INFO] [stdout] | -------------- variants in this enum [INFO] [stdout] 31 | Reset(u32), [INFO] [stdout] 32 | Syn(u32), [INFO] [stdout] | ^^^ [INFO] [stdout] 33 | SynAck(u32, u32), [INFO] [stdout] 34 | Ack(u32, u32), [INFO] [stdout] | ^^^ [INFO] [stdout] 35 | Fin(u32, u32), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `urgent_pointer` and `isn` are never read [INFO] [stdout] --> src/tcp/state.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct SendConnectionState { [INFO] [stdout] | ------------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | pub urgent_pointer: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 14 | pub isn: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SendConnectionState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `isn` is never read [INFO] [stdout] --> src/tcp/state.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct ReceiveConnectionState { [INFO] [stdout] | ---------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 21 | pub isn: u32, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ReceiveConnectionState` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `TimeWait` is never constructed [INFO] [stdout] --> src/tcp/state.rs:129:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub enum SyncTcpState { [INFO] [stdout] | ------------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 129 | TimeWait, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SynSent` is never constructed [INFO] [stdout] --> src/tcp/state.rs:155:5 [INFO] [stdout] | [INFO] [stdout] 152 | pub(super) enum UnsyncTcpState { [INFO] [stdout] | -------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 155 | SynSent(u32, ConnectionId, Retransmission), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp/mod.rs:600:12 [INFO] [stdout] | [INFO] [stdout] 487 | pub fn new(addr: impl tun::IntoAddress, netmask: &str) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 498 | let device = tun::create(&config)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 499 | device.set_nonblock()?; [INFO] [stdout] 500 | let inner = Arc::new(Mutex::new(InnerConnectionManager { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | let manager_ptr = Arc::clone(&inner); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 600 | Ok(ConnectionManager { inner }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tcp/mod.rs:607:12 [INFO] [stdout] | [INFO] [stdout] 605 | addr: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 606 | ) -> std::result::Result>::Error> { [INFO] [stdout] 607 | Ok(TcpListener { [INFO] [stdout] | ____________^ [INFO] [stdout] 608 | | manager: self.clone(), [INFO] [stdout] 609 | | address: addr.try_into()?, [INFO] [stdout] 610 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tcpimpl` (bin "tcpimpl" test) due to 3 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e8dfcd80bb155932306a0d8b5f5eab1da7fb723e9f97fd3e01e508be69f6cd2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8dfcd80bb155932306a0d8b5f5eab1da7fb723e9f97fd3e01e508be69f6cd2c", kill_on_drop: false }` [INFO] [stdout] e8dfcd80bb155932306a0d8b5f5eab1da7fb723e9f97fd3e01e508be69f6cd2c