[INFO] cloning repository https://github.com/ThatOnePizza/gpt_explorer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ThatOnePizza/gpt_explorer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThatOnePizza%2Fgpt_explorer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThatOnePizza%2Fgpt_explorer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c9ec72ed0266eeade965f55fe7ed3fa6dc29c4f [INFO] checking ThatOnePizza/gpt_explorer/5c9ec72ed0266eeade965f55fe7ed3fa6dc29c4f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThatOnePizza%2Fgpt_explorer" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ThatOnePizza/gpt_explorer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ThatOnePizza/gpt_explorer [INFO] finished tweaking git repo https://github.com/ThatOnePizza/gpt_explorer [INFO] tweaked toml for git repo https://github.com/ThatOnePizza/gpt_explorer written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ThatOnePizza/gpt_explorer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 659da91b8934fd29bb108479e97f84301fd0ca631aa3abddc43a04b52d27ecee [INFO] running `Command { std: "docker" "start" "-a" "659da91b8934fd29bb108479e97f84301fd0ca631aa3abddc43a04b52d27ecee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "659da91b8934fd29bb108479e97f84301fd0ca631aa3abddc43a04b52d27ecee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "659da91b8934fd29bb108479e97f84301fd0ca631aa3abddc43a04b52d27ecee", kill_on_drop: false }` [INFO] [stdout] 659da91b8934fd29bb108479e97f84301fd0ca631aa3abddc43a04b52d27ecee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7619be77ec8714fa5a3e5948b76097f703de4e6546525c77faddb42db54f9221 [INFO] running `Command { std: "docker" "start" "-a" "7619be77ec8714fa5a3e5948b76097f703de4e6546525c77faddb42db54f9221", kill_on_drop: false }` [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking either v1.7.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking gpt_explorer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/gpt.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct GptHeader<'a> { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 22 | pub signature: Box<&'a [u8]>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 23 | pub revision: Box<&'a [u8]>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 24 | pub size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | pub head_crc32: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | // 4 null bytes [INFO] [stdout] 27 | pub my_lba: u64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 28 | pub alt_lba: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 29 | pub first_usable_lba: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 30 | pub last_usable_lba: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 31 | pub guid: Box<&'a [u8]>, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub part_crc32: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/gpt.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 98 | signature: Box::new(sign.clone()), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpt.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn get_partition_table(buff: &Vec, header: GptHeader) -> PartitionTable { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | partitions: table_buf [INFO] [stdout] | _____________________^ [INFO] [stdout] 139 | | .chunks(header.size_part_entry as usize) [INFO] [stdout] 140 | | .map(|a| Partition { [INFO] [stdout] 141 | | type_guid: Box::new(a[0x0..=0xf].try_into().expect("Couldn't get type guid")), [INFO] [stdout] ... | [INFO] [stdout] 149 | | .filter(|e| *e.type_guid != [0; 16]) [INFO] [stdout] 150 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpt.rs:141:28 [INFO] [stdout] | [INFO] [stdout] 141 | type_guid: Box::new(a[0x0..=0xf].try_into().expect("Couldn't get type guid")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpt.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 142 | guid: Box::new(a[0x10..=0x1f].try_into().expect("Couldn't get guid")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/gpt.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct GptHeader<'a> { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 22 | pub signature: Box<&'a [u8]>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 23 | pub revision: Box<&'a [u8]>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 24 | pub size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 25 | pub head_crc32: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | // 4 null bytes [INFO] [stdout] 27 | pub my_lba: u64, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 28 | pub alt_lba: u64, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 29 | pub first_usable_lba: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 30 | pub last_usable_lba: u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 31 | pub guid: Box<&'a [u8]>, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub part_crc32: u32, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gpt_explorer` (bin "gpt_explorer") due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/gpt.rs:98:33 [INFO] [stdout] | [INFO] [stdout] 98 | signature: Box::new(sign.clone()), [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpt.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn get_partition_table(buff: &Vec, header: GptHeader) -> PartitionTable { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | partitions: table_buf [INFO] [stdout] | _____________________^ [INFO] [stdout] 139 | | .chunks(header.size_part_entry as usize) [INFO] [stdout] 140 | | .map(|a| Partition { [INFO] [stdout] 141 | | type_guid: Box::new(a[0x0..=0xf].try_into().expect("Couldn't get type guid")), [INFO] [stdout] ... | [INFO] [stdout] 149 | | .filter(|e| *e.type_guid != [0; 16]) [INFO] [stdout] 150 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpt.rs:141:28 [INFO] [stdout] | [INFO] [stdout] 141 | type_guid: Box::new(a[0x0..=0xf].try_into().expect("Couldn't get type guid")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/gpt.rs:142:23 [INFO] [stdout] | [INFO] [stdout] 142 | guid: Box::new(a[0x10..=0x1f].try_into().expect("Couldn't get guid")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gpt_explorer` (bin "gpt_explorer" test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7619be77ec8714fa5a3e5948b76097f703de4e6546525c77faddb42db54f9221", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7619be77ec8714fa5a3e5948b76097f703de4e6546525c77faddb42db54f9221", kill_on_drop: false }` [INFO] [stdout] 7619be77ec8714fa5a3e5948b76097f703de4e6546525c77faddb42db54f9221