[INFO] cloning repository https://github.com/Testare/dit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Testare/dit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTestare%2Fdit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTestare%2Fdit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 54fb9ccd897dcfa2221f006d66b91c6ae0ace39a [INFO] checking Testare/dit/54fb9ccd897dcfa2221f006d66b91c6ae0ace39a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTestare%2Fdit" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Testare/dit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Testare/dit [INFO] finished tweaking git repo https://github.com/Testare/dit [INFO] tweaked toml for git repo https://github.com/Testare/dit written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Testare/dit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07f3197c9457881bc099035222b8235c48efb130bee93816ffa2401a0ea93492 [INFO] running `Command { std: "docker" "start" "-a" "07f3197c9457881bc099035222b8235c48efb130bee93816ffa2401a0ea93492", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07f3197c9457881bc099035222b8235c48efb130bee93816ffa2401a0ea93492", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07f3197c9457881bc099035222b8235c48efb130bee93816ffa2401a0ea93492", kill_on_drop: false }` [INFO] [stdout] 07f3197c9457881bc099035222b8235c48efb130bee93816ffa2401a0ea93492 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20847f2b344d342d65875e286ee9102f0fbbe86708aca4b3f74ad4c8a6342a56 [INFO] running `Command { std: "docker" "start" "-a" "20847f2b344d342d65875e286ee9102f0fbbe86708aca4b3f74ad4c8a6342a56", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling typenum v1.13.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking wyz v0.4.0 [INFO] [stderr] Checking funty v1.2.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking roff v0.1.0 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking man v0.3.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling hex-literal v0.3.1 [INFO] [stderr] Checking bitvec v0.22.3 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking crossterm v0.17.7 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking sha3 v0.9.1 [INFO] [stderr] Checking dit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::iter::FromIterator` [INFO] [stdout] --> src/dit_core/model/ledger.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::iter::FromIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `book::Book` [INFO] [stdout] --> src/dit_core/model.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use book::Book; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:1:45 [INFO] [stdout] | [INFO] [stdout] 1 | use super::dit_core::{read_state, validate, with_game_state, ActionInterface}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | let k = with_game_state(file_name, |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/dit_core.rs:10:37 [INFO] [stdout] | [INFO] [stdout] 10 | pub use ops::{read_state, validate, with_game_state}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::iter::FromIterator` [INFO] [stdout] --> src/dit_core/model/ledger.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::iter::FromIterator; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `book::Book` [INFO] [stdout] --> src/dit_core/model.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | pub use book::Book; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:1:45 [INFO] [stdout] | [INFO] [stdout] 1 | use super::dit_core::{read_state, validate, with_game_state, ActionInterface}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/app.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 57 | let k = with_game_state(file_name, |_| { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `dit_core::ops::with_game_state`: We'll be using book instead, only keeping this around to scale refactor [INFO] [stdout] --> src/dit_core.rs:10:37 [INFO] [stdout] | [INFO] [stdout] 10 | pub use ops::{read_state, validate, with_game_state}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/dit_core/model/book.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dit_core/model/book.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/dit_core/model/book.rs:54:17 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_state` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/dit_core/model/book.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `book` [INFO] [stdout] --> src/dit_core/model/book.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | let book = Book::::from_read(cursor).expect("Should be readable"); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_book` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `saved_lines`, `messages`, and `state` are never read [INFO] [stdout] --> src/dit_core/model/book.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Book { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 12 | saved_lines: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | messages: MessageVec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 14 | state: A::State, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Book` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/dit_core/model/book.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl Book { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 18 | pub fn ledger(&self) -> Ledger<'_, A> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn state(&self) -> &A::State { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn write_changes(&mut self, writer: &mut W) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn write_pending_changes(&self, writer: &mut W) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn from_read(r: R) -> Result, super::Error> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 80 | fn apply_message_internal( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn apply_message(&mut self, msg: Message) -> Result<&mut Self, super::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model.rs:17:30 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Copy, Clone, Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dit_core/model/book.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | self.write_pending_changes(writer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | let _ = self.write_pending_changes(writer); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | i.take_while(|line| (&line).is_ok() && line.as_ref().unwrap() == "\"\"") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | .fold(A::State::default(), |state, header_line| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_read(r: R) -> Result, super::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let reader = BufReader::new(r); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let iter = reader.lines(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | let messages: MessageVec = iter [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let state = (0..saved_lines).try_fold(A::State::default(), |state, n| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Book { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | messages, [INFO] [stdout] 75 | | saved_lines, [INFO] [stdout] 76 | | state, [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|line_result| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | / line_result [INFO] [stdout] 59 | | .map_err(super::Error::IoError2) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 32 | |(state, _), line_result| { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let line = line_result.map_err(io_error(file_name))?; [INFO] [stdout] 34 | let new_message = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | serde_json::from_str::>(line.as_str()).map_err(Error::SerdeError)?; [INFO] [stdout] 36 | / new_message [INFO] [stdout] 37 | | .action() [INFO] [stdout] 38 | | .apply(&Ledger::new().with_hash(new_message.key()), state) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 32 | |(state, _), line_result| { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let line = line_result.map_err(io_error(file_name))?; [INFO] [stdout] 34 | let new_message = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | .map(|state| (state, new_message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 56 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let message_vec: Vec> = file_lines [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let state = message_vec [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok((state, Ledger::default())) // BROKEN [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 85 | let file = File::open(file_name).map_err(io_error(file_name))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let lines = BufReader::new(file).lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | / lines [INFO] [stdout] 88 | | .map(|line_result| line_result.unwrap()) [INFO] [stdout] 89 | | .map(|line| serde_json::from_str::>(line.as_str()).unwrap()) // Should probably refactor to return a SeDe error [INFO] [stdout] 90 | | .zip(1..) [INFO] [stdout] ... | [INFO] [stdout] 107 | | }, [INFO] [stdout] 108 | | ) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:109:14 [INFO] [stdout] | [INFO] [stdout] 85 | let file = File::open(file_name).map_err(io_error(file_name))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let lines = BufReader::new(file).lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | .and(Ok(())) // We don't want to pass final value of the fold on [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | .map(|line| serde_json::from_str::>(line.as_str()).unwrap()) // Should probably refactor to return a SeDe error [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mode_a.rs:7:32 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Clone, Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dit` (lib) due to 13 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `saved_lines`, `messages`, and `state` are never read [INFO] [stdout] --> src/dit_core/model/book.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct Book { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 12 | saved_lines: usize, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | messages: MessageVec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 14 | state: A::State, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Book` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `ledger`, `state`, `write_changes`, `write_pending_changes`, `from_read_header`, and `apply_message` are never used [INFO] [stdout] --> src/dit_core/model/book.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl Book { [INFO] [stdout] | ----------------------- associated items in this implementation [INFO] [stdout] 18 | pub fn ledger(&self) -> Ledger<'_, A> { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 22 | pub fn state(&self) -> &A::State { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | pub fn write_changes(&mut self, writer: &mut W) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn write_pending_changes(&self, writer: &mut W) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 94 | pub fn apply_message(&mut self, msg: Message) -> Result<&mut Self, super::Error> { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model.rs:17:30 [INFO] [stdout] | [INFO] [stdout] 17 | #[derive(Copy, Clone, Debug, Deserialize, Serialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/dit_core/model/book.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | self.write_pending_changes(writer); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 27 | let _ = self.write_pending_changes(writer); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | i.take_while(|line| (&line).is_ok() && line.as_ref().unwrap() == "\"\"") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:44:19 [INFO] [stdout] | [INFO] [stdout] 39 | fn from_read_header(i: I) -> A::State [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | .fold(A::State::default(), |state, header_line| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn from_read(r: R) -> Result, super::Error> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let reader = BufReader::new(r); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | let iter = reader.lines(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | let mut state = A::State::default(); //Self::from_read_header(iter.by_ref()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | [INFO] [stdout] 56 | let messages: MessageVec = iter [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | let state = (0..saved_lines).try_fold(A::State::default(), |state, n| { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Ok(Book { [INFO] [stdout] | ____________^ [INFO] [stdout] 74 | | messages, [INFO] [stdout] 75 | | saved_lines, [INFO] [stdout] 76 | | state, [INFO] [stdout] 77 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/model/book.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 57 | .map(|line_result| { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | / line_result [INFO] [stdout] 59 | | .map_err(super::Error::IoError2) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 32 | |(state, _), line_result| { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let line = line_result.map_err(io_error(file_name))?; [INFO] [stdout] 34 | let new_message = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | serde_json::from_str::>(line.as_str()).map_err(Error::SerdeError)?; [INFO] [stdout] 36 | / new_message [INFO] [stdout] 37 | | .action() [INFO] [stdout] 38 | | .apply(&Ledger::new().with_hash(new_message.key()), state) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 32 | |(state, _), line_result| { [INFO] [stdout] | ---------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let line = line_result.map_err(io_error(file_name))?; [INFO] [stdout] 34 | let new_message = [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | .map(|state| (state, new_message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 56 | let file = OpenOptions::new() [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let message_vec: Vec> = file_lines [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | let state = message_vec [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | Ok((state, Ledger::default())) // BROKEN [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:87:5 [INFO] [stdout] | [INFO] [stdout] 85 | let file = File::open(file_name).map_err(io_error(file_name))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let lines = BufReader::new(file).lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | / lines [INFO] [stdout] 88 | | .map(|line_result| line_result.unwrap()) [INFO] [stdout] 89 | | .map(|line| serde_json::from_str::>(line.as_str()).unwrap()) // Should probably refactor to return a SeDe error [INFO] [stdout] 90 | | .zip(1..) [INFO] [stdout] ... | [INFO] [stdout] 107 | | }, [INFO] [stdout] 108 | | ) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:109:14 [INFO] [stdout] | [INFO] [stdout] 85 | let file = File::open(file_name).map_err(io_error(file_name))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let lines = BufReader::new(file).lines(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | .and(Ok(())) // We don't want to pass final value of the fold on [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dit_core/ops.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 89 | .map(|line| serde_json::from_str::>(line.as_str()).unwrap()) // Should probably refactor to return a SeDe error [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mode_a.rs:7:32 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Clone, Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dit` (lib test) due to 13 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "20847f2b344d342d65875e286ee9102f0fbbe86708aca4b3f74ad4c8a6342a56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20847f2b344d342d65875e286ee9102f0fbbe86708aca4b3f74ad4c8a6342a56", kill_on_drop: false }` [INFO] [stdout] 20847f2b344d342d65875e286ee9102f0fbbe86708aca4b3f74ad4c8a6342a56