[INFO] cloning repository https://github.com/Tehforsch/pundit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Tehforsch/pundit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTehforsch%2Fpundit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTehforsch%2Fpundit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1fa3daa2e22b9374d377de58c3e416ebe8948c71 [INFO] checking Tehforsch/pundit/1fa3daa2e22b9374d377de58c3e416ebe8948c71 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTehforsch%2Fpundit" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Tehforsch/pundit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Tehforsch/pundit [INFO] finished tweaking git repo https://github.com/Tehforsch/pundit [INFO] tweaked toml for git repo https://github.com/Tehforsch/pundit written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Tehforsch/pundit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4e00812d5a3fd314ba7bc5e23033e5a6f40aaf554c5eb213fc4c7d7239e1630 [INFO] running `Command { std: "docker" "start" "-a" "c4e00812d5a3fd314ba7bc5e23033e5a6f40aaf554c5eb213fc4c7d7239e1630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4e00812d5a3fd314ba7bc5e23033e5a6f40aaf554c5eb213fc4c7d7239e1630", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4e00812d5a3fd314ba7bc5e23033e5a6f40aaf554c5eb213fc4c7d7239e1630", kill_on_drop: false }` [INFO] [stdout] c4e00812d5a3fd314ba7bc5e23033e5a6f40aaf554c5eb213fc4c7d7239e1630 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d32acfefa1d6039a57d0c7e4b9eefc998c1b8293bb99df54d87c958da2b23dfc [INFO] running `Command { std: "docker" "start" "-a" "d32acfefa1d6039a57d0c7e4b9eefc998c1b8293bb99df54d87c958da2b23dfc", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Checking ahash v0.4.8 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Checking iana-time-zone v0.1.59 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking dissimilar v1.0.7 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rusqlite v0.24.2 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking shellexpand v2.1.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling prost-derive v0.8.0 [INFO] [stderr] Compiling clap_derive v3.2.25 [INFO] [stderr] Checking prost v0.8.0 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking pundit v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `InvalidNoteError` is never constructed [INFO] [stdout] --> src/note.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | struct InvalidNoteError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InvalidTitleError` is never constructed [INFO] [stdout] --> src/note.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct InvalidTitleError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/anki/mod.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn close_connection(connection: Connection) -> rusqlite::Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | match connection.close() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/anki/mod.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 272 | let mut stmt = connection.prepare( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let note_iterator = stmt.query_map(params![], |row| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | / note_iterator [INFO] [stdout] 292 | | .map(|anki_note| anki_note.context("Reading row in notes table")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir_utils.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 12 | let folder_files = Box::new(iter_files(folder)?); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let sub_folders = iter_folders(folder)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let sub_folder_results = sub_folders.map(|f| traverse_folder_files(&f)); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let sub_folder_files_iterators_result: Result>>> = [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | sub_folder_results.collect(); [INFO] [stdout] 17 | let sub_folder_files_iterator = (sub_folder_files_iterators_result?) [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Box::new(folder_files.chain(sub_folder_files_iterator))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir_utils.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 33 | predicate: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let entries = fs::read_dir(folder)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let dir_entries: std::io::Result> = entries.collect(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(dir_entries? [INFO] [stdout] | ________^ [INFO] [stdout] 41 | | .into_iter() [INFO] [stdout] 42 | | .map(|entry| entry.path()) [INFO] [stdout] 43 | | .filter(move |path| predicate(path))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 120 | let re = Regex::new(r"\[\[file:(.*?)\]\[(.*?)\]\]").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | / re.captures_iter(contents) [INFO] [stdout] 122 | | .map(|cap| Path::new(&cap[1].to_string()).to_path_buf()) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note_arg.rs:20:39 [INFO] [stdout] | [INFO] [stdout] 20 | .filter(|n| n.filename == self.filename.canonicalize().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes.rs:150:8 [INFO] [stdout] | [INFO] [stdout] 140 | fn filter_result(it: Box>, predicate: F) -> Result> [INFO] [stdout] | ------------------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let results: Result> = it [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(results? [INFO] [stdout] | ________^ [INFO] [stdout] 151 | | .into_iter() [INFO] [stdout] 152 | | .filter(|(_, v)| *v) [INFO] [stdout] 153 | | .map(|(t, _)| t) [INFO] [stdout] 154 | | .collect()) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 140 | fn filter_result(it: Box>, predicate: F) -> Result> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | .map(move |t| match predicate(&t) { [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes.rs:163:19 [INFO] [stdout] | [INFO] [stdout] 163 | filter_result(Box::new(files.into_iter()), |path| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pankit/mod.rs:327:5 [INFO] [stdout] | [INFO] [stdout] 327 | get_anki_info_from_note_contents(contents).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pankit/mod.rs:375:30 [INFO] [stdout] | [INFO] [stdout] 375 | .and_then(|filename| get_model_and_deck_name_from_first_anki_note(filename).transpose()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paper.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 53 | let re = [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Regex::new(r"@(article|inproceedings|book|inbook|proceedings|phdthesis)\{(\w*),").unwrap(); [INFO] [stdout] 55 | / re.captures_iter(contents) [INFO] [stdout] 56 | | .map(|capture| capture.get(2).unwrap().as_str().to_owned()) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InvalidNoteError` is never constructed [INFO] [stdout] --> src/note.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | struct InvalidNoteError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `InvalidTitleError` is never constructed [INFO] [stdout] --> src/note.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct InvalidTitleError; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/anki/mod.rs:57:11 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn close_connection(connection: Connection) -> rusqlite::Result<()> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 57 | match connection.close() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/anki/mod.rs:291:5 [INFO] [stdout] | [INFO] [stdout] 272 | let mut stmt = connection.prepare( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | let note_iterator = stmt.query_map(params![], |row| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | / note_iterator [INFO] [stdout] 292 | | .map(|anki_note| anki_note.context("Reading row in notes table")) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir_utils.rs:20:8 [INFO] [stdout] | [INFO] [stdout] 12 | let folder_files = Box::new(iter_files(folder)?); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let sub_folders = iter_folders(folder)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | let sub_folder_results = sub_folders.map(|f| traverse_folder_files(&f)); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | let sub_folder_files_iterators_result: Result>>> = [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | sub_folder_results.collect(); [INFO] [stdout] 17 | let sub_folder_files_iterator = (sub_folder_files_iterators_result?) [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Ok(Box::new(folder_files.chain(sub_folder_files_iterator))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir_utils.rs:40:8 [INFO] [stdout] | [INFO] [stdout] 33 | predicate: F, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let entries = fs::read_dir(folder)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let dir_entries: std::io::Result> = entries.collect(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(dir_entries? [INFO] [stdout] | ________^ [INFO] [stdout] 41 | | .into_iter() [INFO] [stdout] 42 | | .map(|entry| entry.path()) [INFO] [stdout] 43 | | .filter(move |path| predicate(path))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 120 | let re = Regex::new(r"\[\[file:(.*?)\]\[(.*?)\]\]").unwrap(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | / re.captures_iter(contents) [INFO] [stdout] 122 | | .map(|cap| Path::new(&cap[1].to_string()).to_path_buf()) [INFO] [stdout] | |________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/note_arg.rs:20:39 [INFO] [stdout] | [INFO] [stdout] 20 | .filter(|n| n.filename == self.filename.canonicalize().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes.rs:150:8 [INFO] [stdout] | [INFO] [stdout] 140 | fn filter_result(it: Box>, predicate: F) -> Result> [INFO] [stdout] | ------------------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | let results: Result> = it [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | Ok(results? [INFO] [stdout] | ________^ [INFO] [stdout] 151 | | .into_iter() [INFO] [stdout] 152 | | .filter(|(_, v)| *v) [INFO] [stdout] 153 | | .map(|(t, _)| t) [INFO] [stdout] 154 | | .collect()) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes.rs:145:29 [INFO] [stdout] | [INFO] [stdout] 140 | fn filter_result(it: Box>, predicate: F) -> Result> [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | .map(move |t| match predicate(&t) { [INFO] [stdout] | - ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pundit` (lib test) due to 13 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/notes.rs:163:19 [INFO] [stdout] | [INFO] [stdout] 163 | filter_result(Box::new(files.into_iter()), |path| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pankit/mod.rs:327:5 [INFO] [stdout] | [INFO] [stdout] 327 | get_anki_info_from_note_contents(contents).context(format!( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pankit/mod.rs:375:30 [INFO] [stdout] | [INFO] [stdout] 375 | .and_then(|filename| get_model_and_deck_name_from_first_anki_note(filename).transpose()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/paper.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 53 | let re = [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Regex::new(r"@(article|inproceedings|book|inbook|proceedings|phdthesis)\{(\w*),").unwrap(); [INFO] [stdout] 55 | / re.captures_iter(contents) [INFO] [stdout] 56 | | .map(|capture| capture.get(2).unwrap().as_str().to_owned()) [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pundit` (lib) due to 13 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d32acfefa1d6039a57d0c7e4b9eefc998c1b8293bb99df54d87c958da2b23dfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d32acfefa1d6039a57d0c7e4b9eefc998c1b8293bb99df54d87c958da2b23dfc", kill_on_drop: false }` [INFO] [stdout] d32acfefa1d6039a57d0c7e4b9eefc998c1b8293bb99df54d87c958da2b23dfc