[INFO] cloning repository https://github.com/TKFRvisionOfficial/dmx-rdm-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TKFRvisionOfficial/dmx-rdm-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTKFRvisionOfficial%2Fdmx-rdm-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTKFRvisionOfficial%2Fdmx-rdm-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 69c6e857d508a7f37b552f5706e18db08b8d2b89 [INFO] checking TKFRvisionOfficial/dmx-rdm-rs/69c6e857d508a7f37b552f5706e18db08b8d2b89 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTKFRvisionOfficial%2Fdmx-rdm-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/TKFRvisionOfficial/dmx-rdm-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/TKFRvisionOfficial/dmx-rdm-rs [INFO] finished tweaking git repo https://github.com/TKFRvisionOfficial/dmx-rdm-rs [INFO] tweaked toml for git repo https://github.com/TKFRvisionOfficial/dmx-rdm-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/TKFRvisionOfficial/dmx-rdm-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e4fead5707f93bacb03c405a1bc6f5048e870028c3b76173b666f7e33ef9c9e [INFO] running `Command { std: "docker" "start" "-a" "6e4fead5707f93bacb03c405a1bc6f5048e870028c3b76173b666f7e33ef9c9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e4fead5707f93bacb03c405a1bc6f5048e870028c3b76173b666f7e33ef9c9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e4fead5707f93bacb03c405a1bc6f5048e870028c3b76173b666f7e33ef9c9e", kill_on_drop: false }` [INFO] [stdout] 6e4fead5707f93bacb03c405a1bc6f5048e870028c3b76173b666f7e33ef9c9e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0b7165d90c1a463867c607490db3551af05b5efefd2a85ea884299b0ee8992d [INFO] running `Command { std: "docker" "start" "-a" "b0b7165d90c1a463867c607490db3551af05b5efefd2a85ea884299b0ee8992d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling modular-bitfield-impl v0.11.2 [INFO] [stderr] Checking binary-layout v4.0.2 [INFO] [stderr] Checking modular-bitfield v0.11.2 [INFO] [stderr] Checking dmx-rdm v0.0.12-alpha (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_controller.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 340 | let response_info = match self.rdm_get(RdmRequest::empty( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | RdmResponse::Response(response_info) => response_info, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | Ok(rdm_packages::deserialize_software_version_label( [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | &response_info.data, [INFO] [stdout] 350 | | )?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_controller.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 340 | let response_info = match self.rdm_get(RdmRequest::empty( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | RdmResponse::Response(response_info) => response_info, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | Ok(rdm_packages::deserialize_software_version_label( [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | &response_info.data, [INFO] [stdout] 350 | | )?) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_driver.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 242 | Ok(DmxFrame::from_slice(&buffer[..bytes_read]).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:142:35 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | rdm_receiver_handler: RdmResponderPackageHandler::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_data.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 47 | response: DataPack, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(RdmResponseData { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | destination_uid: PackageAddress::Device(self.source_uid), [INFO] [stdout] 52 | | source_uid: match self.destination_uid { [INFO] [stdout] 53 | | PackageAddress::Device(uid) => uid, [INFO] [stdout] ... | [INFO] [stdout] 62 | | parameter_data: response, [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_packages.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 76 | response_info: RdmResponseInfo, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | ) -> Result { [INFO] [stdout] 78 | Ok(match response_info.parameter_id { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | pids::IDENTIFY_DEVICE => { [INFO] [stdout] 80 | | RdmResponsePackage::IdentifyDevice(deserialize_identify(&response_info.data)?) [INFO] [stdout] 81 | | }, [INFO] [stdout] ... | [INFO] [stdout] 94 | | _ => Self::Custom(response_info), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_responder.rs:308:12 [INFO] [stdout] | [INFO] [stdout] 235 | request: RdmRequestData, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let response = match request.parameter_id { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | RdmResult::Acknowledged(response_data) => request.build_response( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | RdmResult::AcknowledgedOverflow(response_data) => request.build_response( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | RdmResult::Custom(response_data) => Ok(response_data), [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(RdmAnswer::NoResponse) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dmx-rdm` (lib test) due to 7 previous errors [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_driver.rs:242:12 [INFO] [stdout] | [INFO] [stdout] 242 | Ok(DmxFrame::from_slice(&buffer[..bytes_read]).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dmx-rdm` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dmx_receiver.rs:142:35 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn new(driver: D, config: RdmResponderConfig) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | rdm_receiver_handler: RdmResponderPackageHandler::new(config), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_data.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 47 | response: DataPack, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(RdmResponseData { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | destination_uid: PackageAddress::Device(self.source_uid), [INFO] [stdout] 52 | | source_uid: match self.destination_uid { [INFO] [stdout] 53 | | PackageAddress::Device(uid) => uid, [INFO] [stdout] ... | [INFO] [stdout] 62 | | parameter_data: response, [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_packages.rs:78:12 [INFO] [stdout] | [INFO] [stdout] 76 | response_info: RdmResponseInfo, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | ) -> Result { [INFO] [stdout] 78 | Ok(match response_info.parameter_id { [INFO] [stdout] | ____________^ [INFO] [stdout] 79 | | pids::IDENTIFY_DEVICE => { [INFO] [stdout] 80 | | RdmResponsePackage::IdentifyDevice(deserialize_identify(&response_info.data)?) [INFO] [stdout] 81 | | }, [INFO] [stdout] ... | [INFO] [stdout] 94 | | _ => Self::Custom(response_info), [INFO] [stdout] 95 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rdm_responder.rs:308:12 [INFO] [stdout] | [INFO] [stdout] 235 | request: RdmRequestData, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | let response = match request.parameter_id { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | RdmResult::Acknowledged(response_data) => request.build_response( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 279 | RdmResult::AcknowledgedOverflow(response_data) => request.build_response( [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 297 | RdmResult::Custom(response_data) => Ok(response_data), [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Ok(RdmAnswer::NoResponse) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "b0b7165d90c1a463867c607490db3551af05b5efefd2a85ea884299b0ee8992d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0b7165d90c1a463867c607490db3551af05b5efefd2a85ea884299b0ee8992d", kill_on_drop: false }` [INFO] [stdout] b0b7165d90c1a463867c607490db3551af05b5efefd2a85ea884299b0ee8992d