[INFO] cloning repository https://github.com/Szymongib/pbft-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Szymongib/pbft-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSzymongib%2Fpbft-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSzymongib%2Fpbft-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 12d7d29c4bf2a12aafcd720fd4f475057010a337 [INFO] checking Szymongib/pbft-rust/12d7d29c4bf2a12aafcd720fd4f475057010a337 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSzymongib%2Fpbft-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Szymongib/pbft-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Szymongib/pbft-rust [INFO] finished tweaking git repo https://github.com/Szymongib/pbft-rust [INFO] tweaked toml for git repo https://github.com/Szymongib/pbft-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Szymongib/pbft-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9259ad4283c832f0b929027f2ac194f6ff7041fff321bab60d5ae5da2be7dc03 [INFO] running `Command { std: "docker" "start" "-a" "9259ad4283c832f0b929027f2ac194f6ff7041fff321bab60d5ae5da2be7dc03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9259ad4283c832f0b929027f2ac194f6ff7041fff321bab60d5ae5da2be7dc03", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9259ad4283c832f0b929027f2ac194f6ff7041fff321bab60d5ae5da2be7dc03", kill_on_drop: false }` [INFO] [stdout] 9259ad4283c832f0b929027f2ac194f6ff7041fff321bab60d5ae5da2be7dc03 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63084339a5b784beb13afd15e16f81f2623dfb725428606b01f55c544036c4a7 [INFO] running `Command { std: "docker" "start" "-a" "63084339a5b784beb13afd15e16f81f2623dfb725428606b01f55c544036c4a7", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling thiserror v1.0.57 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking indexmap v2.2.5 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling axum-core v0.3.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking encoding_rs v0.8.33 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking data-encoding v2.5.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling axum v0.6.20 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking matchit v0.7.3 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling thiserror-impl v1.0.57 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling axum-macros v0.3.8 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pest v2.7.8 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Compiling pest_meta v2.7.8 [INFO] [stderr] Compiling pest_generator v2.7.8 [INFO] [stderr] Compiling pest_derive v2.7.8 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking h2 v0.3.24 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking serde_path_to_error v0.1.15 [INFO] [stderr] Checking config v0.13.4 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.24 [INFO] [stderr] Checking pbft-core v0.1.0 (/opt/rustwide/workdir/pbft-core) [INFO] [stdout] warning: field `sequence` is never read [INFO] [stdout] --> pbft-core/src/message_store.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | Null { sequence: u64 }, [INFO] [stdout] | ---- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sequence` is never read [INFO] [stdout] --> pbft-core/src/pbft_state.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 163 | pub struct CheckpointConsensusState { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] 164 | pub digest: CheckpointDigest, [INFO] [stdout] 165 | pub sequence: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/lib.rs:405:12 [INFO] [stdout] | [INFO] [stdout] 400 | pub fn new(message: T, keypair: &ed25519_dalek::Keypair) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 406 | | message, [INFO] [stdout] 407 | | signature, [INFO] [stdout] 408 | | pub_key: keypair.public.to_bytes(), [INFO] [stdout] 409 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/lib.rs:425:12 [INFO] [stdout] | [INFO] [stdout] 425 | Ok(pub_key.verify(serialized.as_bytes(), signature).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 83 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | client: reqwest::Client::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:259:26 [INFO] [stdout] | [INFO] [stdout] 251 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let self_id = self.node_self_id; [INFO] [stdout] 253 | let keypair = self.keypair.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:282:26 [INFO] [stdout] | [INFO] [stdout] 281 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 283 | | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:283:91 [INFO] [stdout] | [INFO] [stdout] 281 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Box::pin(async move { [INFO] [stdout] 283 | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:295:26 [INFO] [stdout] | [INFO] [stdout] 294 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 296 | | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] 297 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:296:91 [INFO] [stdout] | [INFO] [stdout] 294 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Box::pin(async move { [INFO] [stdout] 296 | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 25 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | ) -> Result { [INFO] [stdout] 27 | let keypair = Arc::new(config.node_config.get_keypair()?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | let broadcaster = Arc::new(Broadcaster::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let pbft_executor = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | pbft_executor, [INFO] [stdout] 40 | | broadcaster, [INFO] [stdout] 41 | | nodes_config: config.node_config, [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sequence` is never read [INFO] [stdout] --> pbft-core/src/message_store.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 14 | Null { sequence: u64 }, [INFO] [stdout] | ---- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `sequence` is never read [INFO] [stdout] --> pbft-core/src/pbft_state.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 163 | pub struct CheckpointConsensusState { [INFO] [stdout] | ------------------------ field in this struct [INFO] [stdout] 164 | pub digest: CheckpointDigest, [INFO] [stdout] 165 | pub sequence: u64, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | event_tx: tx.clone(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | event_rx: Arc::new(Mutex::new(Some(rx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | backup_queue: backup_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:123:24 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | backup_rx: Arc::new(Mutex::new(Some(backup_rx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | pbft_state: Arc::new(Mutex::new(state)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:235:18 [INFO] [stdout] | [INFO] [stdout] 228 | let tx = self.event_tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:405:15 [INFO] [stdout] | [INFO] [stdout] 379 | let mut state = self.pbft_state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | let timer = state.timer.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | match self.initiate_view_change(&mut state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_tests.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 46 | let keypair = Arc::new(config.node_config.get_keypair().unwrap()); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | let state_machine = Arc::new(RwLock::new(state_machine::InMemoryKVStore::new())); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | ( [INFO] [stdout] 49 | / PbftExecutor::new( [INFO] [stdout] 50 | | config, [INFO] [stdout] 51 | | keypair, [INFO] [stdout] 52 | | state_machine.clone(), [INFO] [stdout] 53 | | Arc::new(NoopBroadcast {}), [INFO] [stdout] 54 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/lib.rs:405:12 [INFO] [stdout] | [INFO] [stdout] 400 | pub fn new(message: T, keypair: &ed25519_dalek::Keypair) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 406 | | message, [INFO] [stdout] 407 | | signature, [INFO] [stdout] 408 | | pub_key: keypair.public.to_bytes(), [INFO] [stdout] 409 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/lib.rs:425:12 [INFO] [stdout] | [INFO] [stdout] 425 | Ok(pub_key.verify(serialized.as_bytes(), signature).is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 83 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | client: reqwest::Client::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:259:26 [INFO] [stdout] | [INFO] [stdout] 251 | let client = self.client.clone(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 252 | let self_id = self.node_self_id; [INFO] [stdout] 253 | let keypair = self.keypair.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:282:26 [INFO] [stdout] | [INFO] [stdout] 281 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 283 | | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] 284 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:283:91 [INFO] [stdout] | [INFO] [stdout] 281 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 282 | Box::pin(async move { [INFO] [stdout] 283 | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:295:26 [INFO] [stdout] | [INFO] [stdout] 294 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Box::pin(async move { [INFO] [stdout] | __________________________^ [INFO] [stdout] 296 | | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] 297 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/broadcast.rs:296:91 [INFO] [stdout] | [INFO] [stdout] 294 | |client, msg, url, self_id, keypair| { [INFO] [stdout] | ------ ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Box::pin(async move { [INFO] [stdout] 296 | Broadcaster::send_with_retires(client, self_id, &keypair, &msg, &url).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 25 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | ) -> Result { [INFO] [stdout] 27 | let keypair = Arc::new(config.node_config.get_keypair()?); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | [INFO] [stdout] 29 | let broadcaster = Arc::new(Broadcaster::new( [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | let pbft_executor = [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 39 | | pbft_executor, [INFO] [stdout] 40 | | broadcaster, [INFO] [stdout] 41 | | nodes_config: config.node_config, [INFO] [stdout] 42 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | event_tx: tx.clone(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:120:23 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | event_rx: Arc::new(Mutex::new(Some(rx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:122:27 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | backup_queue: backup_tx.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:123:24 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | backup_rx: Arc::new(Mutex::new(Some(backup_rx))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:125:25 [INFO] [stdout] | [INFO] [stdout] 105 | keypair: Arc, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | state_machine: Arc>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | broadcaster: Arc, [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | ) -> Self { [INFO] [stdout] 109 | let (tx, rx) = tokio::sync::mpsc::channel(10000); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | let state = PbftState::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let (backup_tx, backup_rx) = tokio::sync::mpsc::unbounded_channel(); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 125 | pbft_state: Arc::new(Mutex::new(state)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:235:18 [INFO] [stdout] | [INFO] [stdout] 228 | let tx = self.event_tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> pbft-core/src/pbft_executor.rs:405:15 [INFO] [stdout] | [INFO] [stdout] 379 | let mut state = self.pbft_state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 388 | let timer = state.timer.take().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 405 | match self.initiate_view_change(&mut state) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pbft-core` (lib test) due to 18 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 16 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pbft-core` (lib) due to 17 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "63084339a5b784beb13afd15e16f81f2623dfb725428606b01f55c544036c4a7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63084339a5b784beb13afd15e16f81f2623dfb725428606b01f55c544036c4a7", kill_on_drop: false }` [INFO] [stdout] 63084339a5b784beb13afd15e16f81f2623dfb725428606b01f55c544036c4a7