[INFO] cloning repository https://github.com/Superchig/rolf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Superchig/rolf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuperchig%2Frolf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuperchig%2Frolf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6548340cd00592544b275bc7381982e80954f513 [INFO] checking Superchig/rolf/6548340cd00592544b275bc7381982e80954f513 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuperchig%2Frolf" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Superchig/rolf on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Superchig/rolf [INFO] finished tweaking git repo https://github.com/Superchig/rolf [INFO] tweaked toml for git repo https://github.com/Superchig/rolf written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Superchig/rolf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97cd71c5d492ff37be03b7f9ebde88f044654078086022477e60f12888e75074 [INFO] running `Command { std: "docker" "start" "-a" "97cd71c5d492ff37be03b7f9ebde88f044654078086022477e60f12888e75074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97cd71c5d492ff37be03b7f9ebde88f044654078086022477e60f12888e75074", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97cd71c5d492ff37be03b7f9ebde88f044654078086022477e60f12888e75074", kill_on_drop: false }` [INFO] [stdout] 97cd71c5d492ff37be03b7f9ebde88f044654078086022477e60f12888e75074 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8ac205f7c888174a06e0dd11fbfeee3cd3706265c378ba6324e289bc2e94491f [INFO] running `Command { std: "docker" "start" "-a" "8ac205f7c888174a06e0dd11fbfeee3cd3706265c378ba6324e289bc2e94491f", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling signal-hook v0.3.9 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking rolf-parser v0.1.0 (/opt/rustwide/workdir/rolf-parser) [INFO] [stderr] Compiling nanoserde-derive v0.1.18 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking bytemuck v1.7.0 [INFO] [stderr] Checking whoami v1.2.1 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking gif v0.11.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking which v4.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking nanoserde v0.1.29 [INFO] [stderr] Checking signal-hook-mio v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking crossterm v0.20.0 [INFO] [stderr] Checking open v1.7.0 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking rolf-grid v0.1.0 (/opt/rustwide/workdir/rolf-grid) [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rolf-grid/src/lib.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut cell = self.grid.get_mut(x, y); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rolf-grid/src/lib.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | let mut cell = grid.get_mut(x, y); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rolf-grid/src/lib.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut cell = self.grid.get_mut(x, y); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rolf-grid/src/lib.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | let mut cell = self.grid.get_mut(x, y); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rolf-grid/src/lib.rs:95:21 [INFO] [stdout] | [INFO] [stdout] 95 | let mut cell = grid.get_mut(x, y); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> rolf-grid/src/lib.rs:136:13 [INFO] [stdout] | [INFO] [stdout] 136 | let mut cell = self.grid.get_mut(x, y); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rolf-grid/src/lib.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(screen_output: T) -> io::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | output: screen_output, [INFO] [stdout] 34 | | output_buf: vec![], [INFO] [stdout] 35 | | grid: Grid::new(width, height), [INFO] [stdout] ... | [INFO] [stdout] 39 | | last_style: Style::default(), [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> rolf-grid/src/lib.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(screen_output: T) -> io::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 33 | | output: screen_output, [INFO] [stdout] 34 | | output_buf: vec![], [INFO] [stdout] 35 | | grid: Grid::new(width, height), [INFO] [stdout] ... | [INFO] [stdout] 39 | | last_style: Style::default(), [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rolf-grid` (lib) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rolf-grid` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8ac205f7c888174a06e0dd11fbfeee3cd3706265c378ba6324e289bc2e94491f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8ac205f7c888174a06e0dd11fbfeee3cd3706265c378ba6324e289bc2e94491f", kill_on_drop: false }` [INFO] [stdout] 8ac205f7c888174a06e0dd11fbfeee3cd3706265c378ba6324e289bc2e94491f