[INFO] cloning repository https://github.com/SuperCuber/rlox [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SuperCuber/rlox" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuperCuber%2Frlox", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuperCuber%2Frlox'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5ddc3d8b0d7248a0d9c03ed16bdfb4d29cd996c7 [INFO] checking SuperCuber/rlox/5ddc3d8b0d7248a0d9c03ed16bdfb4d29cd996c7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuperCuber%2Frlox" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SuperCuber/rlox on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SuperCuber/rlox [INFO] finished tweaking git repo https://github.com/SuperCuber/rlox [INFO] tweaked toml for git repo https://github.com/SuperCuber/rlox written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SuperCuber/rlox already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e49c9252d1f7a90b94f4d5f672831c0eb79bce8f0445184177c6944d5e324209 [INFO] running `Command { std: "docker" "start" "-a" "e49c9252d1f7a90b94f4d5f672831c0eb79bce8f0445184177c6944d5e324209", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e49c9252d1f7a90b94f4d5f672831c0eb79bce8f0445184177c6944d5e324209", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e49c9252d1f7a90b94f4d5f672831c0eb79bce8f0445184177c6944d5e324209", kill_on_drop: false }` [INFO] [stdout] e49c9252d1f7a90b94f4d5f672831c0eb79bce8f0445184177c6944d5e324209 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f76aaa9855b25440e5546b7fafb8ec91e43b640eb3b580bd0ea9d1d414bd247d [INFO] running `Command { std: "docker" "start" "-a" "f76aaa9855b25440e5546b7fafb8ec91e43b640eb3b580bd0ea9d1d414bd247d", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking unicode-xid v0.2.2 [INFO] [stderr] Compiling anyhow v1.0.54 [INFO] [stderr] Checking encode_instruction v0.1.0 (/opt/rustwide/workdir/encode_instruction) [INFO] [stderr] Checking quote v1.0.15 [INFO] [stderr] Checking encode_instruction_derive v0.1.0 (/opt/rustwide/workdir/encode_instruction/encode_instruction_derive) [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking bytecode v0.1.0 (/opt/rustwide/workdir/bytecode) [INFO] [stdout] warning: associated items `new`, `write_code`, and `add_constant` are never used [INFO] [stdout] --> bytecode/src/chunk.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Chunk { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 12 | pub fn new() -> Chunk { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn write_code(&mut self, instruction: OpCode, line: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn add_constant(&mut self, constant: Value) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Compiler` is never constructed [INFO] [stdout] --> bytecode/src/compiler.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | struct Compiler {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> bytecode/src/compiler.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 34 | impl Compiler { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 35 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Boolean` and `Nil` are never constructed [INFO] [stdout] --> bytecode/src/scanner.rs:279:5 [INFO] [stdout] | [INFO] [stdout] 276 | pub enum Literal { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 279 | Boolean(bool), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 280 | Nil, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Literal` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_statement_start` is never used [INFO] [stdout] --> bytecode/src/scanner.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 283 | impl Token { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 303 | pub fn is_statement_start(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Compile` and `Runtime` are never constructed [INFO] [stdout] --> bytecode/src/vm.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 94 | pub enum VMError { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 95 | Compile, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 96 | Runtime, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `write_code`, and `add_constant` are never used [INFO] [stdout] --> bytecode/src/chunk.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl Chunk { [INFO] [stdout] | ---------- associated items in this implementation [INFO] [stdout] 12 | pub fn new() -> Chunk { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn write_code(&mut self, instruction: OpCode, line: usize) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn add_constant(&mut self, constant: Value) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Compiler` is never constructed [INFO] [stdout] --> bytecode/src/compiler.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 32 | struct Compiler {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> bytecode/src/compiler.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 34 | impl Compiler { [INFO] [stdout] | ------------- associated function in this implementation [INFO] [stdout] 35 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Boolean` and `Nil` are never constructed [INFO] [stdout] --> bytecode/src/scanner.rs:279:5 [INFO] [stdout] | [INFO] [stdout] 276 | pub enum Literal { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 279 | Boolean(bool), [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 280 | Nil, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Literal` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_statement_start` is never used [INFO] [stdout] --> bytecode/src/scanner.rs:303:12 [INFO] [stdout] | [INFO] [stdout] 283 | impl Token { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 303 | pub fn is_statement_start(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Compile` and `Runtime` are never constructed [INFO] [stdout] --> bytecode/src/vm.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 94 | pub enum VMError { [INFO] [stdout] | ------- variants in this enum [INFO] [stdout] 95 | Compile, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 96 | Runtime, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking rlox v0.1.0 (/opt/rustwide/workdir/interpreter) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/environment.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new_inside(enclosing: Rc>) -> Rc> { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Rc::new(RefCell::new(Environment { [INFO] [stdout] | _________________^ [INFO] [stdout] 21 | | values: BTreeMap::new(), [INFO] [stdout] 22 | | enclosing: Some(enclosing), [INFO] [stdout] 23 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 154 | fn execute_return(&mut self, expression: Option) -> RuntimeResult<()> { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let value = expression [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Err(RuntimeError { [INFO] [stdout] | _____________^ [INFO] [stdout] 160 | | location: (0, 0), [INFO] [stdout] 161 | | value: RuntimeErrorKind::Returning(value), [INFO] [stdout] 162 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 205 | r: ResolvedCodeExpression, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | ) -> RuntimeResult { [INFO] [stdout] 207 | let right = self.evaluate(r)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | [INFO] [stdout] 209 | Ok(match o { [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | UnaryOperator::Minus => Value::Number(-right.into_number().with_location(location)?), [INFO] [stdout] 211 | | UnaryOperator::Not => Value::Boolean(!right.into_boolean().with_location(location)?), [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 325 | fn clock(_interpreter: &mut Interpreter, _args: Vec) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | Ok(Value::Number( [INFO] [stdout] | ________^ [INFO] [stdout] 327 | | SystemTime::now() [INFO] [stdout] 328 | | .duration_since(UNIX_EPOCH) [INFO] [stdout] 329 | | .unwrap() [INFO] [stdout] 330 | | .as_secs_f64(), [INFO] [stdout] 331 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:339:8 [INFO] [stdout] | [INFO] [stdout] 334 | fn debug(_interpreter: &mut Interpreter, args: Vec) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Ok(Value::String(format!("{:?}", value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 79 | let initializer = if self.matches(Token::Symbol(Symbol::Equal)) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Statement::Var(name.value, initializer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 109 | let body = self.block()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | Ok(Statement::Function(name.value, params, body)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 134 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let then_branch = self.statement()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let else_branch = if self.matches(Token::Keyword(Keyword::Else)) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Statement::If( [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | condition, [INFO] [stdout] 146 | | Box::new(then_branch), [INFO] [stdout] 147 | | else_branch.map(Box::new), [INFO] [stdout] 148 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 198 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | self.consume(Token::Symbol(Symbol::RightParen))?; [INFO] [stdout] 200 | let body = self.statement()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | Ok(Statement::While(condition, Box::new(body))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 206 | let value = if self.check(Token::Symbol(Symbol::Semicolon)) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(Statement::Return(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 218 | let value = self.expression()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | self.consume(Token::Symbol(Symbol::Semicolon))?; [INFO] [stdout] 220 | Ok(Statement::Print(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 237 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | self.consume(Token::Symbol(Symbol::Semicolon))?; [INFO] [stdout] 239 | Ok(Statement::Expression(expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:442:12 [INFO] [stdout] | [INFO] [stdout] 422 | callee: CodeExpression, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | let mut arguments = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | Ok(CodeExpression { [INFO] [stdout] | ____________^ [INFO] [stdout] 443 | | location: left_paren.location, [INFO] [stdout] 444 | | value: Expression::Call(Box::new(callee), arguments), [INFO] [stdout] 445 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | fn resolve_statement(&mut self, statement: Statement) -> ResolveResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(match statement { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | Statement::Expression(e) => ResolvedStatement::Expression(self.resolve_expr(e)?), [INFO] [stdout] 45 | | Statement::Function(n, p, b) => { [INFO] [stdout] 46 | | self.resolve_function_statement(n, p, b, FunctionType::Function)? [INFO] [stdout] ... | [INFO] [stdout] 62 | | Statement::If(c, t, e) => self.resolve_if_statement(c, *t, e.map(|e| *e))?, [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 70 | body: Vec, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let res = (|| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(ResolvedStatement::Function(name, params, res?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 122 | condition: CodeExpression, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | then_branch: Statement, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | else_branch: Option, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | ) -> ResolveResult { [INFO] [stdout] 126 | let condition = self.resolve_expr(condition)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let then_b = self.resolve_statement(then_branch)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let else_b = else_branch.map(|b| self.resolve_statement(b)).transpose()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Ok(ResolvedStatement::If( [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | condition, [INFO] [stdout] 131 | | Box::new(then_b), [INFO] [stdout] 132 | | else_b.map(Box::new), [INFO] [stdout] 133 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 139 | expr: Option, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let expr = expr.map(|expr| self.resolve_expr(expr)).transpose()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | self.define(name.clone()); [INFO] [stdout] 144 | Ok(ResolvedStatement::Var(name, expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 149 | condition: CodeExpression, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | body: Statement, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | ) -> ResolveResult { [INFO] [stdout] 152 | let condition = self.resolve_expr(condition)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let body = self.resolve_statement(body)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Ok(ResolvedStatement::While(condition, Box::new(body))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn resolve_expr(&mut self, expr: CodeExpression) -> ResolveResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let loc = expr.location; [INFO] [stdout] 159 | Ok(match expr.value { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | Expression::Binary(l, o, r) => ResolvedCodeExpression { [INFO] [stdout] 161 | | location: loc, [INFO] [stdout] 162 | | value: Expression::Binary( [INFO] [stdout] ... | [INFO] [stdout] 182 | | Expression::Assign(n, e) => self.resolve_assign_expr(loc, n, *e)?, [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 189 | callee: CodeExpression, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | params: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | ) -> ResolveResult { [INFO] [stdout] 192 | let callee = self.resolve_expr(callee)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let params: Result<_, _> = params.into_iter().map(|p| self.resolve_expr(p)).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Ok(ResolvedCodeExpression { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | location, [INFO] [stdout] 196 | | value: Expression::Call(Box::new(callee), params?), [INFO] [stdout] 197 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 234 | expr: CodeExpression, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | ) -> ResolveResult { [INFO] [stdout] 236 | let expr = self.resolve_expr(expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let var = self.resolve_local(name); [INFO] [stdout] 238 | Ok(ResolvedCodeExpression { [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | location, [INFO] [stdout] 240 | | value: Expression::Assign(var, Box::new(expr)), [INFO] [stdout] 241 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlox` (bin "rlox" test) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/environment.rs:20:17 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new_inside(enclosing: Rc>) -> Rc> { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | Rc::new(RefCell::new(Environment { [INFO] [stdout] | _________________^ [INFO] [stdout] 21 | | values: BTreeMap::new(), [INFO] [stdout] 22 | | enclosing: Some(enclosing), [INFO] [stdout] 23 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:159:13 [INFO] [stdout] | [INFO] [stdout] 154 | fn execute_return(&mut self, expression: Option) -> RuntimeResult<()> { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | let value = expression [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | Err(RuntimeError { [INFO] [stdout] | _____________^ [INFO] [stdout] 160 | | location: (0, 0), [INFO] [stdout] 161 | | value: RuntimeErrorKind::Returning(value), [INFO] [stdout] 162 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:209:12 [INFO] [stdout] | [INFO] [stdout] 205 | r: ResolvedCodeExpression, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | ) -> RuntimeResult { [INFO] [stdout] 207 | let right = self.evaluate(r)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | [INFO] [stdout] 209 | Ok(match o { [INFO] [stdout] | ____________^ [INFO] [stdout] 210 | | UnaryOperator::Minus => Value::Number(-right.into_number().with_location(location)?), [INFO] [stdout] 211 | | UnaryOperator::Not => Value::Boolean(!right.into_boolean().with_location(location)?), [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:326:8 [INFO] [stdout] | [INFO] [stdout] 325 | fn clock(_interpreter: &mut Interpreter, _args: Vec) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 326 | Ok(Value::Number( [INFO] [stdout] | ________^ [INFO] [stdout] 327 | | SystemTime::now() [INFO] [stdout] 328 | | .duration_since(UNIX_EPOCH) [INFO] [stdout] 329 | | .unwrap() [INFO] [stdout] 330 | | .as_secs_f64(), [INFO] [stdout] 331 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/interpreter.rs:339:8 [INFO] [stdout] | [INFO] [stdout] 334 | fn debug(_interpreter: &mut Interpreter, args: Vec) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 339 | Ok(Value::String(format!("{:?}", value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 79 | let initializer = if self.matches(Token::Symbol(Symbol::Equal)) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Statement::Var(name.value, initializer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:111:12 [INFO] [stdout] | [INFO] [stdout] 109 | let body = self.block()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | [INFO] [stdout] 111 | Ok(Statement::Function(name.value, params, body)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 134 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | let then_branch = self.statement()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | let else_branch = if self.matches(Token::Keyword(Keyword::Else)) { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | Ok(Statement::If( [INFO] [stdout] | ____________^ [INFO] [stdout] 145 | | condition, [INFO] [stdout] 146 | | Box::new(then_branch), [INFO] [stdout] 147 | | else_branch.map(Box::new), [INFO] [stdout] 148 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:202:12 [INFO] [stdout] | [INFO] [stdout] 198 | let condition = self.expression()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | self.consume(Token::Symbol(Symbol::RightParen))?; [INFO] [stdout] 200 | let body = self.statement()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | [INFO] [stdout] 202 | Ok(Statement::While(condition, Box::new(body))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:213:12 [INFO] [stdout] | [INFO] [stdout] 206 | let value = if self.check(Token::Symbol(Symbol::Semicolon)) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Ok(Statement::Return(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 218 | let value = self.expression()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | self.consume(Token::Symbol(Symbol::Semicolon))?; [INFO] [stdout] 220 | Ok(Statement::Print(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 237 | let expr = self.expression()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | self.consume(Token::Symbol(Symbol::Semicolon))?; [INFO] [stdout] 239 | Ok(Statement::Expression(expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/parser.rs:442:12 [INFO] [stdout] | [INFO] [stdout] 422 | callee: CodeExpression, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | let mut arguments = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 442 | Ok(CodeExpression { [INFO] [stdout] | ____________^ [INFO] [stdout] 443 | | location: left_paren.location, [INFO] [stdout] 444 | | value: Expression::Call(Box::new(callee), arguments), [INFO] [stdout] 445 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:43:12 [INFO] [stdout] | [INFO] [stdout] 42 | fn resolve_statement(&mut self, statement: Statement) -> ResolveResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Ok(match statement { [INFO] [stdout] | ____________^ [INFO] [stdout] 44 | | Statement::Expression(e) => ResolvedStatement::Expression(self.resolve_expr(e)?), [INFO] [stdout] 45 | | Statement::Function(n, p, b) => { [INFO] [stdout] 46 | | self.resolve_function_statement(n, p, b, FunctionType::Function)? [INFO] [stdout] ... | [INFO] [stdout] 62 | | Statement::If(c, t, e) => self.resolve_if_statement(c, *t, e.map(|e| *e))?, [INFO] [stdout] 63 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 70 | body: Vec, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let res = (|| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | Ok(ResolvedStatement::Function(name, params, res?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 122 | condition: CodeExpression, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | then_branch: Statement, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | else_branch: Option, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 125 | ) -> ResolveResult { [INFO] [stdout] 126 | let condition = self.resolve_expr(condition)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | let then_b = self.resolve_statement(then_branch)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 128 | let else_b = else_branch.map(|b| self.resolve_statement(b)).transpose()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | Ok(ResolvedStatement::If( [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | condition, [INFO] [stdout] 131 | | Box::new(then_b), [INFO] [stdout] 132 | | else_b.map(Box::new), [INFO] [stdout] 133 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:144:12 [INFO] [stdout] | [INFO] [stdout] 139 | expr: Option, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let expr = expr.map(|expr| self.resolve_expr(expr)).transpose()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | self.define(name.clone()); [INFO] [stdout] 144 | Ok(ResolvedStatement::Var(name, expr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:154:12 [INFO] [stdout] | [INFO] [stdout] 149 | condition: CodeExpression, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | body: Statement, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 151 | ) -> ResolveResult { [INFO] [stdout] 152 | let condition = self.resolve_expr(condition)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let body = self.resolve_statement(body)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Ok(ResolvedStatement::While(condition, Box::new(body))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:159:12 [INFO] [stdout] | [INFO] [stdout] 157 | pub fn resolve_expr(&mut self, expr: CodeExpression) -> ResolveResult { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let loc = expr.location; [INFO] [stdout] 159 | Ok(match expr.value { [INFO] [stdout] | ____________^ [INFO] [stdout] 160 | | Expression::Binary(l, o, r) => ResolvedCodeExpression { [INFO] [stdout] 161 | | location: loc, [INFO] [stdout] 162 | | value: Expression::Binary( [INFO] [stdout] ... | [INFO] [stdout] 182 | | Expression::Assign(n, e) => self.resolve_assign_expr(loc, n, *e)?, [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:194:12 [INFO] [stdout] | [INFO] [stdout] 189 | callee: CodeExpression, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | params: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | ) -> ResolveResult { [INFO] [stdout] 192 | let callee = self.resolve_expr(callee)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let params: Result<_, _> = params.into_iter().map(|p| self.resolve_expr(p)).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | Ok(ResolvedCodeExpression { [INFO] [stdout] | ____________^ [INFO] [stdout] 195 | | location, [INFO] [stdout] 196 | | value: Expression::Call(Box::new(callee), params?), [INFO] [stdout] 197 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> interpreter/src/resolver.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 234 | expr: CodeExpression, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | ) -> ResolveResult { [INFO] [stdout] 236 | let expr = self.resolve_expr(expr)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | let var = self.resolve_local(name); [INFO] [stdout] 238 | Ok(ResolvedCodeExpression { [INFO] [stdout] | ____________^ [INFO] [stdout] 239 | | location, [INFO] [stdout] 240 | | value: Expression::Assign(var, Box::new(expr)), [INFO] [stdout] 241 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rlox` (bin "rlox") due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "f76aaa9855b25440e5546b7fafb8ec91e43b640eb3b580bd0ea9d1d414bd247d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f76aaa9855b25440e5546b7fafb8ec91e43b640eb3b580bd0ea9d1d414bd247d", kill_on_drop: false }` [INFO] [stdout] f76aaa9855b25440e5546b7fafb8ec91e43b640eb3b580bd0ea9d1d414bd247d