[INFO] cloning repository https://github.com/Super-King-Crimson/Chapter20 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Super-King-Crimson/Chapter20" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuper-King-Crimson%2FChapter20", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuper-King-Crimson%2FChapter20'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a6242c3a4823d1a4c0e4d155a9e3cb9ca0b8c8b5 [INFO] checking Super-King-Crimson/Chapter20/a6242c3a4823d1a4c0e4d155a9e3cb9ca0b8c8b5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSuper-King-Crimson%2FChapter20" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Super-King-Crimson/Chapter20 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Super-King-Crimson/Chapter20 [INFO] finished tweaking git repo https://github.com/Super-King-Crimson/Chapter20 [INFO] tweaked toml for git repo https://github.com/Super-King-Crimson/Chapter20 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Super-King-Crimson/Chapter20 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5aedbdd4ede7fea2e454c5533d85182facce18d934b758918425bad3a67d9ee [INFO] running `Command { std: "docker" "start" "-a" "c5aedbdd4ede7fea2e454c5533d85182facce18d934b758918425bad3a67d9ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5aedbdd4ede7fea2e454c5533d85182facce18d934b758918425bad3a67d9ee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5aedbdd4ede7fea2e454c5533d85182facce18d934b758918425bad3a67d9ee", kill_on_drop: false }` [INFO] [stdout] c5aedbdd4ede7fea2e454c5533d85182facce18d934b758918425bad3a67d9ee [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f22631f869534fbc50d32dc393086b86ee45bdf02accc3bdd713a0fc37fd73c4 [INFO] running `Command { std: "docker" "start" "-a" "f22631f869534fbc50d32dc393086b86ee45bdf02accc3bdd713a0fc37fd73c4", kill_on_drop: false }` [INFO] [stderr] Checking chapter20 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `method` and `version` are never read [INFO] [stdout] --> src/app.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct HttpRequest { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 36 | pub method: HttpMethod, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 37 | pub uri: String, [INFO] [stdout] 38 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tap` is never used [INFO] [stdout] --> src/tap.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait Tap where F: FnOnce(&T) -> () { [INFO] [stdout] | --- method in this trait [INFO] [stdout] 2 | fn tap(self, f: F) -> T; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tap_mut` is never used [INFO] [stdout] --> src/tap.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait TapMut where F: FnOnce(&mut T) { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] 13 | fn tap_mut(self, f: F) -> T; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 89 | .unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | status = HTTP_NOT_FOUND; [INFO] [stdout] 91 | fs::read_to_string(ERR_PAGE.to_string()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn new(reciever: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let thread = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | thread: Some(thread) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:47:39 [INFO] [stdout] | [INFO] [stdout] 41 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let rx: Arc>> = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let workers = (0..num_threads).into_iter().map(move |_| Worker::new(rx.clone())).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | ThreadPool { workers, sender: Some(tx)} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:45:77 [INFO] [stdout] | [INFO] [stdout] 43 | let rx: Arc>> = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let workers = (0..num_threads).into_iter().map(move |_| Worker::new(rx.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `method` and `version` are never read [INFO] [stdout] --> src/app.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct HttpRequest { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 36 | pub method: HttpMethod, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 37 | pub uri: String, [INFO] [stdout] 38 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tap` is never used [INFO] [stdout] --> src/tap.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait Tap where F: FnOnce(&T) -> () { [INFO] [stdout] | --- method in this trait [INFO] [stdout] 2 | fn tap(self, f: F) -> T; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tap_mut` is never used [INFO] [stdout] --> src/tap.rs:13:8 [INFO] [stdout] | [INFO] [stdout] 12 | pub trait TapMut where F: FnOnce(&mut T) { [INFO] [stdout] | ------ method in this trait [INFO] [stdout] 13 | fn tap_mut(self, f: F) -> T; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 89 | .unwrap_or_else(|_| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | status = HTTP_NOT_FOUND; [INFO] [stdout] 91 | fs::read_to_string(ERR_PAGE.to_string()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 12 | fn new(reciever: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | let thread = thread::spawn(move || { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | thread: Some(thread) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:47:39 [INFO] [stdout] | [INFO] [stdout] 41 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | [INFO] [stdout] 43 | let rx: Arc>> = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let workers = (0..num_threads).into_iter().map(move |_| Worker::new(rx.clone())).collect(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | ThreadPool { workers, sender: Some(tx)} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool/mod.rs:45:77 [INFO] [stdout] | [INFO] [stdout] 43 | let rx: Arc>> = Arc::new(Mutex::new(rx)); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | [INFO] [stdout] 45 | let workers = (0..num_threads).into_iter().map(move |_| Worker::new(rx.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `chapter20` (bin "chapter20") due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `chapter20` (bin "chapter20" test) due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f22631f869534fbc50d32dc393086b86ee45bdf02accc3bdd713a0fc37fd73c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f22631f869534fbc50d32dc393086b86ee45bdf02accc3bdd713a0fc37fd73c4", kill_on_drop: false }` [INFO] [stdout] f22631f869534fbc50d32dc393086b86ee45bdf02accc3bdd713a0fc37fd73c4