[INFO] cloning repository https://github.com/StrideStreets/speedicycle [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/StrideStreets/speedicycle" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStrideStreets%2Fspeedicycle", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStrideStreets%2Fspeedicycle'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a8f33b6d393252bcd07e6d868214528d9cac3c64 [INFO] checking StrideStreets/speedicycle/a8f33b6d393252bcd07e6d868214528d9cac3c64 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStrideStreets%2Fspeedicycle" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/StrideStreets/speedicycle on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/StrideStreets/speedicycle [INFO] finished tweaking git repo https://github.com/StrideStreets/speedicycle [INFO] tweaked toml for git repo https://github.com/StrideStreets/speedicycle written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/StrideStreets/speedicycle already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Updating speedicycle v0.1.4 (/workspace/builds/worker-1-tc2/source) -> v0.1.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e40ce550ae8c2811e4adcc36f90be7c5910dc6accf80d25eaa5c09bbef5ce061 [INFO] running `Command { std: "docker" "start" "-a" "e40ce550ae8c2811e4adcc36f90be7c5910dc6accf80d25eaa5c09bbef5ce061", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e40ce550ae8c2811e4adcc36f90be7c5910dc6accf80d25eaa5c09bbef5ce061", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e40ce550ae8c2811e4adcc36f90be7c5910dc6accf80d25eaa5c09bbef5ce061", kill_on_drop: false }` [INFO] [stdout] e40ce550ae8c2811e4adcc36f90be7c5910dc6accf80d25eaa5c09bbef5ce061 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 276708e68bc85b0c11a257629ab780a10063fdf3b0aff0c180448a4ea5af3991 [INFO] running `Command { std: "docker" "start" "-a" "276708e68bc85b0c11a257629ab780a10063fdf3b0aff0c180448a4ea5af3991", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling libm v0.2.7 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking anstyle v1.0.3 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Compiling thiserror v1.0.49 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling syn v2.0.33 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking clap_builder v4.4.4 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking petgraph v0.6.4 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling thiserror-impl v1.0.49 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Checking clap v4.4.4 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking geo-types v0.7.11 [INFO] [stderr] Checking geojson v0.24.1 [INFO] [stderr] Checking speedicycle v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `BoxFuture`, `ok`, and `self` [INFO] [stdout] --> src/lib.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | use futures::future::{self, ok, BoxFuture}; [INFO] [stdout] | ^^^^ ^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::task::Poll` [INFO] [stdout] --> src/lib.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use futures::task::Poll; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::Future` [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use futures::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::FutureExt` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use futures_util::FutureExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::boxed` [INFO] [stdout] --> src/lib.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::boxed; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::Output` [INFO] [stdout] --> src/lib.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use std::process::Output; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BoxFuture`, `ok`, and `self` [INFO] [stdout] --> src/lib.rs:7:23 [INFO] [stdout] | [INFO] [stdout] 7 | use futures::future::{self, ok, BoxFuture}; [INFO] [stdout] | ^^^^ ^^ ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::task::Poll` [INFO] [stdout] --> src/lib.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use futures::task::Poll; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures::Future` [INFO] [stdout] --> src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use futures::Future; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `futures_util::FutureExt` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use futures_util::FutureExt; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::boxed` [INFO] [stdout] --> src/lib.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | use std::boxed; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::process::Output` [INFO] [stdout] --> src/lib.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use std::process::Output; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FindEdge` is never used [INFO] [stdout] --> src/graph/path.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait FindEdge [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 75 | let local_g = g.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | graph: g.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:120:49 [INFO] [stdout] | [INFO] [stdout] 120 | .map(|(i, pred)| (NodeIndex::::from(i.into()), pred)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:130:49 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|(i, cost)| (NodeIndex::::from(i.into()), cost)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:58:60 [INFO] [stdout] | [INFO] [stdout] 58 | if let Some(val) = vals.first().and_then(|val| val.parse::().ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:68:28 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|val| val.parse::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `FindEdge` is never used [INFO] [stdout] --> src/graph/path.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | pub trait FindEdge [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `speedicycle` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:99:16 [INFO] [stdout] | [INFO] [stdout] 75 | let local_g = g.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | graph: g.clone(), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:120:49 [INFO] [stdout] | [INFO] [stdout] 120 | .map(|(i, pred)| (NodeIndex::::from(i.into()), pred)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/graph.rs:130:49 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|(i, cost)| (NodeIndex::::from(i.into()), cost)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:58:60 [INFO] [stdout] | [INFO] [stdout] 58 | if let Some(val) = vals.first().and_then(|val| val.parse::().ok()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io.rs:68:28 [INFO] [stdout] | [INFO] [stdout] 68 | .map(|val| val.parse::().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `speedicycle` (lib) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "276708e68bc85b0c11a257629ab780a10063fdf3b0aff0c180448a4ea5af3991", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "276708e68bc85b0c11a257629ab780a10063fdf3b0aff0c180448a4ea5af3991", kill_on_drop: false }` [INFO] [stdout] 276708e68bc85b0c11a257629ab780a10063fdf3b0aff0c180448a4ea5af3991