[INFO] cloning repository https://github.com/Stigjb/freecell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Stigjb/freecell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStigjb%2Ffreecell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStigjb%2Ffreecell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f07f07eee4c791f630f5eb79371b0aad817cb0ce [INFO] checking Stigjb/freecell/f07f07eee4c791f630f5eb79371b0aad817cb0ce against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStigjb%2Ffreecell" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Stigjb/freecell on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/Stigjb/freecell [INFO] finished tweaking git repo https://github.com/Stigjb/freecell [INFO] tweaked toml for git repo https://github.com/Stigjb/freecell written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Stigjb/freecell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c16fe5205c105b7f8c487888f352fd85715caf7183d9843bd7cf0db8a07daa27 [INFO] running `Command { std: "docker" "start" "-a" "c16fe5205c105b7f8c487888f352fd85715caf7183d9843bd7cf0db8a07daa27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c16fe5205c105b7f8c487888f352fd85715caf7183d9843bd7cf0db8a07daa27", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c16fe5205c105b7f8c487888f352fd85715caf7183d9843bd7cf0db8a07daa27", kill_on_drop: false }` [INFO] [stdout] c16fe5205c105b7f8c487888f352fd85715caf7183d9843bd7cf0db8a07daa27 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3c0ac9d1860d9102167a824209420c90373184241c3e6c7e5c6489fe6635ef2a [INFO] running `Command { std: "docker" "start" "-a" "3c0ac9d1860d9102167a824209420c90373184241c3e6c7e5c6489fe6635ef2a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.30 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.78 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling bumpalo v3.7.1 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.68 [INFO] [stderr] Compiling wasm-bindgen v0.2.78 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Compiling yew v0.18.0 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling boolinator v2.4.0 [INFO] [stderr] Checking cfg-match v0.2.1 [INFO] [stderr] Checking slab v0.4.5 [INFO] [stderr] Checking anymap v0.12.1 [INFO] [stderr] Checking scoped-tls v1.0.0 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking http v0.2.5 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling wasm-bindgen-test-macro v0.3.28 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.78 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling yew-macro v0.18.0 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.78 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.78 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking js-sys v0.3.55 [INFO] [stderr] Checking console_error_panic_hook v0.1.7 [INFO] [stderr] Checking web-sys v0.3.55 [INFO] [stderr] Checking wasm-bindgen-futures v0.4.28 [INFO] [stderr] Checking wasm-bindgen-test v0.3.28 [INFO] [stderr] Checking gloo-events v0.1.1 [INFO] [stderr] Checking gloo-timers v0.2.1 [INFO] [stderr] Checking gloo-console-timer v0.1.0 [INFO] [stderr] Checking wasm-logger v0.2.0 [INFO] [stderr] Checking gloo-file v0.1.0 [INFO] [stderr] Checking gloo v0.2.1 [INFO] [stderr] Checking freecell v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fetch.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | Failed(FetchError), [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FetchState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 39 | Failed(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | node_ref: NodeRef::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | canvas: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | ctx: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:42:28 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | texture_atlas: FetchState::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 91 | let link = self.link.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let future = async move { [INFO] [stdout] 93 | match fetch_texture_atlas().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fetch.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 20 | fn from(value: serde_json::Error) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | FetchError { [INFO] [stdout] 22 | err: value.to_string().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freecell` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fetch.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | Failed(FetchError), [INFO] [stdout] | ------ ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FetchState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 39 | Failed(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:38:23 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | node_ref: NodeRef::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:39:21 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | canvas: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:40:18 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | ctx: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:42:28 [INFO] [stdout] | [INFO] [stdout] 34 | fn create(_: Self::Properties, link: ComponentLink) -> Self { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let spritesheet = HtmlImageElement::new().expect("Couldn't create new Image"); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | texture_atlas: FetchState::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/comp/freecell.rs:93:19 [INFO] [stdout] | [INFO] [stdout] 91 | let link = self.link.clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | let future = async move { [INFO] [stdout] 93 | match fetch_texture_atlas().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fetch.rs:22:18 [INFO] [stdout] | [INFO] [stdout] 20 | fn from(value: serde_json::Error) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | FetchError { [INFO] [stdout] 22 | err: value.to_string().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `freecell` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3c0ac9d1860d9102167a824209420c90373184241c3e6c7e5c6489fe6635ef2a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c0ac9d1860d9102167a824209420c90373184241c3e6c7e5c6489fe6635ef2a", kill_on_drop: false }` [INFO] [stdout] 3c0ac9d1860d9102167a824209420c90373184241c3e6c7e5c6489fe6635ef2a