[INFO] cloning repository https://github.com/Steve-xmh/denshaded-tools [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Steve-xmh/denshaded-tools" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSteve-xmh%2Fdenshaded-tools", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSteve-xmh%2Fdenshaded-tools'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7da9c1046d96561e839953b6532c7397d23e74e4 [INFO] checking Steve-xmh/denshaded-tools/7da9c1046d96561e839953b6532c7397d23e74e4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSteve-xmh%2Fdenshaded-tools" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Steve-xmh/denshaded-tools on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-2-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Steve-xmh/denshaded-tools [INFO] finished tweaking git repo https://github.com/Steve-xmh/denshaded-tools [INFO] tweaked toml for git repo https://github.com/Steve-xmh/denshaded-tools written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Steve-xmh/denshaded-tools already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc229afae46f8149a93d4b49b73ead474d0799276489377ebd4551bcdc28c4b3 [INFO] running `Command { std: "docker" "start" "-a" "fc229afae46f8149a93d4b49b73ead474d0799276489377ebd4551bcdc28c4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc229afae46f8149a93d4b49b73ead474d0799276489377ebd4551bcdc28c4b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc229afae46f8149a93d4b49b73ead474d0799276489377ebd4551bcdc28c4b3", kill_on_drop: false }` [INFO] [stdout] fc229afae46f8149a93d4b49b73ead474d0799276489377ebd4551bcdc28c4b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4011015f372c96a73c9d443d14459f16bf70dcbf37668b15ec6a1fe7da377f56 [INFO] running `Command { std: "docker" "start" "-a" "4011015f372c96a73c9d443d14459f16bf70dcbf37668b15ec6a1fe7da377f56", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling syn v1.0.68 [INFO] [stderr] Compiling libc v0.2.92 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling encoding_rs v0.8.28 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking denshaded-tools v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `pass` is never read [INFO] [stdout] --> src/kcap.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | pub struct KCAPPackWriter { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 118 | pub pass: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KCAPPackWriter` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | let name = path.clone().to_path_buf().to_string_lossy().to_string(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 62 - let name = path.clone().to_path_buf().to_string_lossy().to_string(); [INFO] [stdout] 62 + let name = path.to_path_buf().to_string_lossy().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pass` is never read [INFO] [stdout] --> src/kcap.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 117 | pub struct KCAPPackWriter { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 118 | pub pass: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `KCAPPackWriter` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kcap.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new>(path: P, pass: &str) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut file = std::fs::File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | file, [INFO] [stdout] 84 | | entries, [INFO] [stdout] 85 | | key_table: create_key_table(pass), [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:62:28 [INFO] [stdout] | [INFO] [stdout] 62 | let name = path.clone().to_path_buf().to_string_lossy().to_string(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 62 - let name = path.clone().to_path_buf().to_string_lossy().to_string(); [INFO] [stdout] 62 + let name = path.to_path_buf().to_string_lossy().to_string(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/kcap.rs:82:12 [INFO] [stdout] | [INFO] [stdout] 69 | pub fn new>(path: P, pass: &str) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut file = std::fs::File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 82 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 83 | | file, [INFO] [stdout] 84 | | entries, [INFO] [stdout] 85 | | key_table: create_key_table(pass), [INFO] [stdout] 86 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `denshaded-tools` (bin "denshaded-tools" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `denshaded-tools` (bin "denshaded-tools") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4011015f372c96a73c9d443d14459f16bf70dcbf37668b15ec6a1fe7da377f56", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4011015f372c96a73c9d443d14459f16bf70dcbf37668b15ec6a1fe7da377f56", kill_on_drop: false }` [INFO] [stdout] 4011015f372c96a73c9d443d14459f16bf70dcbf37668b15ec6a1fe7da377f56