[INFO] cloning repository https://github.com/Sperges/osr-helper [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sperges/osr-helper" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSperges%2Fosr-helper", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSperges%2Fosr-helper'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b84a314d66ec961fbac3ad0a55bea3187e13e312 [INFO] checking Sperges/osr-helper/b84a314d66ec961fbac3ad0a55bea3187e13e312 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSperges%2Fosr-helper" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sperges/osr-helper on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Sperges/osr-helper [INFO] finished tweaking git repo https://github.com/Sperges/osr-helper [INFO] tweaked toml for git repo https://github.com/Sperges/osr-helper written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Sperges/osr-helper already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5685935314f0748ceffc93c8e58e21055191e7f8f5c0e28645d89d0534fd3590 [INFO] running `Command { std: "docker" "start" "-a" "5685935314f0748ceffc93c8e58e21055191e7f8f5c0e28645d89d0534fd3590", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5685935314f0748ceffc93c8e58e21055191e7f8f5c0e28645d89d0534fd3590", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5685935314f0748ceffc93c8e58e21055191e7f8f5c0e28645d89d0534fd3590", kill_on_drop: false }` [INFO] [stdout] 5685935314f0748ceffc93c8e58e21055191e7f8f5c0e28645d89d0534fd3590 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7dda53a11254143f54875ddbe7f6097a225f6c53d5eb7c44fdddcb2590238fc5 [INFO] running `Command { std: "docker" "start" "-a" "7dda53a11254143f54875ddbe7f6097a225f6c53d5eb7c44fdddcb2590238fc5", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Compiling libc v0.2.149 [INFO] [stderr] Compiling serde v1.0.190 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling memchr v2.6.4 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling once_cell v1.18.0 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking globalenv v0.4.2 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking clap_builder v4.4.7 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling serde_derive v1.0.190 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Compiling pest v2.7.5 [INFO] [stderr] Checking clap v4.4.7 [INFO] [stderr] Compiling pest_meta v2.7.5 [INFO] [stderr] Compiling pest_generator v2.7.5 [INFO] [stderr] Compiling pest_derive v2.7.5 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking osr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `literal` is never read [INFO] [stdout] --> src/dice.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 94 | pub struct Dice { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 95 | pub literal: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Dice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dice.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 108 | let expr = Self::expr(&expression)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok(Dice { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | literal: expression.to_string(), [INFO] [stdout] 111 | | expr, [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dice.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 130 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | lhs: Box::new(lhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dice.rs:152:26 [INFO] [stdout] | [INFO] [stdout] 130 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | rhs: Box::new(rhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 68 | let mut map: HashMap = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Tables { map, first_table }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 104 | let line_items = Self::parse_line_items( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let sub_tables = if let Some(pair) = pairs.next() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(Table { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | name, [INFO] [stdout] 117 | | line_items, [INFO] [stdout] 118 | | sub_tables, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 132 | let mut sections = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let mut references = HashSet::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(LineItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 148 | | weight, [INFO] [stdout] 149 | | sections, [INFO] [stdout] 150 | | _references: references, [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `literal` is never read [INFO] [stdout] --> src/dice.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 94 | pub struct Dice { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 95 | pub literal: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Dice` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dice.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 108 | let expr = Self::expr(&expression)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok(Dice { [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | literal: expression.to_string(), [INFO] [stdout] 111 | | expr, [INFO] [stdout] 112 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dice.rs:150:26 [INFO] [stdout] | [INFO] [stdout] 130 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | lhs: Box::new(lhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dice.rs:152:26 [INFO] [stdout] | [INFO] [stdout] 130 | .map_infix(|lhs, op, rhs| { [INFO] [stdout] | --- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | rhs: Box::new(rhs), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 68 | let mut map: HashMap = HashMap::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Tables { map, first_table }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 104 | let line_items = Self::parse_line_items( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let sub_tables = if let Some(pair) = pairs.next() { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(Table { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | name, [INFO] [stdout] 117 | | line_items, [INFO] [stdout] 118 | | sub_tables, [INFO] [stdout] 119 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 132 | let mut sections = Vec::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | let mut references = HashSet::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(LineItem { [INFO] [stdout] | ____________^ [INFO] [stdout] 148 | | weight, [INFO] [stdout] 149 | | sections, [INFO] [stdout] 150 | | _references: references, [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osr` (bin "osr") due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `osr` (bin "osr" test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "7dda53a11254143f54875ddbe7f6097a225f6c53d5eb7c44fdddcb2590238fc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7dda53a11254143f54875ddbe7f6097a225f6c53d5eb7c44fdddcb2590238fc5", kill_on_drop: false }` [INFO] [stdout] 7dda53a11254143f54875ddbe7f6097a225f6c53d5eb7c44fdddcb2590238fc5