[INFO] cloning repository https://github.com/SolarLiner/octave.rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SolarLiner/octave.rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSolarLiner%2Foctave.rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSolarLiner%2Foctave.rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 93442d450a82b0ba6933f1c0a52459be764acd7c [INFO] checking SolarLiner/octave.rs/93442d450a82b0ba6933f1c0a52459be764acd7c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSolarLiner%2Foctave.rs" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SolarLiner/octave.rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SolarLiner/octave.rs [INFO] finished tweaking git repo https://github.com/SolarLiner/octave.rs [INFO] tweaked toml for git repo https://github.com/SolarLiner/octave.rs written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SolarLiner/octave.rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e7614ca1c71d72c123eb6a6cd2a765a02fc4ae59a79f3ce68df5089dd2de96a [INFO] running `Command { std: "docker" "start" "-a" "9e7614ca1c71d72c123eb6a6cd2a765a02fc4ae59a79f3ce68df5089dd2de96a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e7614ca1c71d72c123eb6a6cd2a765a02fc4ae59a79f3ce68df5089dd2de96a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e7614ca1c71d72c123eb6a6cd2a765a02fc4ae59a79f3ce68df5089dd2de96a", kill_on_drop: false }` [INFO] [stdout] 9e7614ca1c71d72c123eb6a6cd2a765a02fc4ae59a79f3ce68df5089dd2de96a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5792ea9dde275d837688cc911aa0db5c6b3ba6a14dc8b2773971ef0dbc060421 [INFO] running `Command { std: "docker" "start" "-a" "5792ea9dde275d837688cc911aa0db5c6b3ba6a14dc8b2773971ef0dbc060421", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.120 [INFO] [stderr] Compiling serde v1.0.120 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking tinyvec v1.1.0 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking form_urlencoded v1.0.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.16 [INFO] [stderr] Compiling const-random-macro v0.1.13 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking const-random v0.1.13 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking pin-project-lite v0.1.11 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking flurry v0.3.1 [INFO] [stderr] Checking octave-typesystem v0.1.0 (/opt/rustwide/workdir/octave-typesystem) [INFO] [stderr] Checking dashmap v3.11.10 [INFO] [stderr] Checking tower-service v0.3.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling serde_repr v0.1.6 [INFO] [stderr] Compiling thiserror-impl v1.0.23 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling auto_impl v0.4.1 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Compiling tower-lsp-macros v0.3.0 [INFO] [stderr] Checking tokio v0.2.24 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking thiserror v1.0.23 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking url v2.2.0 [INFO] [stderr] Checking lsp-types v0.81.0 [INFO] [stderr] Checking octave-parser v0.1.0 (/opt/rustwide/workdir/octave-parser) [INFO] [stderr] Checking lsp-textdocument v0.1.0 (/opt/rustwide/workdir/lsp-textdocument) [INFO] [stderr] Checking tower-lsp v0.13.3 [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> octave-parser/src/ast.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Position` [INFO] [stdout] --> octave-parser/src/parser.rs:221:22 [INFO] [stdout] | [INFO] [stdout] 221 | node::{Node, Position}, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> octave-parser/src/ast.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn map U>(self, f: F) -> Node { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | data: f(self.data), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn map_data U>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | self.map(|data| data.map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn and_then Result>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.map(|data| data.and_then(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn map_data U>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | self.map(|data| match data { [INFO] [stdout] | __________________^ [INFO] [stdout] 111 | | None => Err("Unexpected end of file".to_string()), [INFO] [stdout] 112 | | Some(x) => Ok(f(x)), [INFO] [stdout] 113 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn and_then Option>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | self.map(|data| data.and_then(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/value.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn from_vecs(data: Vec>) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | data: data.into_iter().flat_map(|v| v.into_iter()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/value.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn map U>(self, f: F) -> Matrix { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | data: self.data.into_iter().map(f).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | data: Statement::Error(format!( [INFO] [stdout] | ___________________^ [INFO] [stdout] 26 | | "Parse error: {}", [INFO] [stdout] 27 | | match e.variant { [INFO] [stdout] 28 | | pest::error::ErrorVariant::CustomError { message } => message, [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|v| Expr::Matrix(Matrix::from_vecs(vec![vec![v]]))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 123 | |lhs: Node, op: Pair, rhs: Node| Node { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | span: union(lhs.span.clone(), rhs.span.clone()), [INFO] [stdout] 125 | data: match get_op(op.as_rule()) { [INFO] [stdout] | _______________________^ [INFO] [stdout] 126 | | Ok(op) => Expr::Op(op, lhs.map(Box::new), rhs.map(Box::new)), [INFO] [stdout] 127 | | Err(rule) => Expr::Error(format!("Unexpected {:?}", rule)), [INFO] [stdout] 128 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 190 | fn union(p0: Range, p1: Range) -> Range { [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | use std::cmp::{max, min}; [INFO] [stdout] 192 | min(p0.start, p1.start)..max(p0.end, p1.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:192:30 [INFO] [stdout] | [INFO] [stdout] 190 | fn union(p0: Range, p1: Range) -> Range { [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | use std::cmp::{max, min}; [INFO] [stdout] 192 | min(p0.start, p1.start)..max(p0.end, p1.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/ast.rs:100:43 [INFO] [stdout] | [INFO] [stdout] 100 | ... .and_then(|n| n.type_of(ctx.clone()).simple_type()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/ast.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn type_of(&self, ctx: HashMapRef) -> Type { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | .or_else(|| e.type_of(ctx).simple_type()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `octave-parser` (lib) due to 15 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `actual_vals` [INFO] [stdout] --> octave-parser/src/parser.rs:317:13 [INFO] [stdout] | [INFO] [stdout] 317 | let actual_vals = if let Statement::Block(v) = actual.deref() { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_actual_vals` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:66:19 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn map U>(self, f: F) -> Node { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | data: f(self.data), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:89:18 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn map_data U>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | self.map(|data| data.map(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:92:18 [INFO] [stdout] | [INFO] [stdout] 91 | pub fn and_then Result>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.map(|data| data.and_then(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:110:18 [INFO] [stdout] | [INFO] [stdout] 109 | pub fn map_data U>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | self.map(|data| match data { [INFO] [stdout] | __________________^ [INFO] [stdout] 111 | | None => Err("Unexpected end of file".to_string()), [INFO] [stdout] 112 | | Some(x) => Ok(f(x)), [INFO] [stdout] 113 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/node.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 115 | pub fn and_then Option>(self, f: F) -> Node> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | self.map(|data| data.and_then(f)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/value.rs:13:19 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn from_vecs(data: Vec>) -> Self { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 13 | data: data.into_iter().flat_map(|v| v.into_iter()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/value.rs:52:19 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn map U>(self, f: F) -> Matrix { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | data: self.data.into_iter().map(f).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | data: Statement::Error(format!( [INFO] [stdout] | ___________________^ [INFO] [stdout] 26 | | "Parse error: {}", [INFO] [stdout] 27 | | match e.variant { [INFO] [stdout] 28 | | pest::error::ErrorVariant::CustomError { message } => message, [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | .map(|v| Expr::Matrix(Matrix::from_vecs(vec![vec![v]]))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 123 | |lhs: Node, op: Pair, rhs: Node| Node { [INFO] [stdout] | --------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | span: union(lhs.span.clone(), rhs.span.clone()), [INFO] [stdout] 125 | data: match get_op(op.as_rule()) { [INFO] [stdout] | _______________________^ [INFO] [stdout] 126 | | Ok(op) => Expr::Op(op, lhs.map(Box::new), rhs.map(Box::new)), [INFO] [stdout] 127 | | Err(rule) => Expr::Error(format!("Unexpected {:?}", rule)), [INFO] [stdout] 128 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 190 | fn union(p0: Range, p1: Range) -> Range { [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | use std::cmp::{max, min}; [INFO] [stdout] 192 | min(p0.start, p1.start)..max(p0.end, p1.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/parser.rs:192:30 [INFO] [stdout] | [INFO] [stdout] 190 | fn union(p0: Range, p1: Range) -> Range { [INFO] [stdout] | ------------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | use std::cmp::{max, min}; [INFO] [stdout] 192 | min(p0.start, p1.start)..max(p0.end, p1.end) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/ast.rs:100:43 [INFO] [stdout] | [INFO] [stdout] 100 | ... .and_then(|n| n.type_of(ctx.clone()).simple_type()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> octave-parser/src/ast.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 89 | pub fn type_of(&self, ctx: HashMapRef) -> Type { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | .or_else(|| e.type_of(ctx).simple_type()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `octave-parser` (lib test) due to 15 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5792ea9dde275d837688cc911aa0db5c6b3ba6a14dc8b2773971ef0dbc060421", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5792ea9dde275d837688cc911aa0db5c6b3ba6a14dc8b2773971ef0dbc060421", kill_on_drop: false }` [INFO] [stdout] 5792ea9dde275d837688cc911aa0db5c6b3ba6a14dc8b2773971ef0dbc060421