[INFO] cloning repository https://github.com/SnowyMouse/shuckie-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SnowyMouse/shuckie-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnowyMouse%2Fshuckie-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnowyMouse%2Fshuckie-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4b2c07d7f6d678afc19c1b9e5442dac176e8d1f [INFO] checking SnowyMouse/shuckie-server/c4b2c07d7f6d678afc19c1b9e5442dac176e8d1f against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnowyMouse%2Fshuckie-server" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SnowyMouse/shuckie-server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SnowyMouse/shuckie-server [INFO] finished tweaking git repo https://github.com/SnowyMouse/shuckie-server [INFO] tweaked toml for git repo https://github.com/SnowyMouse/shuckie-server written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SnowyMouse/shuckie-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1cb54817932e955cd7947b8eb115186a481f340c1abc4e13f6f42c3bae2db954 [INFO] running `Command { std: "docker" "start" "-a" "1cb54817932e955cd7947b8eb115186a481f340c1abc4e13f6f42c3bae2db954", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1cb54817932e955cd7947b8eb115186a481f340c1abc4e13f6f42c3bae2db954", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1cb54817932e955cd7947b8eb115186a481f340c1abc4e13f6f42c3bae2db954", kill_on_drop: false }` [INFO] [stdout] 1cb54817932e955cd7947b8eb115186a481f340c1abc4e13f6f42c3bae2db954 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f604ed5f3a50c700c5a49b59562938459c376bb57846997269e2d77110de21cd [INFO] running `Command { std: "docker" "start" "-a" "f604ed5f3a50c700c5a49b59562938459c376bb57846997269e2d77110de21cd", kill_on_drop: false }` [INFO] [stderr] Checking shuckie-server v0.1.0 (/opt/rustwide/workdir/shuckie-server) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> shuckie-server/src/server.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(udp_addr: A, tcp_addr: B) -> Result { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let udp_socket = io(UdpSocket::bind(udp_addr))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let tcp_listener = io(TcpListener::bind(tcp_addr))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | server: Arc::new(Mutex::new(Box::pin(ServerImpl { [INFO] [stdout] 184 | | udp_socket, [INFO] [stdout] 185 | | tcp_listener, [INFO] [stdout] ... | [INFO] [stdout] 191 | | }))) [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> shuckie-server/src/server.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 264 | fn accept_client(&mut self, stream: TcpStream, addr: SocketAddr) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | self.peers.push(Peer { [INFO] [stdout] | _________________________^ [INFO] [stdout] 275 | | stream, [INFO] [stdout] 276 | | addr, [INFO] [stdout] 277 | | buffer: Vec::with_capacity(DEFAULT_BUFFER_CAPACITY), [INFO] [stdout] ... | [INFO] [stdout] 281 | | address_validation_callback: AddressValidationCallback::Rust(address_validation_callback_no_op) [INFO] [stdout] 282 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> shuckie-server/src/server.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 175 | pub fn new(udp_addr: A, tcp_addr: B) -> Result { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let udp_socket = io(UdpSocket::bind(udp_addr))?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | let tcp_listener = io(TcpListener::bind(tcp_addr))?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Ok(Server { [INFO] [stdout] | ____________^ [INFO] [stdout] 183 | | server: Arc::new(Mutex::new(Box::pin(ServerImpl { [INFO] [stdout] 184 | | udp_socket, [INFO] [stdout] 185 | | tcp_listener, [INFO] [stdout] ... | [INFO] [stdout] 191 | | }))) [INFO] [stdout] 192 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> shuckie-server/src/server.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 264 | fn accept_client(&mut self, stream: TcpStream, addr: SocketAddr) { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | self.peers.push(Peer { [INFO] [stdout] | _________________________^ [INFO] [stdout] 275 | | stream, [INFO] [stdout] 276 | | addr, [INFO] [stdout] 277 | | buffer: Vec::with_capacity(DEFAULT_BUFFER_CAPACITY), [INFO] [stdout] ... | [INFO] [stdout] 281 | | address_validation_callback: AddressValidationCallback::Rust(address_validation_callback_no_op) [INFO] [stdout] 282 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shuckie-server` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `shuckie-server` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "f604ed5f3a50c700c5a49b59562938459c376bb57846997269e2d77110de21cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f604ed5f3a50c700c5a49b59562938459c376bb57846997269e2d77110de21cd", kill_on_drop: false }` [INFO] [stdout] f604ed5f3a50c700c5a49b59562938459c376bb57846997269e2d77110de21cd