[INFO] updating cached repository https://github.com/SnoozeTime/twengine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 90121f6e6d6bf491ea816f8c949fc4db0ae31382 [INFO] checking SnoozeTime/twengine/90121f6e6d6bf491ea816f8c949fc4db0ae31382 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnoozeTime%2Ftwengine" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SnoozeTime/twengine on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SnoozeTime/twengine [INFO] finished tweaking git repo https://github.com/SnoozeTime/twengine [INFO] tweaked toml for git repo https://github.com/SnoozeTime/twengine written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SnoozeTime/twengine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 843a91e1afeeaea3c8ac9e59e21d3322a0b1bef45ddd3ac1901c8d6576e666af [INFO] running `Command { std: "docker" "start" "-a" "843a91e1afeeaea3c8ac9e59e21d3322a0b1bef45ddd3ac1901c8d6576e666af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "843a91e1afeeaea3c8ac9e59e21d3322a0b1bef45ddd3ac1901c8d6576e666af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "843a91e1afeeaea3c8ac9e59e21d3322a0b1bef45ddd3ac1901c8d6576e666af", kill_on_drop: false }` [INFO] [stdout] 843a91e1afeeaea3c8ac9e59e21d3322a0b1bef45ddd3ac1901c8d6576e666af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 864cb18e33009c649e59a559b08d4860aa844068f5e3ab0f0b6b514461f03052 [INFO] running `Command { std: "docker" "start" "-a" "864cb18e33009c649e59a559b08d4860aa844068f5e3ab0f0b6b514461f03052", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.14 [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling gio v0.5.1 [INFO] [stderr] Compiling proc-macro2 v0.4.24 [INFO] [stderr] Compiling gdk-pixbuf v0.5.0 [INFO] [stderr] Compiling cairo-rs v0.5.0 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling cfg-if v0.1.6 [INFO] [stderr] Checking fragile v0.3.0 [INFO] [stderr] Compiling gdk v0.9.0 [INFO] [stderr] Compiling ryu v0.2.7 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Compiling sdl2-sys v0.32.5 [INFO] [stderr] Checking rand_xorshift v0.1.0 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Compiling gtk v0.5.0 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Compiling glib-sys v0.7.0 [INFO] [stderr] Compiling gobject-sys v0.7.0 [INFO] [stderr] Compiling gio-sys v0.7.0 [INFO] [stderr] Compiling cairo-sys-rs v0.7.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.7.0 [INFO] [stderr] Compiling pango-sys v0.7.0 [INFO] [stderr] Compiling gdk-sys v0.7.0 [INFO] [stderr] Compiling atk-sys v0.7.0 [INFO] [stderr] Compiling gtk-sys v0.7.0 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Compiling syn v0.15.23 [INFO] [stderr] Checking glib v0.6.1 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking sdl2 v0.32.1 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking pango v0.5.0 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking sdl2anim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `SWITCH_TO_ADD` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | SWITCH_TO_ADD, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `SwitchToAdd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SWITCH_TO_SELECT` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | SWITCH_TO_SELECT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `SwitchToSelect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SWITCH_TO_STATIC` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | SWITCH_TO_STATIC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `SwitchToStatic` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ADD_RECT` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | ADD_RECT, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `AddRect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ADD_STATIC` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | ADD_STATIC, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `AddStatic` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `assert_eq_delta` [INFO] [stdout] --> src/math.rs:53:14 [INFO] [stdout] | [INFO] [stdout] 53 | macro_rules! assert_eq_delta ( [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SWITCH_TO_ADD` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | SWITCH_TO_ADD, [INFO] [stdout] | ^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `SwitchToAdd` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:14:41 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new() -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new() -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SWITCH_TO_SELECT` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | SWITCH_TO_SELECT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `SwitchToSelect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SWITCH_TO_STATIC` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | SWITCH_TO_STATIC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: convert the identifier to upper camel case: `SwitchToStatic` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ADD_RECT` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | ADD_RECT, [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to upper camel case: `AddRect` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `ADD_STATIC` should have an upper camel case name [INFO] [stdout] --> src/editor.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | ADD_STATIC, [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case: `AddStatic` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/lib.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/context.rs:14:41 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new() -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new() -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_buttons` [INFO] [stdout] --> src/editor.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let old_buttons = &self.prev_buttons - &buttons; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_buttons` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `old_buttons` [INFO] [stdout] --> src/editor.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 122 | let old_buttons = &self.prev_buttons - &buttons; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_old_buttons` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `textures` [INFO] [stdout] --> src/game.rs:70:49 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn render(&self, context: &mut Context, textures: &TextureCache) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_textures` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `textures` [INFO] [stdout] --> src/game.rs:70:49 [INFO] [stdout] | [INFO] [stdout] 70 | pub fn render(&self, context: &mut Context, textures: &TextureCache) { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_textures` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/physics.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | for (i, j) in to_resolve { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/physics.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | for (i, j) in to_resolve { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `video_subsystem` is never read [INFO] [stdout] --> src/context.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Context { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 6 | pub sdl_context: Sdl, [INFO] [stdout] 7 | video_subsystem: VideoSubsystem, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 15 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let font_context = sdl2::ttf::init()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let window = video_subsystem.window("Mouse", 800, 600) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let canvas = window.into_canvas().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | Ok(Context { sdl_context, video_subsystem, canvas, font_context,}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `toLocal` should have a snake case name [INFO] [stdout] --> src/core.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn toLocal(&self, global_pos: Vector2d) -> Vector2d { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `to_local` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 20 | fn add(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Vector2d { [INFO] [stdout] 22 | x: self.x + other.x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 20 | fn add(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | y: self.y + other.y, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 32 | fn sub(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Vector2d { [INFO] [stdout] 34 | x: self.x - other.x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 32 | fn sub(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | y: self.y - other.y, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 44 | fn mul(self, rhs: usize) -> Vector2d { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Vector2d { [INFO] [stdout] 46 | x: self.x * rhs, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 44 | fn mul(self, rhs: usize) -> Vector2d { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | y: self.y * rhs, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/physics.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, PartialEq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 14 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/physics.rs:90:14 [INFO] [stdout] | [INFO] [stdout] 90 | for (i, j) in to_resolve { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/physics.rs:90:17 [INFO] [stdout] | [INFO] [stdout] 90 | for (i, j) in to_resolve { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdl2anim` (lib) due to 9 previous errors; 14 warnings emitted [INFO] [stdout] warning: field `video_subsystem` is never read [INFO] [stdout] --> src/context.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct Context { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 6 | pub sdl_context: Sdl, [INFO] [stdout] 7 | video_subsystem: VideoSubsystem, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 15 | let sdl_context = sdl2::init()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let video_subsystem = sdl_context.video()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | let font_context = sdl2::ttf::init()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | let window = video_subsystem.window("Mouse", 800, 600) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | let canvas = window.into_canvas().build()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | Ok(Context { sdl_context, video_subsystem, canvas, font_context,}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `toLocal` should have a snake case name [INFO] [stdout] --> src/core.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn toLocal(&self, global_pos: Vector2d) -> Vector2d { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `to_local` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:22:16 [INFO] [stdout] | [INFO] [stdout] 20 | fn add(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | Vector2d { [INFO] [stdout] 22 | x: self.x + other.x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 20 | fn add(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | y: self.y + other.y, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:34:16 [INFO] [stdout] | [INFO] [stdout] 32 | fn sub(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | Vector2d { [INFO] [stdout] 34 | x: self.x - other.x, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:35:16 [INFO] [stdout] | [INFO] [stdout] 32 | fn sub(self, other: Vector2d) -> Vector2d { [INFO] [stdout] | ---- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | y: self.y - other.y, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:46:16 [INFO] [stdout] | [INFO] [stdout] 44 | fn mul(self, rhs: usize) -> Vector2d { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Vector2d { [INFO] [stdout] 46 | x: self.x * rhs, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/math.rs:47:16 [INFO] [stdout] | [INFO] [stdout] 44 | fn mul(self, rhs: usize) -> Vector2d { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | y: self.y * rhs, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/physics.rs:16:39 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, PartialEq, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdl2anim` (lib test) due to 9 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "864cb18e33009c649e59a559b08d4860aa844068f5e3ab0f0b6b514461f03052", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "864cb18e33009c649e59a559b08d4860aa844068f5e3ab0f0b6b514461f03052", kill_on_drop: false }` [INFO] [stdout] 864cb18e33009c649e59a559b08d4860aa844068f5e3ab0f0b6b514461f03052