[INFO] cloning repository https://github.com/SnitzelKlaus/mqtt-broker [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SnitzelKlaus/mqtt-broker" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnitzelKlaus%2Fmqtt-broker", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnitzelKlaus%2Fmqtt-broker'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1187e43c8ea6fbec68385957d94501a8430a50dc [INFO] checking SnitzelKlaus/mqtt-broker/1187e43c8ea6fbec68385957d94501a8430a50dc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSnitzelKlaus%2Fmqtt-broker" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SnitzelKlaus/mqtt-broker on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SnitzelKlaus/mqtt-broker [INFO] finished tweaking git repo https://github.com/SnitzelKlaus/mqtt-broker [INFO] tweaked toml for git repo https://github.com/SnitzelKlaus/mqtt-broker written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SnitzelKlaus/mqtt-broker already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d72b1c83d14d63700886c36772ec17b89fa8fcd2b31d7b9e8396a0fede5944c6 [INFO] running `Command { std: "docker" "start" "-a" "d72b1c83d14d63700886c36772ec17b89fa8fcd2b31d7b9e8396a0fede5944c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d72b1c83d14d63700886c36772ec17b89fa8fcd2b31d7b9e8396a0fede5944c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d72b1c83d14d63700886c36772ec17b89fa8fcd2b31d7b9e8396a0fede5944c6", kill_on_drop: false }` [INFO] [stdout] d72b1c83d14d63700886c36772ec17b89fa8fcd2b31d7b9e8396a0fede5944c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5991694bf2165de93cf135c6477420f2033efc84429c21d244936db2602b474b [INFO] running `Command { std: "docker" "start" "-a" "5991694bf2165de93cf135c6477420f2033efc84429c21d244936db2602b474b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking mqtt_broker v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/mqtt/broker_state.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/mqtt/create_client.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PrimitiveDateTime` [INFO] [stdout] --> src/mqtt/state_thread.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | use time::{OffsetDateTime, PrimitiveDateTime}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `TcpListener` [INFO] [stdout] --> src/mqtt/broker_state.rs:1:16 [INFO] [stdout] | [INFO] [stdout] 1 | use std::net::{TcpListener, TcpStream}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/mqtt/create_client.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 103 | ; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PrimitiveDateTime` [INFO] [stdout] --> src/mqtt/state_thread.rs:3:28 [INFO] [stdout] | [INFO] [stdout] 3 | use time::{OffsetDateTime, PrimitiveDateTime}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `current_index_in_buffer` is never read [INFO] [stdout] --> src/mqtt/create_client.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | current_index_in_buffer = new_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `now` [INFO] [stdout] --> src/mqtt/state_thread.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | let now = OffsetDateTime::now_utc(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_now` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_password` is never used [INFO] [stdout] --> src/mqtt/create_client.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn extract_password(buffer: &[u8], password_flag: bool, current_index_in_buffer: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_username` is never used [INFO] [stdout] --> src/mqtt/create_client.rs:175:4 [INFO] [stdout] | [INFO] [stdout] 175 | fn extract_username(buffer: &[u8], username_flag: bool, mut current_index_in_buffer: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mqtt/message_handlers/connect_handler.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn connect(stream: &mut TcpStream, buffer: &mut [u8], thread_id: f64, broker_state: MutexGuard<'_, BrokerState>) { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | match stream.read(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqtt_broker` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: value assigned to `current_index_in_buffer` is never read [INFO] [stdout] --> src/mqtt/create_client.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | current_index_in_buffer = new_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `now` [INFO] [stdout] --> src/mqtt/state_thread.rs:91:21 [INFO] [stdout] | [INFO] [stdout] 91 | let now = OffsetDateTime::now_utc(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_now` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_password` is never used [INFO] [stdout] --> src/mqtt/create_client.rs:160:4 [INFO] [stdout] | [INFO] [stdout] 160 | fn extract_password(buffer: &[u8], password_flag: bool, current_index_in_buffer: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `extract_username` is never used [INFO] [stdout] --> src/mqtt/create_client.rs:175:4 [INFO] [stdout] | [INFO] [stdout] 175 | fn extract_username(buffer: &[u8], username_flag: bool, mut current_index_in_buffer: usize) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mqtt/message_handlers/connect_handler.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn connect(stream: &mut TcpStream, buffer: &mut [u8], thread_id: f64, broker_state: MutexGuard<'_, BrokerState>) { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 6 | match stream.read(buffer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mqtt_broker` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5991694bf2165de93cf135c6477420f2033efc84429c21d244936db2602b474b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5991694bf2165de93cf135c6477420f2033efc84429c21d244936db2602b474b", kill_on_drop: false }` [INFO] [stdout] 5991694bf2165de93cf135c6477420f2033efc84429c21d244936db2602b474b