[INFO] cloning repository https://github.com/SmokeyCrab/rust-link-shortener [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SmokeyCrab/rust-link-shortener" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSmokeyCrab%2Frust-link-shortener", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSmokeyCrab%2Frust-link-shortener'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 885c92a03b4d3fff15d93c4694308f24bd707f83 [INFO] checking SmokeyCrab/rust-link-shortener/885c92a03b4d3fff15d93c4694308f24bd707f83 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSmokeyCrab%2Frust-link-shortener" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SmokeyCrab/rust-link-shortener on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SmokeyCrab/rust-link-shortener [INFO] finished tweaking git repo https://github.com/SmokeyCrab/rust-link-shortener [INFO] tweaked toml for git repo https://github.com/SmokeyCrab/rust-link-shortener written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SmokeyCrab/rust-link-shortener already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 33e1b2fb320cb5b678648cd8059d06dad02d0257153f215a19864ff68a6fbeb3 [INFO] running `Command { std: "docker" "start" "-a" "33e1b2fb320cb5b678648cd8059d06dad02d0257153f215a19864ff68a6fbeb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "33e1b2fb320cb5b678648cd8059d06dad02d0257153f215a19864ff68a6fbeb3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33e1b2fb320cb5b678648cd8059d06dad02d0257153f215a19864ff68a6fbeb3", kill_on_drop: false }` [INFO] [stdout] 33e1b2fb320cb5b678648cd8059d06dad02d0257153f215a19864ff68a6fbeb3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c5cbe341d9622eadc8d88c8bd50f4232556ebdc8891d4f5e9aba7a90930ef56e [INFO] running `Command { std: "docker" "start" "-a" "c5cbe341d9622eadc8d88c8bd50f4232556ebdc8891d4f5e9aba7a90930ef56e", kill_on_drop: false }` [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking tinyvec v1.6.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking unicode-properties v0.1.1 [INFO] [stderr] Compiling syn v2.0.68 [INFO] [stderr] Checking siphasher v0.3.11 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking whoami v1.5.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking random-string v1.1.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking postgres-protocol v0.6.6 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking postgres-types v0.2.6 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking thiserror v1.0.61 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking sprintf v0.3.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking tokio-postgres v0.7.10 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking rust-url-short v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `postgres_table` is never read [INFO] [stdout] --> src/config.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct PostgresConfig { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | pub postgres_table: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 44 | client: Arc, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | pg_client: Arc, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | host_config: Arc, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | pg_config: Arc [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | move |req: Request| { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let client_clone = Arc::clone(&client); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let pg_client_clone = Arc::clone(&pg_client); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let host_config_clone = Arc::clone(&host_config); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let pg_config_clone = Arc::clone(&pg_config); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Box::pin( [INFO] [stdout] 63 | / url_shorten_service( [INFO] [stdout] 64 | | client_clone, [INFO] [stdout] 65 | | pg_client_clone, [INFO] [stdout] 66 | | host_config_clone, [INFO] [stdout] 67 | | pg_config_clone, [INFO] [stdout] 68 | | req [INFO] [stdout] 69 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/responses.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 27 | host_config: Arc [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | / Response::new( [INFO] [stdout] 31 | | hyper_template_funcs::full( [INFO] [stdout] 32 | | sprintf!( [INFO] [stdout] 33 | | "Welcome to the URL Shortener, POST a URL to \"%s/\"", [INFO] [stdout] ... | [INFO] [stdout] 36 | | ) [INFO] [stdout] 37 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/responses/hyper_template_funcs.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | / Full::new(chunk.into()) [INFO] [stdout] 19 | | .map_err(|never| { [INFO] [stdout] 20 | | match never { [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | }) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-url-short` (bin "rust-url-short") due to 4 previous errors; 1 warning emitted [INFO] [stdout] warning: field `postgres_table` is never read [INFO] [stdout] --> src/config.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct PostgresConfig { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 12 | pub postgres_table: String, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 44 | client: Arc, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | pg_client: Arc, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | host_config: Arc, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | pg_config: Arc [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | move |req: Request| { [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let client_clone = Arc::clone(&client); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let pg_client_clone = Arc::clone(&pg_client); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | let host_config_clone = Arc::clone(&host_config); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | let pg_config_clone = Arc::clone(&pg_config); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | Box::pin( [INFO] [stdout] 63 | / url_shorten_service( [INFO] [stdout] 64 | | client_clone, [INFO] [stdout] 65 | | pg_client_clone, [INFO] [stdout] 66 | | host_config_clone, [INFO] [stdout] 67 | | pg_config_clone, [INFO] [stdout] 68 | | req [INFO] [stdout] 69 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/responses.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 27 | host_config: Arc [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | / Response::new( [INFO] [stdout] 31 | | hyper_template_funcs::full( [INFO] [stdout] 32 | | sprintf!( [INFO] [stdout] 33 | | "Welcome to the URL Shortener, POST a URL to \"%s/\"", [INFO] [stdout] ... | [INFO] [stdout] 36 | | ) [INFO] [stdout] 37 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/responses/hyper_template_funcs.rs:18:3 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | / Full::new(chunk.into()) [INFO] [stdout] 19 | | .map_err(|never| { [INFO] [stdout] 20 | | match never { [INFO] [stdout] 21 | | } [INFO] [stdout] 22 | | }) [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-url-short` (bin "rust-url-short" test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "c5cbe341d9622eadc8d88c8bd50f4232556ebdc8891d4f5e9aba7a90930ef56e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5cbe341d9622eadc8d88c8bd50f4232556ebdc8891d4f5e9aba7a90930ef56e", kill_on_drop: false }` [INFO] [stdout] c5cbe341d9622eadc8d88c8bd50f4232556ebdc8891d4f5e9aba7a90930ef56e