[INFO] cloning repository https://github.com/SirLich/regolite [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SirLich/regolite" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSirLich%2Fregolite", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSirLich%2Fregolite'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 242bf987a9a911a41173c304157c434b95804c59 [INFO] checking SirLich/regolite/242bf987a9a911a41173c304157c434b95804c59 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSirLich%2Fregolite" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SirLich/regolite on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SirLich/regolite [INFO] finished tweaking git repo https://github.com/SirLich/regolite [INFO] tweaked toml for git repo https://github.com/SirLich/regolite written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SirLich/regolite already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b91c2aca25dfcc8ae33809016a223c340b703cf1873c83b6161ce57e818571a8 [INFO] running `Command { std: "docker" "start" "-a" "b91c2aca25dfcc8ae33809016a223c340b703cf1873c83b6161ce57e818571a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b91c2aca25dfcc8ae33809016a223c340b703cf1873c83b6161ce57e818571a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b91c2aca25dfcc8ae33809016a223c340b703cf1873c83b6161ce57e818571a8", kill_on_drop: false }` [INFO] [stdout] b91c2aca25dfcc8ae33809016a223c340b703cf1873c83b6161ce57e818571a8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e69c854ba26d05e5d6212d4fb69bae42b6a5baf8bdd0f17ae4e7c4bac168c4b [INFO] running `Command { std: "docker" "start" "-a" "3e69c854ba26d05e5d6212d4fb69bae42b6a5baf8bdd0f17ae4e7c4bac168c4b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Compiling serde v1.0.192 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling serde_json v1.0.108 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_builder v4.4.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Compiling jobserver v0.1.27 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking path-clean v1.0.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling libz-sys v1.1.12 [INFO] [stderr] Compiling openssl-sys v0.9.98 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.1+1.7.1 [INFO] [stderr] Compiling serde_derive v1.0.192 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking clap v4.4.8 [INFO] [stderr] Checking git2 v0.18.1 [INFO] [stderr] Checking regolite v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `clean` [INFO] [stdout] --> src/file_helper.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | use path_clean::{clean, PathClean}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/global.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Result` and `bail` [INFO] [stdout] --> src/global.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{Result, bail}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/global.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::path::{PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bail` [INFO] [stdout] --> src/runner.rs:6:31 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{Context, Result, bail}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PathClean` and `clean` [INFO] [stdout] --> src/main.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | use path_clean::{clean, PathClean}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `clean` [INFO] [stdout] --> src/file_helper.rs:11:18 [INFO] [stdout] | [INFO] [stdout] 11 | use path_clean::{clean, PathClean}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/global.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Result` and `bail` [INFO] [stdout] --> src/global.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use anyhow::{Result, bail}; [INFO] [stdout] | ^^^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `PathBuf` [INFO] [stdout] --> src/global.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::path::{PathBuf}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bail` [INFO] [stdout] --> src/runner.rs:6:31 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{Context, Result, bail}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PathClean` and `clean` [INFO] [stdout] --> src/main.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | use path_clean::{clean, PathClean}; [INFO] [stdout] | ^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opts` [INFO] [stdout] --> src/runner.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn run(params: RunParams, opts: GlobalOpts) -> Result<()> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_opts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opts` [INFO] [stdout] --> src/runner.rs:15:31 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn run(params: RunParams, opts: GlobalOpts) -> Result<()> { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_opts` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write` is never used [INFO] [stdout] --> src/config.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn write(config: &Config) -> Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `regolith_url` and `file_path` are never read [INFO] [stdout] --> src/cli.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct FilterIdentifier { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 76 | /// The 'regolith' style URL, e.g, github.com/Bedrock-OSS/regolith-filters/name_ninja [INFO] [stdout] 77 | pub regolith_url: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub file_path: PathBuf [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `does_source_exist` is never used [INFO] [stdout] --> src/installer.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn does_source_exist(identifier : &FilterIdentifier) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `write` is never used [INFO] [stdout] --> src/config.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 113 | pub fn write(config: &Config) -> Result<()> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/installer.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | match Repository::clone(url, install_location) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `regolith_url` and `file_path` are never read [INFO] [stdout] --> src/cli.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct FilterIdentifier { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 76 | /// The 'regolith' style URL, e.g, github.com/Bedrock-OSS/regolith-filters/name_ninja [INFO] [stdout] 77 | pub regolith_url: String, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | pub file_path: PathBuf [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `does_source_exist` is never used [INFO] [stdout] --> src/installer.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn does_source_exist(identifier : &FilterIdentifier) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/installer.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | match Repository::clone(url, install_location) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `regolite` (bin "regolite" test) due to 2 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `regolite` (bin "regolite") due to 2 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3e69c854ba26d05e5d6212d4fb69bae42b6a5baf8bdd0f17ae4e7c4bac168c4b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e69c854ba26d05e5d6212d4fb69bae42b6a5baf8bdd0f17ae4e7c4bac168c4b", kill_on_drop: false }` [INFO] [stdout] 3e69c854ba26d05e5d6212d4fb69bae42b6a5baf8bdd0f17ae4e7c4bac168c4b