[INFO] cloning repository https://github.com/Simhyeon/rif [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Simhyeon/rif" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSimhyeon%2Frif", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSimhyeon%2Frif'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 107ce1a374b69c528a621342520bba48a749f57a [INFO] checking Simhyeon/rif/107ce1a374b69c528a621342520bba48a749f57a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSimhyeon%2Frif" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Simhyeon/rif on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Simhyeon/rif [INFO] finished tweaking git repo https://github.com/Simhyeon/rif [INFO] tweaked toml for git repo https://github.com/Simhyeon/rif written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Simhyeon/rif already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Updating rif v0.2.0 (/workspace/builds/worker-2-tc2/source) -> v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89dd02816ea6b5c78eb4673c40eeba2e5461b885822450a10d15bc87d188aeed [INFO] running `Command { std: "docker" "start" "-a" "89dd02816ea6b5c78eb4673c40eeba2e5461b885822450a10d15bc87d188aeed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89dd02816ea6b5c78eb4673c40eeba2e5461b885822450a10d15bc87d188aeed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89dd02816ea6b5c78eb4673c40eeba2e5461b885822450a10d15bc87d188aeed", kill_on_drop: false }` [INFO] [stdout] 89dd02816ea6b5c78eb4673c40eeba2e5461b885822450a10d15bc87d188aeed [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93744c9f2b83e894c61b82922451c7ebec4ebec9dadaf0a2bdf28a8565e30bf7 [INFO] running `Command { std: "docker" "start" "-a" "93744c9f2b83e894c61b82922451c7ebec4ebec9dadaf0a2bdf28a8565e30bf7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.26 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.71 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking filetime v0.2.14 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking rif v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: type `FileStatus` is more private than the item `Relations::set_file_status` [INFO] [stdout] --> src/rif/rel.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | pub fn set_file_status(&mut self, file_path: &Path, file_status: FileStatus) -> Result<(), RifError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Relations::set_file_status` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileStatus` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/models.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) enum FileStatus { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileStatus` is more private than the item `SingleFile::status` [INFO] [stdout] --> src/rif/rel.rs:747:5 [INFO] [stdout] | [INFO] [stdout] 747 | pub status: FileStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ field `SingleFile::status` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileStatus` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/models.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) enum FileStatus { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `walk_directory` is never used [INFO] [stdout] --> src/utils.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn walk_directory(path: &Path, f: &mut dyn FnMut(PathBuf) -> Result<(), RifError>) -> Result<(), RifError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_rif_directory` is never used [INFO] [stdout] --> src/utils.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn get_rif_directory() -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `blue` is never used [INFO] [stdout] --> src/utils.rs:268:8 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn blue(string : &str) -> Box { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rif.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(path: Option>) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let config = Config::read_from_file(path.as_ref())?; [INFO] [stdout] 33 | let black_list = utils::get_black_list(config.git_ignore)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | config, [INFO] [stdout] 36 | | history: History::read_from_file(path.as_ref())?, [INFO] [stdout] 37 | | relation: Relations::read_from_file(path.as_ref())?, [INFO] [stdout] ... | [INFO] [stdout] 40 | | root_path: path.map(|p| p.as_ref().clone().to_owned()), [INFO] [stdout] 41 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/rif.rs:40:47 [INFO] [stdout] | [INFO] [stdout] 40 | root_path: path.map(|p| p.as_ref().clone().to_owned()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 40 - root_path: path.map(|p| p.as_ref().clone().to_owned()), [INFO] [stdout] 40 + root_path: path.map(|p| p.as_ref().to_owned()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rif/hook.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 72 | #[derive(Deserialize, Serialize, Debug, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Serialize, Deserialize, Debug, PartialEq, Clone, Copy)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rif` (lib test) due to 4 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: type `FileStatus` is more private than the item `Relations::set_file_status` [INFO] [stdout] --> src/rif/rel.rs:360:5 [INFO] [stdout] | [INFO] [stdout] 360 | pub fn set_file_status(&mut self, file_path: &Path, file_status: FileStatus) -> Result<(), RifError> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ method `Relations::set_file_status` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileStatus` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/models.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) enum FileStatus { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(private_interfaces)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `FileStatus` is more private than the item `SingleFile::status` [INFO] [stdout] --> src/rif/rel.rs:747:5 [INFO] [stdout] | [INFO] [stdout] 747 | pub status: FileStatus, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ field `SingleFile::status` is reachable at visibility `pub` [INFO] [stdout] | [INFO] [stdout] note: but type `FileStatus` is only usable at visibility `pub(crate)` [INFO] [stdout] --> src/models.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | pub(crate) enum FileStatus { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `walk_directory` is never used [INFO] [stdout] --> src/utils.rs:79:8 [INFO] [stdout] | [INFO] [stdout] 79 | pub fn walk_directory(path: &Path, f: &mut dyn FnMut(PathBuf) -> Result<(), RifError>) -> Result<(), RifError> { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_rif_directory` is never used [INFO] [stdout] --> src/utils.rs:158:8 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn get_rif_directory() -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `blue` is never used [INFO] [stdout] --> src/utils.rs:268:8 [INFO] [stdout] | [INFO] [stdout] 268 | pub fn blue(string : &str) -> Box { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rif.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(path: Option>) -> Result { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | let config = Config::read_from_file(path.as_ref())?; [INFO] [stdout] 33 | let black_list = utils::get_black_list(config.git_ignore)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | config, [INFO] [stdout] 36 | | history: History::read_from_file(path.as_ref())?, [INFO] [stdout] 37 | | relation: Relations::read_from_file(path.as_ref())?, [INFO] [stdout] ... | [INFO] [stdout] 40 | | root_path: path.map(|p| p.as_ref().clone().to_owned()), [INFO] [stdout] 41 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/rif.rs:40:47 [INFO] [stdout] | [INFO] [stdout] 40 | root_path: path.map(|p| p.as_ref().clone().to_owned()), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `Path` does not implement `Clone`, so calling `clone` on `&Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 40 - root_path: path.map(|p| p.as_ref().clone().to_owned()), [INFO] [stdout] 40 + root_path: path.map(|p| p.as_ref().to_owned()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rif/hook.rs:72:10 [INFO] [stdout] | [INFO] [stdout] 72 | #[derive(Deserialize, Serialize, Debug, Clone)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/models.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Serialize, Deserialize, Debug, PartialEq, Clone, Copy)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rif` (lib) due to 4 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "93744c9f2b83e894c61b82922451c7ebec4ebec9dadaf0a2bdf28a8565e30bf7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93744c9f2b83e894c61b82922451c7ebec4ebec9dadaf0a2bdf28a8565e30bf7", kill_on_drop: false }` [INFO] [stdout] 93744c9f2b83e894c61b82922451c7ebec4ebec9dadaf0a2bdf28a8565e30bf7