[INFO] cloning repository https://github.com/SiegeLord/BladeBlade [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SiegeLord/BladeBlade" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSiegeLord%2FBladeBlade", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSiegeLord%2FBladeBlade'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 197749ed0f474e3e45e60d4d2d3e4247d4ac9795 [INFO] checking SiegeLord/BladeBlade/197749ed0f474e3e45e60d4d2d3e4247d4ac9795 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSiegeLord%2FBladeBlade" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SiegeLord/BladeBlade on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/SiegeLord/BladeBlade [INFO] finished tweaking git repo https://github.com/SiegeLord/BladeBlade [INFO] tweaked toml for git repo https://github.com/SiegeLord/BladeBlade written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SiegeLord/BladeBlade already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2b3d5cfc6f8f29630ad15ec1dbe167bff6d7692a65091da918094e1fa8578960 [INFO] running `Command { std: "docker" "start" "-a" "2b3d5cfc6f8f29630ad15ec1dbe167bff6d7692a65091da918094e1fa8578960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2b3d5cfc6f8f29630ad15ec1dbe167bff6d7692a65091da918094e1fa8578960", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b3d5cfc6f8f29630ad15ec1dbe167bff6d7692a65091da918094e1fa8578960", kill_on_drop: false }` [INFO] [stdout] 2b3d5cfc6f8f29630ad15ec1dbe167bff6d7692a65091da918094e1fa8578960 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7b3ff9cf2bb0d5ba00c700730b0cb360da73f6cfbf639a57f9cee146f7be2766 [INFO] running `Command { std: "docker" "start" "-a" "7b3ff9cf2bb0d5ba00c700730b0cb360da73f6cfbf639a57f9cee146f7be2766", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling allegro-sys v0.0.44 [INFO] [stderr] Compiling allegro v0.0.44 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling allegro_font-sys v0.0.44 [INFO] [stderr] Checking once_cell v1.8.0 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling allegro_primitives-sys v0.0.44 [INFO] [stderr] Checking bytemuck v1.12.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling ahash v0.7.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling allegro_audio-sys v0.0.44 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Compiling num-rational v0.4.0 [INFO] [stderr] Compiling allegro_color-sys v0.0.44 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling allegro_ttf-sys v0.0.44 [INFO] [stderr] Compiling allegro_acodec-sys v0.0.44 [INFO] [stderr] Compiling allegro_image-sys v0.0.44 [INFO] [stderr] Compiling allegro_dialog-sys v0.0.44 [INFO] [stderr] Compiling paste v1.0.5 [INFO] [stderr] Checking safe_arch v0.6.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling allegro_primitives v0.0.44 [INFO] [stderr] Checking spin v0.9.4 [INFO] [stderr] Checking matrixmultiply v0.3.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking wide v0.7.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking allegro_util v0.0.44 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking num-complex v0.4.0 [INFO] [stderr] Checking approx v0.5.0 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking allegro_audio v0.0.44 [INFO] [stderr] Checking allegro_font v0.0.44 [INFO] [stderr] Checking allegro_image v0.0.44 [INFO] [stderr] Checking allegro_dialog v0.0.44 [INFO] [stderr] Checking allegro_color v0.0.44 [INFO] [stderr] Checking allegro_ttf v0.0.44 [INFO] [stderr] Checking allegro_acodec v0.0.44 [INFO] [stderr] Checking hecs v0.9.0 [INFO] [stderr] Checking simba v0.7.2 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Checking nalgebra v0.31.1 [INFO] [stderr] Checking slr_parser v0.0.21 [INFO] [stderr] Checking obj-rs v0.7.1 [INFO] [stderr] Checking slr_config v0.0.21 [INFO] [stderr] Checking BladeBlade v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `stats` [INFO] [stdout] --> src/map.rs:1246:15 [INFO] [stdout] | [INFO] [stdout] 1246 | if let (Ok(stats), Ok(mut target)) = ( [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_stats` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/map.rs:1596:48 [INFO] [stdout] | [INFO] [stdout] 1596 | for (_id, (_, enemy_position, enemy_stats, mut life)) in self [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stats` [INFO] [stdout] --> src/map.rs:1246:15 [INFO] [stdout] | [INFO] [stdout] 1246 | if let (Ok(stats), Ok(mut target)) = ( [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_stats` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/map.rs:1596:48 [INFO] [stdout] | [INFO] [stdout] 1596 | for (_id, (_, enemy_position, enemy_stats, mut life)) in self [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | match catch_unwind(|| real_main().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls.rs:6:42 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(PartialEq, Eq, Hash, Serialize, Deserialize, Copy, Clone, Debug, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/controls.rs:670:17 [INFO] [stdout] | [INFO] [stdout] 670 | for inputs in &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 670 | while let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 670 | if let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/controls.rs:685:17 [INFO] [stdout] | [INFO] [stdout] 685 | for inputs in &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 685 | while let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 685 | if let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(message: String, inner: Option>) -> Self [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | backtrace: Backtrace::capture(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_state.rs:134:6 [INFO] [stdout] | [INFO] [stdout] 113 | let core = Core::init()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let ui_font = ttf [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let sfx = Sfx::new(options.sfx_volume, options.music_volume, &core)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(GameState { [INFO] [stdout] | ____________^ [INFO] [stdout] 135 | | core: core, [INFO] [stdout] 136 | | prim: prim, [INFO] [stdout] 137 | | image: image, [INFO] [stdout] ... | [INFO] [stdout] 148 | | controls: controls, [INFO] [stdout] 149 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:1153:6 [INFO] [stdout] | [INFO] [stdout] 1086 | let mut world = hecs::World::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1153 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1154 | | world: world, [INFO] [stdout] 1155 | | player: player, [INFO] [stdout] 1156 | | player_pos: player_pos, [INFO] [stdout] ... | [INFO] [stdout] 1185 | | subscreens: vec![], [INFO] [stdout] 1186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:147:64 [INFO] [stdout] | [INFO] [stdout] 147 | .map_err(|e| Error::new(format!("Couldn't read '{}'", path), Some(Box::new(e)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:156:2 [INFO] [stdout] | [INFO] [stdout] 154 | let element = ConfigElement::from_source(&mut source) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | .map_err(|e| Error::new(format!("Config parsing error"), Some(Box::new(e))))?; [INFO] [stdout] 156 | from_element::(&element, Some(&source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:155:60 [INFO] [stdout] | [INFO] [stdout] 155 | .map_err(|e| Error::new(format!("Config parsing error"), Some(Box::new(e))))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:157:60 [INFO] [stdout] | [INFO] [stdout] 157 | .map_err(|e| Error::new(format!("Config parsing error"), Some(Box::new(e)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:163:60 [INFO] [stdout] | [INFO] [stdout] 163 | .map_err(|e| Error::new(format!("Config writing error"), Some(Box::new(e))))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:165:65 [INFO] [stdout] | [INFO] [stdout] 165 | .map_err(|e| Error::new(format!("Couldn't write '{}'", file), Some(Box::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:185:57 [INFO] [stdout] | [INFO] [stdout] 184 | BufReader::new(File::open(filename).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Error::new(format!("Could not open '{}'", filename), Some(Box::new(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:188:69 [INFO] [stdout] | [INFO] [stdout] 188 | .map_err(|e| Error::new(format!("Could not open '{}'", filename), Some(Box::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `BladeBlade` (bin "BladeBlade" test) due to 14 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | match catch_unwind(|| real_main().unwrap()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controls.rs:6:42 [INFO] [stdout] | [INFO] [stdout] 6 | #[derive(PartialEq, Eq, Hash, Serialize, Deserialize, Copy, Clone, Debug, PartialOrd, Ord)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/controls.rs:670:17 [INFO] [stdout] | [INFO] [stdout] 670 | for inputs in &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 670 | while let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 670 | if let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/controls.rs:685:17 [INFO] [stdout] | [INFO] [stdout] 685 | for inputs in &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 685 | while let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 685 | if let Some(inputs) = &self.controls.action_to_inputs.get(&action) [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:20:15 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn new(message: String, inner: Option>) -> Self [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | backtrace: Backtrace::capture(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/game_state.rs:134:6 [INFO] [stdout] | [INFO] [stdout] 113 | let core = Core::init()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let ui_font = ttf [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | let sfx = Sfx::new(options.sfx_volume, options.music_volume, &core)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | Ok(GameState { [INFO] [stdout] | ____________^ [INFO] [stdout] 135 | | core: core, [INFO] [stdout] 136 | | prim: prim, [INFO] [stdout] 137 | | image: image, [INFO] [stdout] ... | [INFO] [stdout] 148 | | controls: controls, [INFO] [stdout] 149 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/map.rs:1153:6 [INFO] [stdout] | [INFO] [stdout] 1086 | let mut world = hecs::World::default(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1153 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 1154 | | world: world, [INFO] [stdout] 1155 | | player: player, [INFO] [stdout] 1156 | | player_pos: player_pos, [INFO] [stdout] ... | [INFO] [stdout] 1185 | | subscreens: vec![], [INFO] [stdout] 1186 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:147:64 [INFO] [stdout] | [INFO] [stdout] 147 | .map_err(|e| Error::new(format!("Couldn't read '{}'", path), Some(Box::new(e)))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:156:2 [INFO] [stdout] | [INFO] [stdout] 154 | let element = ConfigElement::from_source(&mut source) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | .map_err(|e| Error::new(format!("Config parsing error"), Some(Box::new(e))))?; [INFO] [stdout] 156 | from_element::(&element, Some(&source)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:155:60 [INFO] [stdout] | [INFO] [stdout] 155 | .map_err(|e| Error::new(format!("Config parsing error"), Some(Box::new(e))))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:157:60 [INFO] [stdout] | [INFO] [stdout] 157 | .map_err(|e| Error::new(format!("Config parsing error"), Some(Box::new(e)))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:163:60 [INFO] [stdout] | [INFO] [stdout] 163 | .map_err(|e| Error::new(format!("Config writing error"), Some(Box::new(e))))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:165:65 [INFO] [stdout] | [INFO] [stdout] 165 | .map_err(|e| Error::new(format!("Couldn't write '{}'", file), Some(Box::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:185:57 [INFO] [stdout] | [INFO] [stdout] 184 | BufReader::new(File::open(filename).map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | Error::new(format!("Could not open '{}'", filename), Some(Box::new(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:188:69 [INFO] [stdout] | [INFO] [stdout] 188 | .map_err(|e| Error::new(format!("Could not open '{}'", filename), Some(Box::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `BladeBlade` (bin "BladeBlade") due to 14 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7b3ff9cf2bb0d5ba00c700730b0cb360da73f6cfbf639a57f9cee146f7be2766", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b3ff9cf2bb0d5ba00c700730b0cb360da73f6cfbf639a57f9cee146f7be2766", kill_on_drop: false }` [INFO] [stdout] 7b3ff9cf2bb0d5ba00c700730b0cb360da73f6cfbf639a57f9cee146f7be2766