[INFO] cloning repository https://github.com/Sherlock2019/nodejs-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sherlock2019/nodejs-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherlock2019%2Fnodejs-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherlock2019%2Fnodejs-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 910a5480c1ac748b5fa8ff3da531241eaf106388 [INFO] checking Sherlock2019/nodejs-rust/910a5480c1ac748b5fa8ff3da531241eaf106388 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSherlock2019%2Fnodejs-rust" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sherlock2019/nodejs-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-7-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/Sherlock2019/nodejs-rust [INFO] finished tweaking git repo https://github.com/Sherlock2019/nodejs-rust [INFO] tweaked toml for git repo https://github.com/Sherlock2019/nodejs-rust written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Sherlock2019/nodejs-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 766c671832277b0ad0d701b210e2706418f67e8e10e3c3414033b8f191eb9c75 [INFO] running `Command { std: "docker" "start" "-a" "766c671832277b0ad0d701b210e2706418f67e8e10e3c3414033b8f191eb9c75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "766c671832277b0ad0d701b210e2706418f67e8e10e3c3414033b8f191eb9c75", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "766c671832277b0ad0d701b210e2706418f67e8e10e3c3414033b8f191eb9c75", kill_on_drop: false }` [INFO] [stdout] 766c671832277b0ad0d701b210e2706418f67e8e10e3c3414033b8f191eb9c75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cd009b789c5a33350d5eeac36c786e0fd3b2d583782c8984421895bfe96a6c3 [INFO] running `Command { std: "docker" "start" "-a" "5cd009b789c5a33350d5eeac36c786e0fd3b2d583782c8984421895bfe96a6c3", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling semver v1.0.13 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling tokio v1.24.2 [INFO] [stderr] Compiling clang-sys v1.3.3 [INFO] [stderr] Compiling indexmap v1.9.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling os_str_bytes v6.4.1 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling aho-corasick v0.7.19 [INFO] [stderr] Compiling termcolor v1.1.3 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Compiling clap_lex v0.2.4 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling libloading v0.7.3 [INFO] [stderr] Compiling bindgen v0.60.1 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Checking send_wrapper v0.6.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling either v1.8.0 [INFO] [stderr] Compiling textwrap v0.16.0 [INFO] [stderr] Compiling spin v0.5.2 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling which v4.4.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling clap v3.2.23 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling shlex v1.1.0 [INFO] [stderr] Compiling libm v0.2.6 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling syn-mid v0.5.3 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Compiling num-bigint-dig v0.8.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling neon-macros v1.0.0-alpha.4 (/opt/rustwide/workdir/crates/neon-macros) [INFO] [stderr] Compiling env_logger v0.9.3 [INFO] [stderr] Checking neon v1.0.0-alpha.4 (/opt/rustwide/workdir/crates/neon) [INFO] [stderr] Compiling thiserror-impl v1.0.35 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stdout] warning: struct `InheritedHandleScope` is never constructed [INFO] [stdout] --> crates/neon/src/sys/raw.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub struct InheritedHandleScope; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `InheritedHandleScope` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/context/mod.rs:282:33 [INFO] [stdout] | [INFO] [stdout] 267 | fn compute_scoped<'b, V, F>(&mut self, f: F) -> JsResult<'a, V> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let scope = unsafe { EscapableHandleScope::new(env.to_raw()) }; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 282 | Ok(Handle::new_internal(unsafe { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 283 | | V::from_local(self.env(), escapee) [INFO] [stdout] 284 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/context/mod.rs:656:11 [INFO] [stdout] | [INFO] [stdout] 654 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 655 | ) -> U { [INFO] [stdout] 656 | f(FunctionContext { [INFO] [stdout] | ___________^ [INFO] [stdout] 657 | | env, [INFO] [stdout] 658 | | info, [INFO] [stdout] 659 | | arguments: None, [INFO] [stdout] 660 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/event/channel.rs:156:9 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn send(&self, f: F) -> JoinHandle [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | self.try_send(f).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/event/channel.rs:185:12 [INFO] [stdout] | [INFO] [stdout] 163 | pub fn try_send(&self, f: F) -> Result, SendError> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 168 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let callback = Box::new(move |env| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | Ok(JoinHandle { rx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/event/channel.rs:276:12 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn join(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | Ok(self.rx.blocking_recv()??) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/event/channel.rs:292:45 [INFO] [stdout] | [INFO] [stdout] 287 | Poll::Ready(result) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 292 | let get_result = move || Ok(result??); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/event/task.rs:147:39 [INFO] [stdout] | [INFO] [stdout] 137 | output: thread::Result, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 138 | (complete, deferred): (D, Deferred), [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | deferred.try_catch_settle(cx, move |cx| { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 148 | | let output = output.unwrap_or_else(|panic| resume_unwind(panic)); [INFO] [stdout] 149 | | [INFO] [stdout] 150 | | complete(cx, output) [INFO] [stdout] 151 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/handle/root.rs:162:30 [INFO] [stdout] | [INFO] [stdout] 153 | pub fn into_inner<'a, C: Context<'a>>(self, cx: &mut C) -> Handle<'a, T> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | Handle::new_internal(unsafe { T::from_local(env, local) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/object/mod.rs:164:25 [INFO] [stdout] | [INFO] [stdout] 162 | key: K, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | ) -> NeonResult> { [INFO] [stdout] 164 | build(cx.env(), |out| unsafe { [INFO] [stdout] | _________________________^ [INFO] [stdout] 165 | | key.get_from(cx, out, self.to_local()) [INFO] [stdout] 166 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/sys/mod.rs:139:24 [INFO] [stdout] | [INFO] [stdout] 139 | SETUP.call_once(|| load(env).expect("Failed to load N-API symbols")); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/sys/debug_send_wrapper.rs:15:18 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | Self(send_wrapper::SendWrapper::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/thread/mod.rs:175:71 [INFO] [stdout] | [INFO] [stdout] 168 | pub fn get_or_init<'cx, 'a, C, F>(&self, cx: &'a mut C, f: F) -> &'cx T [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let r: &T = LocalCell::get_or_init(cx, self.id(), || Box::new(f())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/thread/mod.rs:199:71 [INFO] [stdout] | [INFO] [stdout] 192 | pub fn get_or_try_init<'cx, 'a, C, E, F>(&self, cx: &'a mut C, f: F) -> Result<&'cx T, E> [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let r: &T = LocalCell::get_or_try_init(cx, self.id(), |cx| Ok(Box::new(f(cx)?)))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/mod.rs:1106:37 [INFO] [stdout] | [INFO] [stdout] 1105 | FunctionContext::with(env, &info, |cx| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1106 | convert_panics(env, AssertUnwindSafe(|| f(cx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/error.rs:120:11 [INFO] [stdout] | [INFO] [stdout] 118 | f: F, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | ) -> NeonResult { [INFO] [stdout] 120 | match catch_unwind(f) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/promise.rs:241:12 [INFO] [stdout] | [INFO] [stdout] 180 | pub fn to_future<'a, O, C, F>(&self, cx: &mut C, f: F) -> NeonResult> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | let (tx, rx) = oneshot::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let take_state = { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | let state = Arc::new(Mutex::new(Some((f, tx)))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | let take_state = take_state.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 241 | Ok(JsFuture { rx }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/promise.rs:198:17 [INFO] [stdout] | [INFO] [stdout] 195 | let state = Arc::new(Mutex::new(Some((f, tx)))); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | / state [INFO] [stdout] 199 | | .lock() [INFO] [stdout] 200 | | .ok() [INFO] [stdout] 201 | | .and_then(|mut lock| lock.take()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/promise.rs:334:26 [INFO] [stdout] | [INFO] [stdout] 326 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | channel: &Channel, [INFO] [stdout] 328 | complete: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 334 | channel.try_send(move |cx| { [INFO] [stdout] | __________________________^ [INFO] [stdout] 335 | | self.try_catch_settle(cx, complete); [INFO] [stdout] 336 | | Ok(()) [INFO] [stdout] 337 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/promise.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 358 | pub fn settle_with(self, channel: &Channel, complete: F) -> JoinHandle<()> [INFO] [stdout] | ---- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 363 | self.try_settle_with(channel, complete).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/promise.rs:534:45 [INFO] [stdout] | [INFO] [stdout] 529 | Poll::Ready(result) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 534 | let get_result = move || Ok(result??); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/types_impl/private.rs:24:30 [INFO] [stdout] | [INFO] [stdout] 23 | fn cast<'a, T: Value, F: FnOnce(raw::Local) -> T>(self, f: F) -> Handle<'a, T> { [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Handle::new_internal(f(self.to_local())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/neon/src/lifecycle.rs:123:42 [INFO] [stdout] | [INFO] [stdout] 116 | pub(crate) fn get_or_init<'cx, 'a, C, F>(cx: &'a mut C, id: usize, f: F) -> &mut LocalCellValue [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | .pre_init(|| LocalCell::Init(f())); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stdout] error: aborting due to 22 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `neon` (lib) due to 23 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5cd009b789c5a33350d5eeac36c786e0fd3b2d583782c8984421895bfe96a6c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cd009b789c5a33350d5eeac36c786e0fd3b2d583782c8984421895bfe96a6c3", kill_on_drop: false }` [INFO] [stdout] 5cd009b789c5a33350d5eeac36c786e0fd3b2d583782c8984421895bfe96a6c3