[INFO] cloning repository https://github.com/ShaneM123/kvs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ShaneM123/kvs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShaneM123%2Fkvs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShaneM123%2Fkvs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 36186ab3041874c9ae4cf26c5f865605ed7d0ab9 [INFO] checking ShaneM123/kvs/36186ab3041874c9ae4cf26c5f865605ed7d0ab9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShaneM123%2Fkvs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ShaneM123/kvs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ShaneM123/kvs [INFO] finished tweaking git repo https://github.com/ShaneM123/kvs [INFO] tweaked toml for git repo https://github.com/ShaneM123/kvs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ShaneM123/kvs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 764b31552089710202064af7c74d1be0886a48178e0d558c80537a2b477288c6 [INFO] running `Command { std: "docker" "start" "-a" "764b31552089710202064af7c74d1be0886a48178e0d558c80537a2b477288c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "764b31552089710202064af7c74d1be0886a48178e0d558c80537a2b477288c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "764b31552089710202064af7c74d1be0886a48178e0d558c80537a2b477288c6", kill_on_drop: false }` [INFO] [stdout] 764b31552089710202064af7c74d1be0886a48178e0d558c80537a2b477288c6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c47b8f34e78eec963d9f717f091305db51ca9043e34d60c54c0dc33cc6ae5baf [INFO] running `Command { std: "docker" "start" "-a" "c47b8f34e78eec963d9f717f091305db51ca9043e34d60c54c0dc33cc6ae5baf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.125 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling serde v1.0.125 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking thread_local v1.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking sled v0.34.6 [INFO] [stderr] Checking slog-async v2.6.0 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Compiling cast v0.2.6 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking slog-term v2.8.0 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking plotters-backend v0.3.0 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking plotters-svg v0.3.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking float-cmp v0.8.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Checking half v1.7.1 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking predicates-tree v1.0.1 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking plotters v0.3.1 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking predicates v1.0.6 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Checking assert_cmd v1.0.2 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking kvs v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stdout] warning: unused import: `File` [INFO] [stdout] --> src/lib.rs:7:28 [INFO] [stdout] | [INFO] [stdout] 7 | use std::fs::{OpenOptions, File}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `join_paths` and `set_current_dir` [INFO] [stdout] --> src/lib.rs:12:16 [INFO] [stdout] | [INFO] [stdout] 12 | use std::env::{set_current_dir, join_paths}; [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `prelude::*` [INFO] [stdout] --> src/lib.rs:13:15 [INFO] [stdout] | [INFO] [stdout] 13 | use std::io::{prelude::*, Seek, SeekFrom}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:239:13 [INFO] [stdout] | [INFO] [stdout] 239 | let mut deserialised: Vec = serde_json::from_reader(reader).unwrap(); [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `db_file` [INFO] [stdout] --> src/lib.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | let db_file = fs::File::create(the_path.clone()).unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_db_file` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/lib.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct SledKvsEngine{ [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] 43 | pub sled_db: sled::Db, [INFO] [stdout] 44 | path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:67:41 [INFO] [stdout] | [INFO] [stdout] 65 | let x = self.sled_db.get(key).unwrap(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | //TODO: fix [INFO] [stdout] 67 | Ok(Some(String::from_utf8_lossy(&x.unwrap()).parse().unwrap())) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 111 | #[derive(Serialize, Deserialize, Debug, PartialEq, Ord, PartialOrd, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | file.read_to_string(&mut buffy); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 138 | let _ = file.read_to_string(&mut buffy); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | file.read_to_string(&mut buffy); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 192 | let _ = file.read_to_string(&mut buffy); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `std::result::Result` that must be used [INFO] [stdout] --> src/lib.rs:267:9 [INFO] [stdout] | [INFO] [stdout] 267 | fs::create_dir_all(&path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 267 | let _ = fs::create_dir_all(&path); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kvs` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "c47b8f34e78eec963d9f717f091305db51ca9043e34d60c54c0dc33cc6ae5baf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c47b8f34e78eec963d9f717f091305db51ca9043e34d60c54c0dc33cc6ae5baf", kill_on_drop: false }` [INFO] [stdout] c47b8f34e78eec963d9f717f091305db51ca9043e34d60c54c0dc33cc6ae5baf