[INFO] cloning repository https://github.com/ShaneEverittM/rust_db [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ShaneEverittM/rust_db" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShaneEverittM%2Frust_db", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShaneEverittM%2Frust_db'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ec9a86bb5a81c3e56e947872d6d2bf26ca853b02 [INFO] checking ShaneEverittM/rust_db/ec9a86bb5a81c3e56e947872d6d2bf26ca853b02 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShaneEverittM%2Frust_db" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ShaneEverittM/rust_db on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ShaneEverittM/rust_db [INFO] finished tweaking git repo https://github.com/ShaneEverittM/rust_db [INFO] tweaked toml for git repo https://github.com/ShaneEverittM/rust_db written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ShaneEverittM/rust_db already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6829aea4f79c8cef85bd27e25e8de0cb25ce9dd9ebfa07c7feb42bac005253d8 [INFO] running `Command { std: "docker" "start" "-a" "6829aea4f79c8cef85bd27e25e8de0cb25ce9dd9ebfa07c7feb42bac005253d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6829aea4f79c8cef85bd27e25e8de0cb25ce9dd9ebfa07c7feb42bac005253d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6829aea4f79c8cef85bd27e25e8de0cb25ce9dd9ebfa07c7feb42bac005253d8", kill_on_drop: false }` [INFO] [stdout] 6829aea4f79c8cef85bd27e25e8de0cb25ce9dd9ebfa07c7feb42bac005253d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e2b0873f54e19cfbec40e5152ca6445bb98df39bf7675887f520e250ce12b02b [INFO] running `Command { std: "docker" "start" "-a" "e2b0873f54e19cfbec40e5152ca6445bb98df39bf7675887f520e250ce12b02b", kill_on_drop: false }` [INFO] [stderr] Checking bytes v0.6.0 [INFO] [stderr] Checking rust_db v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_manager/file_handle.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | let mut file_handle_res = FileHandle::new(file); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/file_manager/file_handle.rs:168:13 [INFO] [stdout] | [INFO] [stdout] 168 | let mut file_handle_res = FileHandle::new(file); [INFO] [stdout] | ----^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PAGE_SIZE` is never used [INFO] [stdout] --> src/main.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const PAGE_SIZE: usize = 4096; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `read_count` is never read [INFO] [stdout] --> src/file_manager/file_handle.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct FileHandle { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | read_count: usize, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `write_counters` and `get_num_pages` are never used [INFO] [stdout] --> src/file_manager/file_handle.rs:56:8 [INFO] [stdout] | [INFO] [stdout] 16 | impl FileHandle { [INFO] [stdout] | --------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 56 | fn write_counters(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 115 | pub fn get_num_pages(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_manager/file_handle.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(mut file: File) -> std::result::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | num_pages, [INFO] [stdout] 49 | | file, [INFO] [stdout] 50 | | write_count, [INFO] [stdout] 51 | | read_count, [INFO] [stdout] 52 | | append_count, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/file_manager/file_handle.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | std::fs::remove_file(file_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 154 | let _ = std::fs::remove_file(file_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/file_manager/file_handle.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | std::fs::remove_file(file_name); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 209 | let _ = std::fs::remove_file(file_name); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_db` (bin "rust_db" test) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `PAGE_SIZE` is never used [INFO] [stdout] --> src/main.rs:1:7 [INFO] [stdout] | [INFO] [stdout] 1 | const PAGE_SIZE: usize = 4096; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PAGE_SIZE` is never used [INFO] [stdout] --> src/file_manager/file_handle.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | const PAGE_SIZE: usize = 4096; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FileHandle` is never constructed [INFO] [stdout] --> src/file_manager/file_handle.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct FileHandle { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/file_manager/file_handle.rs:17:12 [INFO] [stdout] | [INFO] [stdout] 16 | impl FileHandle { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] 17 | pub fn new(mut file: File) -> std::result::Result { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 56 | fn write_counters(&mut self) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 71 | pub fn read_page(&mut self, page_num: usize, data: &mut BytesMut) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 83 | fn read_from(&mut self, pos: u64, data: &mut BytesMut) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 91 | pub fn write_page(&mut self, page_num: usize, data: &BytesMut) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 103 | fn write_to(&mut self, pos: u64, data: &BytesMut) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 108 | pub fn append_page(&mut self, data: &BytesMut) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 115 | pub fn get_num_pages(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file_manager/file_handle.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(mut file: File) -> std::result::Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | num_pages, [INFO] [stdout] 49 | | file, [INFO] [stdout] 50 | | write_count, [INFO] [stdout] 51 | | read_count, [INFO] [stdout] 52 | | append_count, [INFO] [stdout] 53 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_db` (bin "rust_db") due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e2b0873f54e19cfbec40e5152ca6445bb98df39bf7675887f520e250ce12b02b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2b0873f54e19cfbec40e5152ca6445bb98df39bf7675887f520e250ce12b02b", kill_on_drop: false }` [INFO] [stdout] e2b0873f54e19cfbec40e5152ca6445bb98df39bf7675887f520e250ce12b02b