[INFO] cloning repository https://github.com/Seveen/dom5save-scummer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Seveen/dom5save-scummer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSeveen%2Fdom5save-scummer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSeveen%2Fdom5save-scummer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 71c48d224b2457c26b45b4e09939ad35749135fc [INFO] checking Seveen/dom5save-scummer/71c48d224b2457c26b45b4e09939ad35749135fc against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSeveen%2Fdom5save-scummer" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Seveen/dom5save-scummer on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Seveen/dom5save-scummer [INFO] finished tweaking git repo https://github.com/Seveen/dom5save-scummer [INFO] tweaked toml for git repo https://github.com/Seveen/dom5save-scummer written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Seveen/dom5save-scummer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28cb9a313801fcd3fb8de13034a6f127dcaad4e786f45f13d0e24f049ca680f3 [INFO] running `Command { std: "docker" "start" "-a" "28cb9a313801fcd3fb8de13034a6f127dcaad4e786f45f13d0e24f049ca680f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28cb9a313801fcd3fb8de13034a6f127dcaad4e786f45f13d0e24f049ca680f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28cb9a313801fcd3fb8de13034a6f127dcaad4e786f45f13d0e24f049ca680f3", kill_on_drop: false }` [INFO] [stdout] 28cb9a313801fcd3fb8de13034a6f127dcaad4e786f45f13d0e24f049ca680f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 51ce774e9a6b67be9a741be7a9a1bb7ec7ee29165fbf3c420231662f83e546ad [INFO] running `Command { std: "docker" "start" "-a" "51ce774e9a6b67be9a741be7a9a1bb7ec7ee29165fbf3c420231662f83e546ad", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling serde v1.0.136 [INFO] [stderr] Compiling anyhow v1.0.56 [INFO] [stderr] Compiling unicode-segmentation v1.9.0 [INFO] [stderr] Compiling smallvec v1.8.0 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling strum v0.21.0 [INFO] [stderr] Compiling version-compare v0.0.11 [INFO] [stderr] Compiling libc v0.2.123 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Checking once_cell v1.10.0 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Compiling itertools v0.10.3 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling gio v0.14.8 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Compiling cfg-expr v0.8.1 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking tinystr v0.3.4 [INFO] [stderr] Checking tracing-core v0.1.25 [INFO] [stderr] Checking unic-ucd-bidi v0.9.0 [INFO] [stderr] Compiling gtk v0.14.3 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking kurbo v0.8.3 [INFO] [stderr] Checking unic-langid-impl v0.9.0 [INFO] [stderr] Checking xi-unicode v0.3.0 [INFO] [stderr] Checking unic-bidi v0.9.0 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking num_threads v0.1.5 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking unic-langid v0.9.0 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Checking type-map v0.4.0 [INFO] [stderr] Checking bitmaps v2.1.0 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking keyboard-types v0.6.2 [INFO] [stderr] Compiling im v15.0.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking intl-memoizer v0.5.1 [INFO] [stderr] Checking fluent-langneg v0.13.0 [INFO] [stderr] Checking intl_pluralrules v7.0.1 [INFO] [stderr] Checking rand_xoshiro v0.4.0 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking self_cell v0.10.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling field-offset v0.3.4 [INFO] [stderr] Checking piet v0.5.0 [INFO] [stderr] Compiling druid-shell v0.7.0 (https://github.com/linebender/druid?rev=fc05e965c85fced8720c655685e02478e0530e94#fc05e965) [INFO] [stderr] Compiling druid-shell v0.7.0 (https://github.com/linebender/druid.git#aa4b3665) [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking filetime v0.2.15 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking sized-chunks v0.6.5 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking tracing-subscriber v0.3.11 [INFO] [stderr] Checking notify v4.0.17 [INFO] [stderr] Checking futures-executor v0.3.21 [INFO] [stderr] Compiling toml v0.5.8 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling druid-derive v0.4.0 (https://github.com/linebender/druid?rev=fc05e965c85fced8720c655685e02478e0530e94#fc05e965) [INFO] [stderr] Compiling druid-derive v0.4.0 (https://github.com/linebender/druid.git#aa4b3665) [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Compiling thiserror v1.0.30 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Checking fluent-syntax v0.11.0 [INFO] [stderr] Compiling system-deps v3.2.0 [INFO] [stderr] Compiling glib-macros v0.14.1 [INFO] [stderr] Compiling gtk3-macros v0.14.0 [INFO] [stderr] Checking fluent-bundle v0.15.2 [INFO] [stderr] Compiling glib-sys v0.14.0 [INFO] [stderr] Compiling gobject-sys v0.14.0 [INFO] [stderr] Compiling cairo-sys-rs v0.14.9 [INFO] [stderr] Compiling pango-sys v0.14.0 [INFO] [stderr] Compiling gio-sys v0.14.0 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.14.0 [INFO] [stderr] Compiling gdk-sys v0.14.0 [INFO] [stderr] Compiling atk-sys v0.14.0 [INFO] [stderr] Compiling gtk-sys v0.14.0 [INFO] [stderr] Compiling pangocairo-sys v0.14.0 [INFO] [stderr] Checking glib v0.14.8 [INFO] [stderr] Checking cairo-rs v0.14.9 [INFO] [stderr] Checking pango v0.14.8 [INFO] [stderr] Checking atk v0.14.0 [INFO] [stderr] Checking pangocairo v0.14.0 [INFO] [stderr] Checking piet-cairo v0.5.0 [INFO] [stderr] Checking piet-common v0.5.0 [INFO] [stderr] Checking gdk-pixbuf v0.14.0 [INFO] [stderr] Checking gdk v0.14.3 [INFO] [stderr] Checking druid v0.7.0 (https://github.com/linebender/druid?rev=fc05e965c85fced8720c655685e02478e0530e94#fc05e965) [INFO] [stderr] Checking druid v0.7.0 (https://github.com/linebender/druid.git#aa4b3665) [INFO] [stderr] Checking druid-widget-nursery v0.1.0 (https://github.com/linebender/druid-widget-nursery#f6710e79) [INFO] [stderr] Checking dom-save-scummer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 17 | let window = WindowDesc::new(build_ui()).title("Dom5SaveScummer"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let launcher = AppLauncher::::with_window(window).delegate(Delegate {}); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | match get_initial_state() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 67 | let mut container = Flex::row(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let either_archiving = Either::new( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let either_restoring = Either::new( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let mut button_column = Flex::column().main_axis_alignment(MainAxisAlignment::SpaceEvenly); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let mut sub_column = Flex::column(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | select_saved_games_dir(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn list(lens: impl Lens, Vector)>) -> impl Widget { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | / Scroll::new( [INFO] [stdout] 148 | | List::new(|| { [INFO] [stdout] 149 | | Label::dynamic(|data: &(Option, String), _| data.1.to_string()) [INFO] [stdout] 150 | | .on_click(|_, data: &mut (Option, String), _| data.0 = Some(data.1.clone())) [INFO] [stdout] ... | [INFO] [stdout] 162 | | .lens(lens), [INFO] [stdout] 163 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dom-save-scummer` (bin "dom-save-scummer") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 17 | let window = WindowDesc::new(build_ui()).title("Dom5SaveScummer"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let launcher = AppLauncher::::with_window(window).delegate(Delegate {}); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | match get_initial_state() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 67 | let mut container = Flex::row(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let either_archiving = Either::new( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | let either_restoring = Either::new( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let mut button_column = Flex::column().main_axis_alignment(MainAxisAlignment::SpaceEvenly); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | let mut sub_column = Flex::column(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | select_saved_games_dir(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 146 | pub fn list(lens: impl Lens, Vector)>) -> impl Widget { [INFO] [stdout] | -------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | / Scroll::new( [INFO] [stdout] 148 | | List::new(|| { [INFO] [stdout] 149 | | Label::dynamic(|data: &(Option, String), _| data.1.to_string()) [INFO] [stdout] 150 | | .on_click(|_, data: &mut (Option, String), _| data.0 = Some(data.1.clone())) [INFO] [stdout] ... | [INFO] [stdout] 162 | | .lens(lens), [INFO] [stdout] 163 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dom-save-scummer` (bin "dom-save-scummer" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "51ce774e9a6b67be9a741be7a9a1bb7ec7ee29165fbf3c420231662f83e546ad", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51ce774e9a6b67be9a741be7a9a1bb7ec7ee29165fbf3c420231662f83e546ad", kill_on_drop: false }` [INFO] [stdout] 51ce774e9a6b67be9a741be7a9a1bb7ec7ee29165fbf3c420231662f83e546ad