[INFO] cloning repository https://github.com/ScottLinnn/mylsm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ScottLinnn/mylsm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FScottLinnn%2Fmylsm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FScottLinnn%2Fmylsm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3f0a04dd4a0c12ebd528f3f53cc5bc148e8d03d5 [INFO] checking ScottLinnn/mylsm/3f0a04dd4a0c12ebd528f3f53cc5bc148e8d03d5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FScottLinnn%2Fmylsm" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ScottLinnn/mylsm on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ScottLinnn/mylsm [INFO] finished tweaking git repo https://github.com/ScottLinnn/mylsm [INFO] tweaked toml for git repo https://github.com/ScottLinnn/mylsm written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ScottLinnn/mylsm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4038cf06116ee33e6b491f0a127a98d64c874ff46a9f4c98abd83ad7276f8029 [INFO] running `Command { std: "docker" "start" "-a" "4038cf06116ee33e6b491f0a127a98d64c874ff46a9f4c98abd83ad7276f8029", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4038cf06116ee33e6b491f0a127a98d64c874ff46a9f4c98abd83ad7276f8029", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4038cf06116ee33e6b491f0a127a98d64c874ff46a9f4c98abd83ad7276f8029", kill_on_drop: false }` [INFO] [stdout] 4038cf06116ee33e6b491f0a127a98d64c874ff46a9f4c98abd83ad7276f8029 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f705d37d054b53f8011ea91f06f3b62668cf0b8880d2edfbd6706738c8c7f9f8 [INFO] running `Command { std: "docker" "start" "-a" "f705d37d054b53f8011ea91f06f3b62668cf0b8880d2edfbd6706738c8c7f9f8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling Inflector v0.11.4 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking raw-cpuid v10.7.0 [INFO] [stderr] Compiling moka v0.9.9 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking triomphe v0.1.11 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking aliasable v0.1.3 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking arc-swap v1.6.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Checking crossbeam-channel v0.5.10 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking quanta v0.11.1 [INFO] [stderr] Checking crossbeam-skiplist v0.1.2 [INFO] [stderr] Checking uuid v1.6.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking tempfile v3.9.0 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling ouroboros_macro v0.15.6 [INFO] [stderr] Checking ouroboros v0.15.6 [INFO] [stderr] Checking mini-lsm-starter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::f32::consts::E` [INFO] [stdout] --> src/iterators/two_merge_iterator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::f32::consts::E; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bytes::Bytes` [INFO] [stdout] --> src/iterators/two_merge_iterator.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use bytes::Bytes; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Bytes` [INFO] [stdout] --> src/table/iterator.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{io::Bytes, sync::Arc}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/table/iterator.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{Error, Ok, Result}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::f32::consts::E` [INFO] [stdout] --> src/iterators/two_merge_iterator.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use std::f32::consts::E; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `bytes::Bytes` [INFO] [stdout] --> src/iterators/two_merge_iterator.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use bytes::Bytes; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `io::Bytes` [INFO] [stdout] --> src/table/iterator.rs:4:11 [INFO] [stdout] | [INFO] [stdout] 4 | use std::{io::Bytes, sync::Arc}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Error` [INFO] [stdout] --> src/table/iterator.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | use anyhow::{Error, Ok, Result}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `end_offset` is never read [INFO] [stdout] --> src/table.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | let mut end_offset: u64 = 0u64; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | inner: Arc::new(RwLock::new(Arc::new(LsmStorageInner::create()))), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:59:72 [INFO] [stdout] | [INFO] [stdout] 45 | let lower_bound = match lower { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let upper_bound = match upper { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | iter_builder: |map: &Arc>| map.range((lower_bound, upper_bound)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:64:75 [INFO] [stdout] | [INFO] [stdout] 64 | let entry = it.with_iter_mut(|it| MemTableIterator::entry_to_item(it.next())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 92 | fn entry_to_item(entry: Option>) -> (Bytes, Bytes) { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | / entry [INFO] [stdout] 94 | | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:94:23 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:94:40 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:95:58 [INFO] [stdout] | [INFO] [stdout] 95 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:113:79 [INFO] [stdout] | [INFO] [stdout] 113 | let entry = self.with_iter_mut(|iter| MemTableIterator::entry_to_item(iter.next())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn open(id: usize, block_cache: Option>, file: FileObject) -> Result { [INFO] [stdout] | ------------------------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let block_metas = BlockMeta::decode_block_meta(Bytes::from(block_metas_bytes)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | file, [INFO] [stdout] 143 | | block_metas, [INFO] [stdout] 144 | | block_meta_offset: block_meta_offset as usize, [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/builder.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 68 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | id: usize, [INFO] [stdout] 70 | block_cache: Option>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let bytes = built_block.encode(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let block_iter = BlockIterator::create_and_seek_to_first(Arc::new(built_block)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let fo = super::FileObject::create(path.as_ref(), buf); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | Ok(SsTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | file: fo.unwrap(), [INFO] [stdout] 92 | | block_metas: self.meta, [INFO] [stdout] 93 | | block_meta_offset: self.total_size, [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/iterator.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn create_and_seek_to_first(table: Arc) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let block = table.read_block(0).expect("Cannot read block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | table, [INFO] [stdout] 28 | | // block, [INFO] [stdout] 29 | | block_it: BlockIterator::create_and_seek_to_first(block), [INFO] [stdout] 30 | | idx: 0, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini-lsm-starter` (lib) due to 13 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: value assigned to `end_offset` is never read [INFO] [stdout] --> src/table.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | let mut end_offset: u64 = 0u64; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lsm_storage.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn open(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | inner: Arc::new(RwLock::new(Arc::new(LsmStorageInner::create()))), [INFO] [stdout] 55 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:59:72 [INFO] [stdout] | [INFO] [stdout] 45 | let lower_bound = match lower { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let upper_bound = match upper { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | iter_builder: |map: &Arc>| map.range((lower_bound, upper_bound)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:64:75 [INFO] [stdout] | [INFO] [stdout] 64 | let entry = it.with_iter_mut(|it| MemTableIterator::entry_to_item(it.next())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 92 | fn entry_to_item(entry: Option>) -> (Bytes, Bytes) { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | / entry [INFO] [stdout] 94 | | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | |__________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:94:23 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:94:40 [INFO] [stdout] | [INFO] [stdout] 94 | .map(|x| (x.key().clone(), x.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:95:33 [INFO] [stdout] | [INFO] [stdout] 95 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:95:58 [INFO] [stdout] | [INFO] [stdout] 95 | .unwrap_or_else(|| (Bytes::from_static(&[]), Bytes::from_static(&[]))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:113:79 [INFO] [stdout] | [INFO] [stdout] 113 | let entry = self.with_iter_mut(|iter| MemTableIterator::entry_to_item(iter.next())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:121:23 [INFO] [stdout] | [INFO] [stdout] 120 | pub(crate) fn open_for_test(file: FileObject) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Self::open(0, None, file) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn open(id: usize, block_cache: Option>, file: FileObject) -> Result { [INFO] [stdout] | ------------------------------------ ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | let block_metas = BlockMeta::decode_block_meta(Bytes::from(block_metas_bytes)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 142 | | file, [INFO] [stdout] 143 | | block_metas, [INFO] [stdout] 144 | | block_meta_offset: block_meta_offset as usize, [INFO] [stdout] 145 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/builder.rs:90:12 [INFO] [stdout] | [INFO] [stdout] 68 | mut self, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | id: usize, [INFO] [stdout] 70 | block_cache: Option>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | path: impl AsRef, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let bytes = built_block.encode(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let block_iter = BlockIterator::create_and_seek_to_first(Arc::new(built_block)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let fo = super::FileObject::create(path.as_ref(), buf); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | [INFO] [stdout] 90 | Ok(SsTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 91 | | file: fo.unwrap(), [INFO] [stdout] 92 | | block_metas: self.meta, [INFO] [stdout] 93 | | block_meta_offset: self.total_size, [INFO] [stdout] 94 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/builder.rs:99:23 [INFO] [stdout] | [INFO] [stdout] 98 | pub(crate) fn build_for_test(self, path: impl AsRef) -> Result { [INFO] [stdout] | ---- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | self.build(0, None, path) [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/iterator.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn create_and_seek_to_first(table: Arc) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let block = table.read_block(0).expect("Cannot read block"); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 27 | | table, [INFO] [stdout] 28 | | // block, [INFO] [stdout] 29 | | block_it: BlockIterator::create_and_seek_to_first(block), [INFO] [stdout] 30 | | idx: 0, [INFO] [stdout] 31 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/table/tests.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 45 | let mut builder = SsTableBuilder::new(128); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | let dir: TempDir = tempdir().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let path = dir.path().join("1.sst"); [INFO] [stdout] 53 | (dir, builder.build_for_test(path).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `mini-lsm-starter` (lib test) due to 16 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f705d37d054b53f8011ea91f06f3b62668cf0b8880d2edfbd6706738c8c7f9f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f705d37d054b53f8011ea91f06f3b62668cf0b8880d2edfbd6706738c8c7f9f8", kill_on_drop: false }` [INFO] [stdout] f705d37d054b53f8011ea91f06f3b62668cf0b8880d2edfbd6706738c8c7f9f8