[INFO] cloning repository https://github.com/Schottkyc137/ginko [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Schottkyc137/ginko" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSchottkyc137%2Fginko", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSchottkyc137%2Fginko'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e09f93bdf850b35bc8a4a9642f94220cc4ae1b4b [INFO] checking Schottkyc137/ginko/e09f93bdf850b35bc8a4a9642f94220cc4ae1b4b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSchottkyc137%2Fginko" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Schottkyc137/ginko on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Schottkyc137/ginko [INFO] finished tweaking git repo https://github.com/Schottkyc137/ginko [INFO] tweaked toml for git repo https://github.com/Schottkyc137/ginko written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Schottkyc137/ginko already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d495a5b3f6878f43ee0625b52af2d0145fd1e2f6f78eb4693f313cb6dea251eb [INFO] running `Command { std: "docker" "start" "-a" "d495a5b3f6878f43ee0625b52af2d0145fd1e2f6f78eb4693f313cb6dea251eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d495a5b3f6878f43ee0625b52af2d0145fd1e2f6f78eb4693f313cb6dea251eb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d495a5b3f6878f43ee0625b52af2d0145fd1e2f6f78eb4693f313cb6dea251eb", kill_on_drop: false }` [INFO] [stdout] d495a5b3f6878f43ee0625b52af2d0145fd1e2f6f78eb4693f313cb6dea251eb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2adc1d82b6d921bc48ee1d1d134f284e7d59b1a0dc1a59743417aa838fa738f7 [INFO] running `Command { std: "docker" "start" "-a" "2adc1d82b6d921bc48ee1d1d134f284e7d59b1a0dc1a59743417aa838fa738f7", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking assert_unordered v0.3.5 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking clap_builder v4.5.10 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling auto_impl v1.2.0 [INFO] [stderr] Compiling tower-lsp-macros v0.9.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking clap v4.5.10 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking ginko v0.0.6 (/opt/rustwide/workdir/ginko) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/analysis.rs:94:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn into_result(self) -> AnalysisResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | AnalysisResult { [INFO] [stdout] 94 | context: AnalysisContext { [INFO] [stdout] | ______________________^ [INFO] [stdout] 95 | | flat_nodes: self.flat_nodes, [INFO] [stdout] 96 | | labels: self.labels, [INFO] [stdout] 97 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/diagnostics.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn from_token(token: Token, kind: ErrorCode, message: impl Into) -> Diagnostic { [INFO] [stdout] | ------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | source: token.source(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(lexer: Lexer, context: ParserContext) -> Parser { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Parser { [INFO] [stdout] 39 | lexer: PeekingLexer::from(lexer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 49 | text: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | source: Arc, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ) -> Parser { [INFO] [stdout] 52 | let lexer = Lexer::from_text(text, source); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Parser { [INFO] [stdout] 54 | lexer: lexer.into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:453:13 [INFO] [stdout] | [INFO] [stdout] 448 | let tok = self.lexer.expect_next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | Err(Diagnostic::expected( [INFO] [stdout] | _____________^ [INFO] [stdout] 454 | | tok.span(), [INFO] [stdout] 455 | | tok.source(), [INFO] [stdout] 456 | | &[TokenKind::Ident("".to_string())], [INFO] [stdout] 457 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:467:13 [INFO] [stdout] | [INFO] [stdout] 461 | let tok = self.lexer.expect_next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | Err(Diagnostic::expected( [INFO] [stdout] | _____________^ [INFO] [stdout] 468 | | tok.span(), [INFO] [stdout] 469 | | tok.source(), [INFO] [stdout] 470 | | &[TokenKind::Ident("".to_string())], [INFO] [stdout] 471 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:603:12 [INFO] [stdout] | [INFO] [stdout] 475 | let end: Token; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | self.lexer.expect(TokenKind::OpenBrace)?; [INFO] [stdout] 477 | let mut items: Vec = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | Ok(NodePayload { items, end }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:653:12 [INFO] [stdout] | [INFO] [stdout] 642 | let tok = self.lexer.expect_next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:661:12 [INFO] [stdout] | [INFO] [stdout] 657 | let mut elements: Vec = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 661 | Ok(DtsFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 662 | | elements, [INFO] [stdout] 663 | | source: self.lexer.source(), [INFO] [stdout] 664 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 28 | diagnostics: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | file: DtsFile, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | file: Some(file), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 28 | diagnostics: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | file: DtsFile, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | context: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn unrecoverable(err: Diagnostic, source: String, file_type: FileType) -> ProjectFile { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | file: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn unrecoverable(err: Diagnostic, source: String, file_type: FileType) -> ProjectFile { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | context: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|path| dunce::canonicalize(path).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:281:15 [INFO] [stdout] | [INFO] [stdout] 272 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | match fs::read_to_string(&canonicalized_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/reader.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn from_read(mut read: impl Read) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(ByteReader::from_string(str)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn from_text(text: impl Into, source: Arc) -> Lexer { [INFO] [stdout] | ----------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Lexer::new(ByteReader::from_string(text.into()), source) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:291:18 [INFO] [stdout] | [INFO] [stdout] 288 | let source = self.source(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | Some(Token { [INFO] [stdout] | __________________^ [INFO] [stdout] 292 | | kind, [INFO] [stdout] 293 | | span: start_pos.to(self.reader.pos()), [INFO] [stdout] 294 | | source, [INFO] [stdout] 295 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 381 | fn from(value: Lexer) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | peeked: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ginko` (lib) due to 20 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/analysis.rs:94:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn into_result(self) -> AnalysisResult { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | AnalysisResult { [INFO] [stdout] 94 | context: AnalysisContext { [INFO] [stdout] | ______________________^ [INFO] [stdout] 95 | | flat_nodes: self.flat_nodes, [INFO] [stdout] 96 | | labels: self.labels, [INFO] [stdout] 97 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/diagnostics.rs:104:21 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn from_token(token: Token, kind: ErrorCode, message: impl Into) -> Diagnostic { [INFO] [stdout] | ------------ -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | source: token.source(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn new(lexer: Lexer, context: ParserContext) -> Parser { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Parser { [INFO] [stdout] 39 | lexer: PeekingLexer::from(lexer), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:54:20 [INFO] [stdout] | [INFO] [stdout] 49 | text: impl Into, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | source: Arc, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | ) -> Parser { [INFO] [stdout] 52 | let lexer = Lexer::from_text(text, source); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Parser { [INFO] [stdout] 54 | lexer: lexer.into(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:453:13 [INFO] [stdout] | [INFO] [stdout] 448 | let tok = self.lexer.expect_next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 453 | Err(Diagnostic::expected( [INFO] [stdout] | _____________^ [INFO] [stdout] 454 | | tok.span(), [INFO] [stdout] 455 | | tok.source(), [INFO] [stdout] 456 | | &[TokenKind::Ident("".to_string())], [INFO] [stdout] 457 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:467:13 [INFO] [stdout] | [INFO] [stdout] 461 | let tok = self.lexer.expect_next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | Err(Diagnostic::expected( [INFO] [stdout] | _____________^ [INFO] [stdout] 468 | | tok.span(), [INFO] [stdout] 469 | | tok.source(), [INFO] [stdout] 470 | | &[TokenKind::Ident("".to_string())], [INFO] [stdout] 471 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:603:12 [INFO] [stdout] | [INFO] [stdout] 475 | let end: Token; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 476 | self.lexer.expect(TokenKind::OpenBrace)?; [INFO] [stdout] 477 | let mut items: Vec = vec![]; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | Ok(NodePayload { items, end }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:653:12 [INFO] [stdout] | [INFO] [stdout] 642 | let tok = self.lexer.expect_next()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | Ok(None) [INFO] [stdout] | ^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:661:12 [INFO] [stdout] | [INFO] [stdout] 657 | let mut elements: Vec = vec![]; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 661 | Ok(DtsFile { [INFO] [stdout] | ____________^ [INFO] [stdout] 662 | | elements, [INFO] [stdout] 663 | | source: self.lexer.source(), [INFO] [stdout] 664 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:994:13 [INFO] [stdout] | [INFO] [stdout] 989 | let code = Code::new("/ {};"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 990 | let node = code.parse_ok_no_diagnostics(Parser::file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 994 | / DtsFile { [INFO] [stdout] 995 | | elements: vec![Primary::Root(Arc::new(Node { [INFO] [stdout] 996 | | label: None, [INFO] [stdout] 997 | | name: WithToken::new(NodeName::simple("/"), code.s1("/").token()), [INFO] [stdout] ... | [INFO] [stdout] 1004 | | source: code.source(), [INFO] [stdout] 1005 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:1020:13 [INFO] [stdout] | [INFO] [stdout] 1011 | let code = Code::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1017 | let node = code.parse_ok_no_diagnostics(Parser::file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1020 | / DtsFile { [INFO] [stdout] 1021 | | elements: vec![ [INFO] [stdout] 1022 | | Primary::Directive(AnyDirective::DtsHeader(code.s1("/dts-v1/").token())), [INFO] [stdout] 1023 | | Primary::Root(Arc::new(Node { [INFO] [stdout] ... | [INFO] [stdout] 1033 | | source: code.source(), [INFO] [stdout] 1034 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:1053:13 [INFO] [stdout] | [INFO] [stdout] 1040 | let code = Code::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1050 | let node = code.parse_ok_no_diagnostics(Parser::file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1053 | / DtsFile { [INFO] [stdout] 1054 | | elements: vec![ [INFO] [stdout] 1055 | | Primary::Directive(AnyDirective::DtsHeader(code.s1("/dts-v1/").token())), [INFO] [stdout] 1056 | | Primary::Root(Arc::new(Node { [INFO] [stdout] ... | [INFO] [stdout] 1080 | | source: code.source(), [INFO] [stdout] 1081 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:1102:13 [INFO] [stdout] | [INFO] [stdout] 1087 | let code = Code::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1099 | let node = code.parse_ok_no_diagnostics(Parser::file); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1102 | / DtsFile { [INFO] [stdout] 1103 | | elements: vec![ [INFO] [stdout] 1104 | | Primary::Directive(AnyDirective::DtsHeader(code.s1("/dts-v1/").token())), [INFO] [stdout] 1105 | | Primary::Root(Arc::new(Node { [INFO] [stdout] ... | [INFO] [stdout] 1158 | | source: code.source(), [INFO] [stdout] 1159 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/parser.rs:1297:13 [INFO] [stdout] | [INFO] [stdout] 1283 | let code = Code::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1293 | let (res, _) = code.parse(Parser::file); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1297 | / Err(Diagnostic::expected( [INFO] [stdout] 1298 | | code.s1("prop_a").end().as_span(), [INFO] [stdout] 1299 | | code.source(), [INFO] [stdout] 1300 | | &[Semicolon, Equal, OpenBrace, Directive(OmitIfNoRef)], [INFO] [stdout] 1301 | | )) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:35:19 [INFO] [stdout] | [INFO] [stdout] 28 | diagnostics: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | file: DtsFile, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | file: Some(file), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:37:22 [INFO] [stdout] | [INFO] [stdout] 28 | diagnostics: Vec, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | file: DtsFile, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | context: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn unrecoverable(err: Diagnostic, source: String, file_type: FileType) -> ProjectFile { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | file: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 43 | pub fn unrecoverable(err: Diagnostic, source: String, file_type: FileType) -> ProjectFile { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | context: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | .map(|path| dunce::canonicalize(path).unwrap_or_default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:281:15 [INFO] [stdout] | [INFO] [stdout] 272 | Err(err) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | match fs::read_to_string(&canonicalized_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:341:17 [INFO] [stdout] | [INFO] [stdout] 338 | pub fn new_file(&self, name: impl AsRef) -> (File, PathBuf) { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | File::create(&file_path).expect("Cannot create temporary file"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/project.rs:444:15 [INFO] [stdout] | [INFO] [stdout] 381 | let mut project = Project::default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | let temp_dir = TempDir::new(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | let (code1, file1) = temp_dir.add_file( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | let (code2, file2) = temp_dir.add_file( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | let substr = code2.s1("&some_node"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 436 | let substr = code2.s1("&{/node_a}"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | match project.get_node_position(&file2, reference) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/reader.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn from_read(mut read: impl Read) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(ByteReader::from_string(str)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/test.rs:92:10 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn parse(&self, parse_fn: F) -> (Result, Vec) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | let mut reader = ByteReader::from_string(self.code.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | reader.seek(self.pos.start()); [INFO] [stdout] 90 | let lexer = Lexer::new(reader, self.source.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let mut parser = Parser::new(lexer, self.parser_context.clone()); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | (parse_fn(&mut parser), parser.diagnostics) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/test.rs:100:10 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn parse_ok(&self, parse_fn: F) -> (T, Vec) [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | let (res, diagnostics) = self.parse(parse_fn); [INFO] [stdout] | --- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | (res.expect("Unexpectedly found non-ok value"), diagnostics) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/test.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 147 | let mut byte_reader = ByteReader::from_string(self.code.clone()); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | byte_reader.seek(self.pos.start()); [INFO] [stdout] 149 | / Lexer::new(byte_reader, self.source.clone()) [INFO] [stdout] 150 | | .next() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:27:20 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn from_text(text: impl Into, source: Arc) -> Lexer { [INFO] [stdout] | ----------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | Lexer::new(ByteReader::from_string(text.into()), source) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:291:18 [INFO] [stdout] | [INFO] [stdout] 288 | let source = self.source(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | Some(Token { [INFO] [stdout] | __________________^ [INFO] [stdout] 292 | | kind, [INFO] [stdout] 293 | | span: start_pos.to(self.reader.pos()), [INFO] [stdout] 294 | | source, [INFO] [stdout] 295 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:384:21 [INFO] [stdout] | [INFO] [stdout] 381 | fn from(value: Lexer) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 384 | peeked: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:530:10 [INFO] [stdout] | [INFO] [stdout] 528 | fn tokenize_fully(string: impl Into) -> (Vec, Arc) { [INFO] [stdout] | -------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 529 | let (source, lexer) = new_lexer(string.into().as_str()); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 530 | (lexer.collect(), source) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:592:13 [INFO] [stdout] | [INFO] [stdout] 581 | let (source, mut lexer) = new_lexer("&ref"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 590 | let (source, mut lexer) = new_lexer("&ref0_from_4"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 591 | assert_eq!( [INFO] [stdout] 592 | lexer.next_expect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:593:13 [INFO] [stdout] | [INFO] [stdout] 581 | let (source, mut lexer) = new_lexer("&ref"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 590 | let (source, mut lexer) = new_lexer("&ref0_from_4"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | / Token { [INFO] [stdout] 594 | | span: Position::zero().to(Position::new(0, 12)), [INFO] [stdout] 595 | | kind: Ref(Reference::Simple("ref0_from_4".into())), [INFO] [stdout] 596 | | source: source.clone(), [INFO] [stdout] 597 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:622:13 [INFO] [stdout] | [INFO] [stdout] 603 | let (source, mut lexer) = new_lexer("node@addr"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let (source, mut lexer) = new_lexer("node@addr@"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 622 | lexer.next(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:623:13 [INFO] [stdout] | [INFO] [stdout] 603 | let (source, mut lexer) = new_lexer("node@addr"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | let (source, mut lexer) = new_lexer("node@addr@"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 623 | / Some(Token { [INFO] [stdout] 624 | | span: Position::new(0, 9).as_char_span(), [INFO] [stdout] 625 | | kind: Unknown(b'@'), [INFO] [stdout] 626 | | source: source.clone(), [INFO] [stdout] 627 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:841:13 [INFO] [stdout] | [INFO] [stdout] 829 | let (source, mut lexer) = new_lexer("/dts-v1/"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 839 | let (source, mut lexer) = new_lexer("/undefined/"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 840 | assert_eq!( [INFO] [stdout] 841 | lexer.next_expect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> ginko/src/dts/tokens/lexer.rs:842:13 [INFO] [stdout] | [INFO] [stdout] 829 | let (source, mut lexer) = new_lexer("/dts-v1/"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 839 | let (source, mut lexer) = new_lexer("/undefined/"); [INFO] [stdout] | ------ ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 842 | / Token { [INFO] [stdout] 843 | | span: Position::zero().char_to(11), [INFO] [stdout] 844 | | kind: Directive(CompilerDirective::Other("undefined".into())), [INFO] [stdout] 845 | | source: source.clone(), [INFO] [stdout] 846 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 36 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ginko` (lib test) due to 37 previous errors [INFO] running `Command { std: "docker" "inspect" "2adc1d82b6d921bc48ee1d1d134f284e7d59b1a0dc1a59743417aa838fa738f7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2adc1d82b6d921bc48ee1d1d134f284e7d59b1a0dc1a59743417aa838fa738f7", kill_on_drop: false }` [INFO] [stdout] 2adc1d82b6d921bc48ee1d1d134f284e7d59b1a0dc1a59743417aa838fa738f7