[INFO] cloning repository https://github.com/Sammy99jsp/AvConfig-Research [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sammy99jsp/AvConfig-Research" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSammy99jsp%2FAvConfig-Research", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSammy99jsp%2FAvConfig-Research'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c4d48606284b2e117360f2bfd111ded77e893b70 [INFO] checking Sammy99jsp/AvConfig-Research/c4d48606284b2e117360f2bfd111ded77e893b70 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSammy99jsp%2FAvConfig-Research" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Sammy99jsp/AvConfig-Research on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Sammy99jsp/AvConfig-Research [INFO] finished tweaking git repo https://github.com/Sammy99jsp/AvConfig-Research [INFO] tweaked toml for git repo https://github.com/Sammy99jsp/AvConfig-Research written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Sammy99jsp/AvConfig-Research already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56141d57227e1d91e1b99834c8104a56ebd95f0bc58648e864d6f54051230e1c [INFO] running `Command { std: "docker" "start" "-a" "56141d57227e1d91e1b99834c8104a56ebd95f0bc58648e864d6f54051230e1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56141d57227e1d91e1b99834c8104a56ebd95f0bc58648e864d6f54051230e1c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56141d57227e1d91e1b99834c8104a56ebd95f0bc58648e864d6f54051230e1c", kill_on_drop: false }` [INFO] [stdout] 56141d57227e1d91e1b99834c8104a56ebd95f0bc58648e864d6f54051230e1c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c3bbdf653cf88b5bed9dc8b1c796a2d6cc2862389218286cc65f1b60de460a50 [INFO] running `Command { std: "docker" "start" "-a" "c3bbdf653cf88b5bed9dc8b1c796a2d6cc2862389218286cc65f1b60de460a50", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.2.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Compiling backtrace v0.3.71 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking notify v6.1.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking color-eyre v0.6.3 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking avdanos-research v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ConfigResult` [INFO] [stdout] --> src/main.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use config3::{ConfigResult, ConfigurationFile, FileHander}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::Duration` [INFO] [stdout] --> src/config2/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | time::Duration, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ConfigResult` [INFO] [stdout] --> src/main.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use config3::{ConfigResult, ConfigurationFile, FileHander}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `time::Duration` [INFO] [stdout] --> src/config2/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | time::Duration, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `CONFIG` is never used [INFO] [stdout] --> src/config/mod.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | static CONFIG: OnceLock = OnceLock::new(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/config/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct RefreshingConfigFile { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] 9 | path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config2/mod.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 63 | fn file_saver(path: &Path, mut rx: watch::Receiver) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let path = path.to_owned(); [INFO] [stdout] 65 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 66 | | while let Ok(()) = rx.changed().await { [INFO] [stdout] 67 | | println!("Written!"); [INFO] [stdout] 68 | | let contents = rx.borrow(); [INFO] [stdout] 69 | | std::fs::write(&path, contents.as_bytes()).unwrap(); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config2/mod.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 76 | let (tx, rx) = watch::channel(std::fs::read_to_string(&path)?); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let watcher = Self::file_watcher(&path, tx.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let saver = Self::file_saver(&path, rx.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | path, [INFO] [stdout] 81 | | watcher, [INFO] [stdout] 82 | | saver, [INFO] [stdout] 83 | | rx, [INFO] [stdout] 84 | | tx, [INFO] [stdout] 85 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: static `CONFIG` is never used [INFO] [stdout] --> src/config/mod.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | static CONFIG: OnceLock = OnceLock::new(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/config/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct RefreshingConfigFile { [INFO] [stdout] | -------------------- field in this struct [INFO] [stdout] 9 | path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config2/mod.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 154 | let (raw_tx, mut raw_rx) = (file.tx.clone(), file.rx.clone()); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | let initial_value = match serde_json::from_str::(&std::fs::read_to_string(file.path())?) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | { [INFO] [stdout] 158 | Ok(v) => ConfigResult::Valid(v), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Err(err) => ConfigResult::Invalid(T::default(), err.to_string()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let (config_tx, mut config_rx) = watch::channel(initial_value); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let config_tx2 = config_tx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let deserializer_thread = tokio::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let config_rx2 = config_rx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let serializer_thread = tokio::spawn(async move { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 208 | | serializer_thread, [INFO] [stdout] 209 | | deserializer_thread, [INFO] [stdout] 210 | | rx: config_rx, [INFO] [stdout] 211 | | tx: config_tx, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config3/file_handler.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 69 | fn file_saver(path: &Path, mut rx: watch::Receiver) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let path = path.to_owned(); [INFO] [stdout] 71 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 72 | | while let Ok(()) = rx.changed().await { [INFO] [stdout] 73 | | let contents = rx.borrow(); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config2/mod.rs:65:22 [INFO] [stdout] | [INFO] [stdout] 63 | fn file_saver(path: &Path, mut rx: watch::Receiver) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | let path = path.to_owned(); [INFO] [stdout] 65 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 66 | | while let Ok(()) = rx.changed().await { [INFO] [stdout] 67 | | println!("Written!"); [INFO] [stdout] 68 | | let contents = rx.borrow(); [INFO] [stdout] 69 | | std::fs::write(&path, contents.as_bytes()).unwrap(); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config3/file_handler.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 88 | let (tx, rx) = watch::channel(std::fs::read_to_string(&path)?); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let watcher = Self::file_watcher(&path, tx.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let saver = Self::file_saver(&path, rx.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | path, [INFO] [stdout] 93 | | watcher, [INFO] [stdout] 94 | | saver, [INFO] [stdout] 95 | | rx, [INFO] [stdout] 96 | | tx, [INFO] [stdout] 97 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config2/mod.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 74 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 76 | let (tx, rx) = watch::channel(std::fs::read_to_string(&path)?); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | let watcher = Self::file_watcher(&path, tx.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | let saver = Self::file_saver(&path, rx.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 80 | | path, [INFO] [stdout] 81 | | watcher, [INFO] [stdout] 82 | | saver, [INFO] [stdout] 83 | | rx, [INFO] [stdout] 84 | | tx, [INFO] [stdout] 85 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config3/config_file.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 69 | let (raw_tx, mut raw_rx) = (file.tx(), file.rx()); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let initial_value = match serde_json::from_str::(&std::fs::read_to_string(file.path())?) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | { [INFO] [stdout] 73 | Ok(v) => ConfigResult::Valid(v), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Err(err) => ConfigResult::Invalid(T::default(), err.to_string()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let (config_tx, mut config_rx) = watch::channel(initial_value); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let config_tx2 = config_tx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let deserializer_thread = tokio::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let config_rx2 = config_rx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let serializer_thread = tokio::spawn(async move { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | serializer_thread, [INFO] [stdout] 131 | | deserializer_thread, [INFO] [stdout] 132 | | rx: config_rx, [INFO] [stdout] 133 | | tx: config_tx, [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config2/mod.rs:207:12 [INFO] [stdout] | [INFO] [stdout] 154 | let (raw_tx, mut raw_rx) = (file.tx.clone(), file.rx.clone()); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | [INFO] [stdout] 156 | let initial_value = match serde_json::from_str::(&std::fs::read_to_string(file.path())?) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | { [INFO] [stdout] 158 | Ok(v) => ConfigResult::Valid(v), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | Err(err) => ConfigResult::Invalid(T::default(), err.to_string()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | let (config_tx, mut config_rx) = watch::channel(initial_value); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let config_tx2 = config_tx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let deserializer_thread = tokio::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | let config_rx2 = config_rx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let serializer_thread = tokio::spawn(async move { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 208 | | serializer_thread, [INFO] [stdout] 209 | | deserializer_thread, [INFO] [stdout] 210 | | rx: config_rx, [INFO] [stdout] 211 | | tx: config_tx, [INFO] [stdout] 212 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config3/file_handler.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 69 | fn file_saver(path: &Path, mut rx: watch::Receiver) -> JoinHandle<()> { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let path = path.to_owned(); [INFO] [stdout] 71 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 72 | | while let Ok(()) = rx.changed().await { [INFO] [stdout] 73 | | let contents = rx.borrow(); [INFO] [stdout] ... | [INFO] [stdout] 82 | | } [INFO] [stdout] 83 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config3/file_handler.rs:91:12 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new(path: impl AsRef) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let path = path.as_ref().to_path_buf(); [INFO] [stdout] 88 | let (tx, rx) = watch::channel(std::fs::read_to_string(&path)?); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | let watcher = Self::file_watcher(&path, tx.clone())?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let saver = Self::file_saver(&path, rx.clone()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 92 | | path, [INFO] [stdout] 93 | | watcher, [INFO] [stdout] 94 | | saver, [INFO] [stdout] 95 | | rx, [INFO] [stdout] 96 | | tx, [INFO] [stdout] 97 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config3/config_file.rs:129:12 [INFO] [stdout] | [INFO] [stdout] 69 | let (raw_tx, mut raw_rx) = (file.tx(), file.rx()); [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | [INFO] [stdout] 71 | let initial_value = match serde_json::from_str::(&std::fs::read_to_string(file.path())?) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | { [INFO] [stdout] 73 | Ok(v) => ConfigResult::Valid(v), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | Err(err) => ConfigResult::Invalid(T::default(), err.to_string()), [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | let (config_tx, mut config_rx) = watch::channel(initial_value); [INFO] [stdout] | --------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let config_tx2 = config_tx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let deserializer_thread = tokio::spawn(async move { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 107 | let config_rx2 = config_rx.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let serializer_thread = tokio::spawn(async move { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 130 | | serializer_thread, [INFO] [stdout] 131 | | deserializer_thread, [INFO] [stdout] 132 | | rx: config_rx, [INFO] [stdout] 133 | | tx: config_tx, [INFO] [stdout] 134 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `avdanos-research` (bin "avdanos-research" test) due to 7 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `avdanos-research` (bin "avdanos-research") due to 7 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c3bbdf653cf88b5bed9dc8b1c796a2d6cc2862389218286cc65f1b60de460a50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c3bbdf653cf88b5bed9dc8b1c796a2d6cc2862389218286cc65f1b60de460a50", kill_on_drop: false }` [INFO] [stdout] c3bbdf653cf88b5bed9dc8b1c796a2d6cc2862389218286cc65f1b60de460a50