[INFO] cloning repository https://github.com/SamirTalwar/sandcastles [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SamirTalwar/sandcastles" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamirTalwar%2Fsandcastles", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamirTalwar%2Fsandcastles'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 35047ac55c05328c20b8d6b031a6b65d81d90c33 [INFO] checking SamirTalwar/sandcastles/35047ac55c05328c20b8d6b031a6b65d81d90c33 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamirTalwar%2Fsandcastles" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/SamirTalwar/sandcastles on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/SamirTalwar/sandcastles [INFO] finished tweaking git repo https://github.com/SamirTalwar/sandcastles [INFO] tweaked toml for git repo https://github.com/SamirTalwar/sandcastles written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/SamirTalwar/sandcastles already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fc7a1d9144b873d388d54617f2d050895f979d482fdeea6f4515bd59f42cff32 [INFO] running `Command { std: "docker" "start" "-a" "fc7a1d9144b873d388d54617f2d050895f979d482fdeea6f4515bd59f42cff32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fc7a1d9144b873d388d54617f2d050895f979d482fdeea6f4515bd59f42cff32", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fc7a1d9144b873d388d54617f2d050895f979d482fdeea6f4515bd59f42cff32", kill_on_drop: false }` [INFO] [stdout] fc7a1d9144b873d388d54617f2d050895f979d482fdeea6f4515bd59f42cff32 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f1f1a1c02fe7625a07f0a654766c0ffee5c783cd2d96f22530792f8ec7e41a8 [INFO] running `Command { std: "docker" "start" "-a" "8f1f1a1c02fe7625a07f0a654766c0ffee5c783cd2d96f22530792f8ec7e41a8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling hashbrown v0.14.0 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking anstream v0.5.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling winnow v0.5.15 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling indexmap v2.0.0 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking iana-time-zone v0.1.57 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking regex-automata v0.3.8 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking fastrand v2.0.0 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking rmp v0.8.12 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking tokio v1.32.0 [INFO] [stderr] Compiling toml_edit v0.19.14 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling ntest_test_cases v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling clap_derive v4.4.2 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling ntest_timeout v0.9.0 [INFO] [stderr] Checking ntest v0.9.0 [INFO] [stderr] Checking clap v4.4.2 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking bstr v1.6.2 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking chrono v0.4.29 [INFO] [stderr] Checking rmp-serde v1.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking sandcastles v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tempfile v3.8.0 [INFO] [stderr] Checking reqwest v0.11.20 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 16 | let socket = UnixStream::connect(socket_path) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | .map_err(|error| ClientError::SocketConnectionError(error.into()))?; [INFO] [stdout] 18 | Ok(Client { socket }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 94 | fn read_from(reader: impl io::Read) -> CommunicationResult { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | rmp_serde::decode::from_read(reader).map_err(|error| match error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/communication.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 107 | fn write_to(&self, mut writer: impl io::Write) -> CommunicationResult<()> { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | rmp_serde::encode::write(&mut writer, self).map_err(|error| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub fn start(socket_path: PathBuf, supervisor: Supervisor) -> DaemonResult { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let listener = UnixListener::bind(&socket_path) [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let stop_signal = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let stop_signal_for_start = Arc::clone(&stop_signal); [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let thread_handle = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | socket_path, [INFO] [stdout] 50 | | stop_handle: Mutex::new(StopHandle::Thread(thread_handle)), [INFO] [stdout] 51 | | stop_signal, [INFO] [stdout] 52 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon.rs:111:21 [INFO] [stdout] | [INFO] [stdout] 107 | Ok(stream) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let supervisor_for_connection = supervisor.clone(); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let stop_sender_for_connection = stop_sender.clone(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 110 | thread::spawn(move || { [INFO] [stdout] 111 | / stream [INFO] [stdout] 112 | | .set_nonblocking(false) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/daemon.rs:114:35 [INFO] [stdout] | [INFO] [stdout] 107 | Ok(stream) => { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let supervisor_for_connection = supervisor.clone(); [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let stop_sender_for_connection = stop_sender.clone(); [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | .and_then(|_| { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 115 | | handle_connection( [INFO] [stdout] 116 | | stream, [INFO] [stdout] 117 | | &supervisor_for_connection, [INFO] [stdout] 118 | | stop_sender_for_connection, [INFO] [stdout] 119 | | ) [INFO] [stdout] 120 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/services/programs.rs:103:12 [INFO] [stdout] | [INFO] [stdout] 98 | let process = Command::new(&self.command) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(RunningProgram { process }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/supervisor.rs:44:15 [INFO] [stdout] | [INFO] [stdout] 42 | let mut inner = self.0.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | let name = &instruction.name; [INFO] [stdout] 44 | match inner.retrieve(name) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sandcastles` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8f1f1a1c02fe7625a07f0a654766c0ffee5c783cd2d96f22530792f8ec7e41a8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f1f1a1c02fe7625a07f0a654766c0ffee5c783cd2d96f22530792f8ec7e41a8", kill_on_drop: false }` [INFO] [stdout] 8f1f1a1c02fe7625a07f0a654766c0ffee5c783cd2d96f22530792f8ec7e41a8